Re: Gnus registry upgrade didn't import old registry

[Ted Zlatanov <tzz@lifelogs.com>]

On Mon, 26 Sep 2011 22:35:25 -0400 Dan Christensen <jdc@uwo.ca> wrote: 

DC> Here's my guess at the bug:

DC> In gnus-registry.el:

DC> (defun gnus-registry-fixup-registry (db)
DC>   (when db
DC>     (let ((old (oref db :tracked)))
DC> ...
DC>       (oset db :max-hard
DC>             (or gnus-registry-max-entries
DC>                 most-positive-fixnum))
DC> ...
DC>       (oset db :max-soft
DC>             (or gnus-registry-max-pruned-entries
DC>                 most-positive-fixnum))

DC> If the user sets gnus-registry-max-entries but not
DC> gnus-registry-max-pruned-entries, then the soft limit might be (much)
DC> higher than the hard limit.  Maybe the last line should be changed to
DC> replace `most-positive-fixnum' with something like `(oget db :max-hard)'
DC> (just guessing at how to read a stored value).

I have (in set-custom-variables)

'(gnus-registry-ignored-groups (quote (("nntp" t) ("nnrss" t) ("spam" t) ("train" t) ("cron" t))))
'(gnus-registry-install t)
'(gnus-registry-max-entries 100000)
'(gnus-registry-split-strategy (quote majority))
'(gnus-registry-track-extra (quote (sender subject)))
'(gnus-registry-unfollowed-groups (quote ("train$" "delayed$" "drafts$" "queue$" "INBOX$")))

and the pruning works fine for me.  Could you look at what the following
produces?  This should simulate the candidates that `registry-prune'
gets:

  (let* ((db gnus-registry-db)
         (hs (oref db :max-hard))
         (ss (oref db :max-soft)))
    (oset db :max-hard 10000)
    (oset db :max-soft most-positive-fixnum)
    (prog1 (list (registry-prune-soft-candidates db)
                 (registry-prune-hard-candidates db))
           (oset db :max-hard hs)
           (oset db :max-soft ss)))

Thanks
Ted