From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/78387 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: no gnus registry new dependency on ert? Date: Wed, 06 Apr 2011 09:26:55 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <8762qrqwuo.fsf@lifelogs.com> References: <8762qs3swu.fsf@ericabrahamsen.net> <87ipur8zny.fsf@lifelogs.com> <87aag38xah.fsf@lifelogs.com> <87vcyrr0ec.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1302100047 19844 80.91.229.12 (6 Apr 2011 14:27:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 6 Apr 2011 14:27:27 +0000 (UTC) Cc: ding@gnus.org To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 06 16:27:20 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q7ThV-0000zO-Sa for ged-emacs-devel@m.gmane.org; Wed, 06 Apr 2011 16:27:18 +0200 Original-Received: from localhost ([127.0.0.1]:40493 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7ThV-0004a3-7A for ged-emacs-devel@m.gmane.org; Wed, 06 Apr 2011 10:27:17 -0400 Original-Received: from [140.186.70.92] (port=35100 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7ThP-0004Zh-MR for emacs-devel@gnu.org; Wed, 06 Apr 2011 10:27:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7ThO-0002RH-Al for emacs-devel@gnu.org; Wed, 06 Apr 2011 10:27:11 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:54987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7ThN-0002Pv-VA for emacs-devel@gnu.org; Wed, 06 Apr 2011 10:27:10 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Q7ThL-0000qe-Tu for emacs-devel@gnu.org; Wed, 06 Apr 2011 16:27:07 +0200 Original-Received: from 38.98.147.130 ([38.98.147.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 06 Apr 2011 16:27:07 +0200 Original-Received: from tzz by 38.98.147.130 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 06 Apr 2011 16:27:07 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 54 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 38.98.147.130 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110016 (No Gnus v0.16) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:RMBqT0gwfamFPDvllTmFX5QTU1Q= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138237 gmane.emacs.gnus.general:78387 Archived-At: --=-=-= Content-Type: text/plain On Wed, 06 Apr 2011 15:28:07 +0200 David Engster wrote: DE> It seems like putting (require 'ert) into an eval-when-compile is not DE> sufficient. You have to require it unconditionally. DE> So maybe your first idea was The Right Thing To Do, meaning to use DE> (require 'ert nil t) DE> and then test for feature 'ert. Alternatively, you could use the current DE> hack and put this require in there, too. But this is getting DE> increasingly ugly... See the attached patch, which just adds (require 'ert nil t) *in addition* to the defmacro hack. It seems to DTRT for me, let me know what you think. Ted --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=registry-ert-loading.patch diff --git a/lisp/gnus-registry.el b/lisp/gnus-registry.el index 511012d..6c660b1 100644 --- a/lisp/gnus-registry.el +++ b/lisp/gnus-registry.el @@ -61,6 +61,7 @@ (when (null (require 'ert nil t)) (defmacro* ert-deftest (name () &body docstring-keys-and-body)))) +(require 'ert nil t) (require 'gnus) (require 'gnus-int) (require 'gnus-sum) diff --git a/lisp/registry.el b/lisp/registry.el index cc03b20..edaa4f5 100644 --- a/lisp/registry.el +++ b/lisp/registry.el @@ -81,6 +81,8 @@ (when (null (require 'ert nil t)) (defmacro* ert-deftest (name () &body docstring-keys-and-body)))) +(require 'ert nil t) + (eval-when-compile (require 'cl)) (eval-and-compile (or (ignore-errors (progn --=-=-=--