From: Daniel Schoepe <daniel.schoepe@googlemail.com>
To: ding@gnus.org
Subject: [patch] gnus-summary-articles-in-thread doesn't work properly with explicit argument
Date: Wed, 24 Nov 2010 17:12:08 +0100 [thread overview]
Message-ID: <8762vmlmzr.fsf@gilead.home.box> (raw)
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
When calling gnus-summary-articles-in-thread with an article that is
different from (gnus-summary-article-number), it can return incorrent
results:
[post]
[reply1]
[reply2]
[reply3]
When calling gnus-summary-articles-in-thread with post's id as argument,
while the point is at [reply2], gnus-summary-go-to-next-thread will jump
to reply3 causing gnus-summary-articles-in-thread to stop searching for
messages right before [reply3].
I think this behaviour is a bug, since it doesn't conform to the
function's documentation.
I attached a patch that should fix this.
Regards,
Daniel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch to fix mentioned issue --]
[-- Type: text/x-patch, Size: 938 bytes --]
From dbcc189b4c9d4c53f7254a1e67040805bd7e4f26 Mon Sep 17 00:00:00 2001
From: Daniel Schoepe <daniel.schoepe@googlemail.com>
Date: Wed, 24 Nov 2010 16:45:26 +0100
Subject: [PATCH] go to correct line in Summary buffer in gnus-summary-articles-in-thread
This fixes a bug that causes gnus-summary-articles-in-thread to return
incorrect results when calling it with an explicit article argument
different from (gnus-summary-article-number)
---
lisp/gnus-sum.el | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lisp/gnus-sum.el b/lisp/gnus-sum.el
index ff85d45..4e4fc5b 100644
--- a/lisp/gnus-sum.el
+++ b/lisp/gnus-sum.el
@@ -11232,6 +11232,7 @@ with that article."
(mail-header-subject (gnus-data-header (car data)))))
(t nil)))
(end-point (save-excursion
+ (goto-char (gnus-data-pos (car data)))
(if (gnus-summary-go-to-next-thread)
(point) (point-max))))
articles)
--
1.7.2.3
next reply other threads:[~2010-11-24 16:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 16:12 Daniel Schoepe [this message]
2010-11-24 20:28 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762vmlmzr.fsf@gilead.home.box \
--to=daniel.schoepe@googlemail.com \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).