From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/74300 Path: news.gmane.org!not-for-mail From: Daniel Schoepe Newsgroups: gmane.emacs.gnus.general Subject: [patch] gnus-summary-articles-in-thread doesn't work properly with explicit argument Date: Wed, 24 Nov 2010 17:12:08 +0100 Organization: Gnus News User Services Message-ID: <8762vmlmzr.fsf@gilead.home.box> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1290615623 6105 80.91.229.12 (24 Nov 2010 16:20:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 24 Nov 2010 16:20:23 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M22665@lists.math.uh.edu Wed Nov 24 17:20:16 2010 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PLI4u-0006yN-8b for ding-account@gmane.org; Wed, 24 Nov 2010 17:20:16 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1PLI40-0000xr-SF; Wed, 24 Nov 2010 10:19:20 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1PLHx8-0000vy-A6 for ding@lists.math.uh.edu; Wed, 24 Nov 2010 10:12:14 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1PLHx4-000529-BF for ding@lists.math.uh.edu; Wed, 24 Nov 2010 10:12:11 -0600 Original-Received: from news by quimby.gnus.org with local (Exim 3.36 #1 (Debian)) id 1PLHx3-0007iX-00 for ; Wed, 24 Nov 2010 17:12:09 +0100 Original-Path: not-for-mail Original-Newsgroups: gnus.ding Original-Lines: 61 Original-NNTP-Posting-Host: 178.4.222.19 Original-X-Trace: quimby.gnus.org 1290615129 28493 178.4.222.19 (24 Nov 2010 16:12:09 GMT) Original-X-Complaints-To: usenet@quimby.gnus.org Original-NNTP-Posting-Date: Wed, 24 Nov 2010 16:12:09 +0000 (UTC) User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2 (gnu/linux) Cancel-Lock: sha1:6IwGZ82dBmDvlObWT4E3Kck2ocg= X-Spam-Score: -2.0 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:74300 Archived-At: --=-=-= Content-Type: text/plain When calling gnus-summary-articles-in-thread with an article that is different from (gnus-summary-article-number), it can return incorrent results: [post] [reply1] [reply2] [reply3] When calling gnus-summary-articles-in-thread with post's id as argument, while the point is at [reply2], gnus-summary-go-to-next-thread will jump to reply3 causing gnus-summary-articles-in-thread to stop searching for messages right before [reply3]. I think this behaviour is a bug, since it doesn't conform to the function's documentation. I attached a patch that should fix this. Regards, Daniel --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-go-to-correct-line-in-Summary-buffer-in-gnus-summary.patch Content-Description: Patch to fix mentioned issue >From dbcc189b4c9d4c53f7254a1e67040805bd7e4f26 Mon Sep 17 00:00:00 2001 From: Daniel Schoepe Date: Wed, 24 Nov 2010 16:45:26 +0100 Subject: [PATCH] go to correct line in Summary buffer in gnus-summary-articles-in-thread This fixes a bug that causes gnus-summary-articles-in-thread to return incorrect results when calling it with an explicit article argument different from (gnus-summary-article-number) --- lisp/gnus-sum.el | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lisp/gnus-sum.el b/lisp/gnus-sum.el index ff85d45..4e4fc5b 100644 --- a/lisp/gnus-sum.el +++ b/lisp/gnus-sum.el @@ -11232,6 +11232,7 @@ with that article." (mail-header-subject (gnus-data-header (car data))))) (t nil))) (end-point (save-excursion + (goto-char (gnus-data-pos (car data))) (if (gnus-summary-go-to-next-thread) (point) (point-max)))) articles) -- 1.7.2.3 --=-=-=--