From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/68534 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: Following boxquote links in a message buffer borkes it! Date: Sat, 09 May 2009 12:32:00 +0200 Message-ID: <8763gay3bz.fsf@marauder.physik.uni-ulm.de> References: <87ws8rzur7.fsf@thinkpad.tsdh.de> <87iqkbo6zn.fsf@marauder.physik.uni-ulm.de> <87d4ajtq8q.fsf@thinkpad.tsdh.de> <87ab5nnwo5.fsf@marauder.physik.uni-ulm.de> <873abfteyw.fsf@thinkpad.tsdh.de> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1241865155 29248 80.91.229.12 (9 May 2009 10:32:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 May 2009 10:32:35 +0000 (UTC) Cc: ding@gnus.org To: Dave Pearson Original-X-From: ding-owner+M16965@lists.math.uh.edu Sat May 09 12:32:26 2009 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1M2jqz-0005Xe-PG for ding-account@gmane.org; Sat, 09 May 2009 12:32:26 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1M2jqu-0007IY-0r; Sat, 09 May 2009 05:32:20 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1M2jqs-0007I8-E3 for ding@lists.math.uh.edu; Sat, 09 May 2009 05:32:18 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1M2jqm-0000uO-4g for ding@lists.math.uh.edu; Sat, 09 May 2009 05:32:18 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1M2jrD-0008FD-00 for ; Sat, 09 May 2009 12:32:39 +0200 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.175]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id n49AW3fQ021128; Sat, 9 May 2009 12:32:03 +0200 (MEST) Original-Received: from localhost (localhost [127.0.0.1]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 44C5C1389C; Sat, 9 May 2009 12:32:03 +0200 (CEST) X-Face: P05mdcZT&lL[-s2=mw~RsllZ0zZAb?vdE}.s, ding@gnus.org In-Reply-To: <873abfteyw.fsf@thinkpad.tsdh.de> (Tassilo Horn's message of "Sat, 09 May 2009 00:19:35 +0200") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.1 (gnu/linux) X-DCC-INFN-TO-Metrics: poseidon 1233; Body=2 Fuz1=2 Fuz2=2 X-Virus-Scanned: by amavisd-new X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:68534 Archived-At: On Sat, May 09 2009, Tassilo Horn wrote: > Reiner Steib writes: > >> I think `boxquote.el' doesn't do anything WRT this. It simply copies >> the text from the *Help* buffer. > > But when I kill the text from a *Help* buffer and yank it to *scratch* > the links aren't clickable anymore; RET just insterts a newline. Does > normal `M-< C-SPC M-> C-w' followed by `C-y' not copy the relevant > properties? No, see... ,----[ v yank-excluded-properties RET ] | yank-excluded-properties is a variable defined in `simple.el'. | Its value is | (read-only invisible intangible field mouse-face help-echo local-map | keymap yank-handler follow-link fontified) | | Documentation: | *Text properties to discard when yanking. | The value should be a list of text properties to discard or t, | which means to discard all text properties. | | You can customize this variable. `---- But `boxquote.el' doesn't use `yank' for `boxquote-describe-variable'. `boxquote-quote-help-buffer' doesn't exclude properties and `boxquote-text' does an `insert' (not a `yank') which preserves the properties. As `boxquote.el' excludes the properties in other functions, I guess it is an oversight. Dave, I'd suggest to add the following patch. 2009-05-09 Reiner Steib * boxquote.el (boxquote-quote-help-buffer): Strip text properties to avoid destroying the target buffer content when clicking on a help link. Reported by Tassilo Horn . --8<---------------cut here---------------start------------->8--- --- boxquote.el.~1.21~ 2008-05-21 12:10:13.000000000 +0200 +++ boxquote.el 2009-05-09 12:29:42.000000000 +0200 @@ -1,5 +1,5 @@ ;;; boxquote.el --- Quote text with a semi-box. -;; Copyright 1999-2008 by Dave Pearson +;; Copyright 1999-2009 by Dave Pearson ;; $Revision: 1.21 $ ;; boxquote.el is free software distributed under the terms of the GNU @@ -428,11 +428,13 @@ (save-window-excursion (funcall help-call) (with-current-buffer (boxquote-help-buffer-name (funcall item)) - (buffer-string)))) + ;; Strip text properties to avoid destroying the target buffer + ;; content when clicking on a help link. + (buffer-substring-no-properties (point-min) (point-max))))) (boxquote-title (format title-format (funcall item))) (when one-window-p (delete-other-windows)))) - + ;;;###autoload (defun boxquote-describe-function () "Call `describe-function' and boxquote the output into the current buffer." --8<---------------cut here---------------end--------------->8--- Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/