* Re: [bug] Gnus weird behavior [not found] ` <f69026cb-5d16-48fd-87e6-64d873376bb3@well-done.deisui.org> @ 2006-12-27 21:39 ` Reiner Steib 2006-12-28 8:48 ` Daiki Ueno 0 siblings, 1 reply; 7+ messages in thread From: Reiner Steib @ 2006-12-27 21:39 UTC (permalink / raw) Cc: emacs-pretest-bug, Leo, Gnus On Tue, Dec 26 2006, Daiki Ueno wrote: >>>>>> In <m2odpv5kg1.fsf@sl392.st-edmunds.cam.ac.uk> >>>>>> Leo <sdl.web@gmail.com> wrote: >> To reproduce: > >> - go to the article buffer >> - click the right arrow in the toolbar > >> Backtrace: >> ,---- >> | Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) >> | gnus-summary-next-article(nil) >> | call-interactively(gnus-summary-next-article) >> `---- > > The cause of the problem seems that gnus-article-mode uses > gnus-summary-mode's tool-bar-map and a few commands in it expect to be > called from the summary buffers. [...] > Here is a patch. Would you please install your patch in the v5-10 branch? Or do you or anyone else see a problem with it or a better fix? > Index: lisp/gnus/gnus-sum.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/gnus/gnus-sum.el,v > retrieving revision 1.96 > diff -c -r1.96 gnus-sum.el > --- lisp/gnus/gnus-sum.el 12 Dec 2006 16:12:12 -0000 1.96 > +++ lisp/gnus/gnus-sum.el 26 Dec 2006 01:12:40 -0000 > @@ -7333,6 +7333,9 @@ > If SUBJECT, only articles with SUBJECT are selected. > If BACKWARD, the previous article is selected instead of the next." > (interactive "P") > + ;; Make sure we are in the summary buffer. > + (unless (eq major-mode 'gnus-summary-mode) > + (set-buffer gnus-summary-buffer)) > (cond > ;; Is there such an article? > ((and (gnus-summary-search-forward unread subject backward) Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [bug] Gnus weird behavior 2006-12-27 21:39 ` [bug] Gnus weird behavior Reiner Steib @ 2006-12-28 8:48 ` Daiki Ueno 2006-12-28 14:15 ` Summary and article tool bar (was: [bug] Gnus weird behavior) Reiner Steib 2006-12-29 15:44 ` [bug] Gnus weird behavior Richard Stallman 0 siblings, 2 replies; 7+ messages in thread From: Daiki Ueno @ 2006-12-28 8:48 UTC (permalink / raw) Cc: Leo, emacs-pretest-bug, Gnus >>>>> In <v9r6ul9fww.fsf@marauder.physik.uni-ulm.de> >>>>> Reiner Steib <reinersteib+gmane@imap.cc> wrote: > > The cause of the problem seems that gnus-article-mode uses > > gnus-summary-mode's tool-bar-map and a few commands in it expect to be > > called from the summary buffers. > [...] > > Here is a patch. > Would you please install your patch in the v5-10 branch? Or do you or > anyone else see a problem with it or a better fix? Done. Though it might be better to provide a new tool-bar-map for gnus-article-mode, such a change should be first introduced to the development branch of Gnus, I think. Regards, -- Daiki Ueno ^ permalink raw reply [flat|nested] 7+ messages in thread
* Summary and article tool bar (was: [bug] Gnus weird behavior) 2006-12-28 8:48 ` Daiki Ueno @ 2006-12-28 14:15 ` Reiner Steib 2006-12-29 15:44 ` [bug] Gnus weird behavior Richard Stallman 1 sibling, 0 replies; 7+ messages in thread From: Reiner Steib @ 2006-12-28 14:15 UTC (permalink / raw) Cc: Daiki Ueno [ Stripped some recipients ] On Thu, Dec 28 2006, Daiki Ueno wrote: >>>>>> In <v9r6ul9fww.fsf@marauder.physik.uni-ulm.de> >>>>>> Reiner Steib <reinersteib+gmane@imap.cc> wrote: >> Would you please install your patch in the v5-10 branch? Or do you or >> anyone else see a problem with it or a better fix? > > Done. Thanks. > Though it might be better to provide a new tool-bar-map for > gnus-article-mode, such a change should be first introduced to the > development branch of Gnus, I think. I don't see any need for different tool bars for summary and article buffers as long as we don't have icons specific to either one (e.g. like <menu-bar> <Treatment>). Could you elaborate, please? Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [bug] Gnus weird behavior 2006-12-28 8:48 ` Daiki Ueno 2006-12-28 14:15 ` Summary and article tool bar (was: [bug] Gnus weird behavior) Reiner Steib @ 2006-12-29 15:44 ` Richard Stallman 2006-12-29 15:57 ` Reiner Steib 1 sibling, 1 reply; 7+ messages in thread From: Richard Stallman @ 2006-12-29 15:44 UTC (permalink / raw) Cc: Reiner.Steib, emacs-pretest-bug, sdl.web, ding > Would you please install your patch in the v5-10 branch? Or do you or > anyone else see a problem with it or a better fix? Done. Is this patch installed in Emacs yet? Does it fix the problem that Leo reported? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [bug] Gnus weird behavior 2006-12-29 15:44 ` [bug] Gnus weird behavior Richard Stallman @ 2006-12-29 15:57 ` Reiner Steib 2006-12-30 6:23 ` Richard Stallman 0 siblings, 1 reply; 7+ messages in thread From: Reiner Steib @ 2006-12-29 15:57 UTC (permalink / raw) Cc: emacs-pretest-bug, Daiki Ueno, sdl.web, ding On Fri, Dec 29 2006, Richard Stallman wrote: > > Would you please install your patch in the v5-10 branch? Or do you or > > anyone else see a problem with it or a better fix? > > Done. > > Is this patch installed in Emacs yet? No. But it has been installed in the stable (v5-10) branch of Gnus. It will be synched to Emacs with Miles (Cc-ed) next sync. [ There have been some other fixed (mostly documentation issues) since the last sync, so it's better to wait for Miles than to only apply this patch. ] > Does it fix the problem that Leo reported? Yes. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [bug] Gnus weird behavior 2006-12-29 15:57 ` Reiner Steib @ 2006-12-30 6:23 ` Richard Stallman 2006-12-30 15:36 ` Miles Bader 0 siblings, 1 reply; 7+ messages in thread From: Richard Stallman @ 2006-12-30 6:23 UTC (permalink / raw) Cc: emacs-pretest-bug, ueno, sdl.web, ding No. But it has been installed in the stable (v5-10) branch of Gnus. It will be synched to Emacs with Miles (Cc-ed) next sync. Miles, would you please tell me when this is done, so I can remove that item from FOR-RELEASE? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [bug] Gnus weird behavior 2006-12-30 6:23 ` Richard Stallman @ 2006-12-30 15:36 ` Miles Bader 0 siblings, 0 replies; 7+ messages in thread From: Miles Bader @ 2006-12-30 15:36 UTC (permalink / raw) Cc: ding Richard Stallman <rms@gnu.org> writes: > No. But it has been installed in the stable (v5-10) branch of Gnus. > It will be synched to Emacs with Miles (Cc-ed) next sync. > > Miles, would you please tell me when this is done, so I can remove > that item from FOR-RELEASE? OK, it's done. -miles -- "Suppose we've chosen the wrong god. Every time we go to church we're just making him madder and madder." -- Homer Simpson ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2006-12-30 15:36 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <m2odpv5kg1.fsf@sl392.st-edmunds.cam.ac.uk> [not found] ` <f69026cb-5d16-48fd-87e6-64d873376bb3@well-done.deisui.org> 2006-12-27 21:39 ` [bug] Gnus weird behavior Reiner Steib 2006-12-28 8:48 ` Daiki Ueno 2006-12-28 14:15 ` Summary and article tool bar (was: [bug] Gnus weird behavior) Reiner Steib 2006-12-29 15:44 ` [bug] Gnus weird behavior Richard Stallman 2006-12-29 15:57 ` Reiner Steib 2006-12-30 6:23 ` Richard Stallman 2006-12-30 15:36 ` Miles Bader
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).