message-newline-and-reformat - changed (buggy?) behavior

message-newline-and-reformat - changed (buggy?) behavior

[Dmitry Yaitskov]

Hi,

In message mode, prior to Oort Gnus v0.01, if I pressed M-q (which
invokes (message-newline-and-reformat t) in the 1st position of the
1st line of the following text (paragraph):

> blah blah blah blah blah blah blah blah blah blah blah blah blah blah
blah blah blah blah blah blah blah blah blah blah blah blah blah blah
blah blah blah blah blah blah blah blah blah blah blah

the whole paragraph got formatted and quoted properly:

> blah blah blah blah blah blah blah blah blah blah blah blah blah
> blah blah blah blah blah blah blah blah blah blah blah blah blah
> blah blah blah blah blah blah blah blah blah blah blah blah blah

- which was exactly what I wanted. Now, the text looks like this:

> blah blah blah blah blah blah blah blah blah blah blah blah blah
> blah
blah blah blah blah blah blah blah blah blah blah blah blah blah blah
blah blah blah blah blah blah blah blah blah blah blah

- which looks weird and not very useful. OTOH, if I press M-Enter
instead (which invokes same message-newline-and-reformat but w/out the
argument that tells not to insert newlines), I still get the old
(correct IMHO) result (with 4 newlines inserted as per the doc).

The patch below fixes this for me, but I am not sure I understood the
intent of the code correctly...

XEmacs 21.2  (beta43) "Terspichore" [Lucid] (i686-pc-cygwin) of Tue Jan 30 2001 on LUCY
Oort Gnus v0.01


---------------------------- cut here ----------------------------
Index: message.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/message.el,v
retrieving revision 6.54
diff -u -r6.54 message.el
--- message.el  2001/01/21 05:15:20     6.54
+++ message.el  2001/02/06 17:16:17
@@ -1810,7 +1810,6 @@
       (looking-at "[ \t]*")
       (setq leading-space (match-string 0)))
     (if (and quoted
-            (not not-break)
             (< (- point beg) (length quoted)))
        ;; break in the cite prefix.
        (setq quoted nil
---------------------------- cut here ----------------------------

-- 
Cheers,
-Dima.

Re: message-newline-and-reformat - changed (buggy?) behavior

[ShengHuo ZHU]

Dmitry Yaitskov <dimas@home.com> writes:

> Hi,
> 
> In message mode, prior to Oort Gnus v0.01, if I pressed M-q (which
> invokes (message-newline-and-reformat t) in the 1st position of the
> 1st line of the following text (paragraph):
> 
> > blah blah blah blah blah blah blah blah blah blah blah blah blah blah
> blah blah blah blah blah blah blah blah blah blah blah blah blah blah
> blah blah blah blah blah blah blah blah blah blah blah
> 
> the whole paragraph got formatted and quoted properly:
> 
> > blah blah blah blah blah blah blah blah blah blah blah blah blah
> > blah blah blah blah blah blah blah blah blah blah blah blah blah
> > blah blah blah blah blah blah blah blah blah blah blah blah blah
> 
> - which was exactly what I wanted. Now, the text looks like this:
> 
> > blah blah blah blah blah blah blah blah blah blah blah blah blah
> > blah
> blah blah blah blah blah blah blah blah blah blah blah blah blah blah
> blah blah blah blah blah blah blah blah blah blah blah
> 
> - which looks weird and not very useful. OTOH, if I press M-Enter
> instead (which invokes same message-newline-and-reformat but w/out the
> argument that tells not to insert newlines), I still get the old
> (correct IMHO) result (with 4 newlines inserted as per the doc).

There are newlines between blah lines, which means that the first line
is quoted text, and the other two are not.  In oGnus, M-q only
reformats within one type of text, so the behavior is right.  If you
don't like the behavior, bind M-q to fill-paragraph.

ShengHuo

-- 
(setq gnus-posting-styles '((".*" (signature-file "~/.signature"))))