URL buttons and new browser windows...

[Daniel Pittman <daniel@danann.net>]

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]

Given that I am often on a relatively slow connection, I tend to use my
web browser as a background process--create a new window for an URL, do
something for a while and then go and read it.

This is fairly trivial to do and works well with the XEmacs 'browse-url'
library and 'browse-url-new-window-p' set to 't'. This should cause the
package to open a new window when a URL is visited.

pGnus in the article buttonization code does not use the top level
entry-point for 'browse-url' but rather directly calls the selected
function (browse.*netscape) in my case :)

The problem is that gnus did not respect the setting of
'browse-url-new-window-p' which was annoying to me.

The attached patch corrects this and is, I believe, trivially correct.

        Daniel


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: browse-url patch --]
[-- Type: text/x-patch, Size: 691 bytes --]

Index: lisp/gnus-art.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-art.el,v
retrieving revision 5.89
diff -u -r5.89 gnus-art.el
--- lisp/gnus-art.el	1999/11/07 03:26:48	5.89
+++ lisp/gnus-art.el	1999/11/17 00:16:13
@@ -4388,7 +4388,9 @@
   ;; In Emacs 20, `browse-url-browser-function' may be an alist.
   (if (listp browse-url-browser-function)
       (browse-url address)
-    (funcall browse-url-browser-function address)))
+    (funcall browse-url-browser-function address 
+	     (and (boundp browse-url-new-window-p)
+		  browse-url-new-window-p))))
 
 (defun gnus-button-embedded-url (address)
   "Browse ADDRESS."

[-- Attachment #3: Type: text/plain, Size: 278 bytes --]


-- 
Any form of power without responsibility, without direct and formal checks and
balances, is frightening to people -- and reasonably so. It should be frankly
admitted that hackers are frightening, and that the basis of this fear is not
irrational.
        -- Bruce Sterling