Bug#39515 and searching topic groups

Bug#39515 and searching topic groups

[Eric Abrahamsen]

Hi all,

Take a look at bug#39515. If you do "G G" on a topic line, would you
expect nnir to search all the topic's groups, or only the topic's
_visible_ groups. Ie, would you expect to be searching groups you can't
see, under the topic heading? Current behavior is to only search visible
groups.

Alternately, would you want a customization option to control this
behavior?

Eric

Re: Bug#39515 and searching topic groups

[Adam Sjøgren]

Eric writes:

> Take a look at bug#39515. If you do "G G" on a topic line, would you
> expect nnir to search all the topic's groups, or only the topic's
> _visible_ groups.

Without reading the bug (sorry), I would expect it to search all the
groups under the topic, visible or not.


  Best regards,

-- 
 "No, I agree with you, Dave, obviously everything          Adam Sjøgren
  can't have a matching closing tag unless you're an   asjo@koldfront.dk
  xslt programmer."

Re: Bug#39515 and searching topic groups

[Eric Abrahamsen]

Adam Sjøgren <asjo@koldfront.dk> writes:

> Eric writes:
>
>> Take a look at bug#39515. If you do "G G" on a topic line, would you
>> expect nnir to search all the topic's groups, or only the topic's
>> _visible_ groups.
>
> Without reading the bug (sorry), I would expect it to search all the
> groups under the topic, visible or not.

Vote noted! Thanks.

Re: Bug#39515 and searching topic groups

[Amin Bandali]

Hi,

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Hi all,
>
> Take a look at bug#39515. If you do "G G" on a topic line, would you
> expect nnir to search all the topic's groups, or only the topic's
> _visible_ groups. Ie, would you expect to be searching groups you can't
> see, under the topic heading? Current behavior is to only search visible
> groups.
>
> Alternately, would you want a customization option to control this
> behavior?
>
> Eric

Interesting!  I'm not sure which makes more sense.  Perhaps the default
should be searching all groups under that topic, be them visible or not?
But I personally would probably prefer the other way (searching only the
visible groups under the topic), if there was a customization option.

Alternatively, or additionally, a way to control this on a case-by-case
basis and quickly, e.g. using a prefix-arg or something, would be handy
I think.

Re: Bug#39515 and searching topic groups

[dick.r.chiang]

I haven't looked at the code but bug#39515 specifies "permanently visible" as
a necessary condition for search.

"gnus-permanently-visible-groups" is a defcustom that defaults to nil.  Having
the "G G" do nothing merely because the user didn't override this
defcustom seems like a bug.

Re: Bug#39515 and searching topic groups

[Eric S Fraga]

On Monday, 10 Feb 2020 at 13:18, Eric Abrahamsen wrote:
> Take a look at bug#39515. If you do "G G" on a topic line, would you
> expect nnir to search all the topic's groups, or only the topic's
> _visible_ groups. 

I would want it to search all groups under the topic.  Practising a
inbox 0 approach to email management, most of my groups are not visible.

-- 
Eric S Fraga via Emacs 28.0.50 & org 9.3.2 on Debian bullseye/sid

Re: Bug#39515 and searching topic groups

[Andrew Cohen]

When I originally wrote this code it searched all groups, not just the
visible ones. Someone improved the code at some point, but made the
change (probably unintentional) to only search visible groups. I think
it should be reverted to the previous behavior (my my personal tree does
not have the "improvement" so exhibits the original behavior---thats why
I was never able to reproduce this bug).

Re: Bug#39515 and searching topic groups

[Eric Abrahamsen]

Andrew Cohen <cohen@bu.edu> writes:

> When I originally wrote this code it searched all groups, not just the
> visible ones. Someone improved the code at some point, but made the
> change (probably unintentional) to only search visible groups. I think
> it should be reverted to the previous behavior (my my personal tree does
> not have the "improvement" so exhibits the original behavior---thats why
> I was never able to reproduce this bug).

Okay, I was going to say that we should have a strong preponderance of
votes before changing the current behavior, but if the current behavior
is a bit of an accident to begin with, we should just change it. I'll
follow this up on the bug tracker.

Thanks,
Eric