From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/86045 Path: news.gmane.org!not-for-mail From: Dan Christensen Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH 0/2] two minor fixes for new/empty nnimap group handling Date: Wed, 08 Jul 2015 17:45:20 -0400 Message-ID: <877fqa728f.fsf@uwo.ca> References: <1435750676-710-1-git-send-email-bjorn@mork.no> <87y4itti71.fsf@uwo.ca> <878uaspts1.fsf@ericabrahamsen.net> <87io9va7f5.fsf@uwo.ca> <87zj37nuu3.fsf@ericabrahamsen.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1436391993 31140 80.91.229.3 (8 Jul 2015 21:46:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 Jul 2015 21:46:33 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M34280@lists.math.uh.edu Wed Jul 08 23:46:20 2015 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from lists1.math.uh.edu ([129.7.128.208]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZCxAZ-0001Po-V3 for ding-account@gmane.org; Wed, 08 Jul 2015 23:46:20 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.85) (envelope-from ) id 1ZCx9p-0002Lj-2X; Wed, 08 Jul 2015 16:45:33 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by lists1.math.uh.edu with esmtps (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.85) (envelope-from ) id 1ZCx9m-0002LN-F3 for ding@lists.math.uh.edu; Wed, 08 Jul 2015 16:45:30 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtps (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.84) (envelope-from ) id 1ZCx9k-0002Wn-JN for ding@lists.math.uh.edu; Wed, 08 Jul 2015 16:45:30 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]) by quimby.gnus.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1ZCx9i-0006VP-LB for ding@gnus.org; Wed, 08 Jul 2015 23:45:26 +0200 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ZCx9h-0000n5-Fr for ding@gnus.org; Wed, 08 Jul 2015 23:45:25 +0200 Original-Received: from cpe84948c589861-cm84948c589860.cpe.net.cable.rogers.com ([99.255.115.45]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 08 Jul 2015 23:45:25 +0200 Original-Received: from jdc by cpe84948c589861-cm84948c589860.cpe.net.cable.rogers.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 08 Jul 2015 23:45:25 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: ding@gnus.org Original-Lines: 54 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: cpe84948c589861-cm84948c589860.cpe.net.cable.rogers.com User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.3 (gnu/linux) Mail-Copies-To: never Cancel-Lock: sha1:v6GEzKfX2IEW1V3QmjMMrO1bYyw= X-Spam-Score: -3.6 (---) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:86045 Archived-At: Eric Abrahamsen writes: > Ha, well that was a bust, wasn't it? Turns out there were multiple > issues here -- the patch I sent fixed group creation via moving > messages, but nnmairix calls `nnimap-request-group' with INFO set to > nil, so Bjørn's solution was still necessary. I've made some more > adjustments to the group creation process, which I hope won't mess > anything else up. Would you mind trying these two patches? I tried the two patches, without Bjørn's patches applied, and the first hunk of your second patch didn't apply cleanly. I applied it manually. But now I get a different backtrace when trying to enter the group (see below). This is probably related to this change of Bjørn's: (nnimap-finish-retrieve-group-infos server (list info) sequences t) (setq active (nth 2 (assoc group nnimap-current-infos))))) (erase-buffer) + (or active (setq active (cons 0 0))) (insert (format "211 %d %d %d %S\n" (- (cdr active) (car active)) (car active) But I tried using Bjørn's patches instead of your second patch, and still had some trouble. Maybe it's something to do with the patch not applying cleanly? Or I might be using the wrong version of nnimap.el. Are you using the latest git version? Unfortunately, I don't have time to look into it further right now. Thanks again for proposing fixes! Dan Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) -(nil nil) (format "211 %d %d %d %S\n" (- (cdr active) (car active)) (car active) (cdr active) group) (insert (format "211 %d %d %d %S\n" (- (cdr active) (car active)) (car active) (cdr active) group)) (progn (if (or (not dont-check) (not (setq active (nth 2 (assoc group nnimap-current-infos))))) (progn (let ((sequences (nnimap-retrieve-group-data-early server info))) (nnimap-finish-retrieve-group-infos server info sequences t) (setq active (nth 2 (assoc group nnimap-current-infos)))))) (erase-buffer) (insert (format "211 %d %d %d %S\n" (- (cdr active) (car active)) (car active) (cdr active) group)) t) (if result (progn (if (or (not dont-check) (not (setq active (nth 2 (assoc group nnimap-current-infos))))) (progn (let ((sequences (nnimap-retrieve-group-data-early server info))) (nnimap-finish-retrieve-group-infos server info sequences t) (setq active (nth 2 (assoc group nnimap-current-infos)))))) (erase-buffer) (insert (format "211 %d %d %d %S\n" (- (cdr active) (car active)) (car active) (cdr active) group)) t)) (save-current-buffer (set-buffer nntp-server-buffer) (if result (progn (if (or (not dont-check) (not (setq active (nth 2 ...)))) (progn (let ((sequences ...)) (nnimap-finish-retrieve-group-infos server info sequences t) (setq active (nth 2 ...))))) (erase-buffer) (insert (format "211 %d %d %d %S\n" (- (cdr active) (car active)) (car active) (cdr active) group)) t))) (let ((result (nnimap-change-group (if (and (not dont-check) (assoc group nnimap-current-infos)) nil group) server)) (info (if info (progn (list info)))) articles active marks high low) (save-current-buffer (set-buffer nntp-server-buffer) (if result (progn (if (or (not dont-check) (not (setq active ...))) (progn (let (...) (nnimap-finish-retrieve-group-infos server info sequences t) (setq active ...)))) (erase-buffer) (insert (format "211 %d %d %d %S\n" (- (cdr active) (car active)) (car active) (cdr active) group)) t)))) nnimap-request-group("zz_mairix-nnmairixsearch-1" "rocky") apply(nnimap-request-group ("zz_mairix-nnmairixsearch-1" "rocky")) nnmairix-call-backend("request-group" "zz_mairix-nnmairixsearch-1" "rocky") nnmairix-request-group-with-article-number-correction("zz_mairix-nnmairixsearch-1" "nnmairix+mairixserver:nnmairixsearch") nnmairix-request-group("nnmairixsearch" "mairixserver" t ("nnmairix+mairixserver:nnmairixsearch" 2 nil nil (nnmairix "mairixserver" (nnmairix-backend nnimap) (nnmairix-backend-server "rocky") (nnmairix-mairix-command "mairix") (nnmairix-hidden-folders t) (nnmairix-default-group "nnmairixsearch")) ((numcorr t 47827 47850) (query "lindi" "d:1w-") (display) (folder . "zz_mairix-nnmairixsearch-1") (threads)))) gnus-request-group("nnmairix+mairixserver:nnmairixsearch" t nil ("nnmairix+mairixserver:nnmairixsearch" 2 nil nil (nnmairix "mairixserver" (nnmairix-backend nnimap) (nnmairix-backend-server "rocky") (nnmairix-mairix-command "mairix") (nnmairix-hidden-folders t) (nnmairix-default-group "nnmairixsearch")) ((numcorr t 47827 47850) (query "lindi" "d:1w-") (display) (folder . "zz_mairix-nnmairixsearch-1") (threads)))) gnus-select-newsgroup("nnmairix+mairixserver:nnmairixsearch" nil nil) gnus-summary-read-group-1("nnmairix+mairixserver:nnmairixsearch" nil nil nil nil nil) gnus-summary-read-group("nnmairix+mairixserver:nnmairixsearch" nil nil nil nil nil nil) gnus-group-read-group(nil nil nil) gnus-topic-read-group(nil) call-interactively(gnus-topic-read-group nil nil)