Gnus development mailing list
 help / color / mirror / Atom feed
From: Elias Oltmanns <eo@nebensachen.de>
To: ding@gnus.org
Subject: Don't be overzealous when hiding cited text
Date: Sun, 25 Mar 2012 21:48:25 +0200	[thread overview]
Message-ID: <877gy8qx6e.fsf@denkblock.local> (raw)

Hi there,

unfortunately, Gnus can get a bit to eager for its own (or anyone's)
good when asked to hide cited text. Specifically, when there is a block
of cited text interspersed with one-line comments (no leading or
trailing blank lines), it will all be neatly folded away since Gnus
currently assumes a one-line interruption of cited text to be a blank
line.

Please find below a small patch to gnus-dissect-cited-text to fix this
issue. Also, since this bug may have rather unpleasant consequences, I'm
wondering whether this change could also be applied to the stable
branches that get pulled into point releases of emacs 22 / 23. It is not
obvious to me which branch in the gnus.git repository is propagated to
emacs 23, for example.

Regards,

Elias

---
commit cb823aae2f919b2f94b0eb13157d35acfd134a43
Author: Elias Oltmanns <eo@nebensachen.de>
Date:   Sun Mar 25 17:53:01 2012 +0200

    Don't be overzealous when hiding cited text
    
    A single line without citation prefix within a block of cited text
    should be considered part of that block *only* if it is a blank line.

diff --git a/lisp/gnus-cite.el b/lisp/gnus-cite.el
index c744344..6bcba71 100644
--- a/lisp/gnus-cite.el
+++ b/lisp/gnus-cite.el
@@ -509,6 +509,7 @@ Lines matching `gnus-cite-attribution-suffix' and perhaps
 	  (if (and (equal (cdadr m) "")
 		   (equal (cdar m) (cdaddr m))
 		   (goto-char (caadr m))
+		   (looking-at "[ \t]*$")
 		   (forward-line 1)
 		   (= (point) (caaddr m)))
 	      (setcdr m (cdddr m))




             reply	other threads:[~2012-03-25 19:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-25 19:48 Elias Oltmanns [this message]
2012-04-10 19:17 ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877gy8qx6e.fsf@denkblock.local \
    --to=eo@nebensachen.de \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).