From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/81650 Path: news.gmane.org!not-for-mail From: Elias Oltmanns Newsgroups: gmane.emacs.gnus.general Subject: Don't be overzealous when hiding cited text Date: Sun, 25 Mar 2012 21:48:25 +0200 Message-ID: <877gy8qx6e.fsf@denkblock.local> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1332705119 18935 80.91.229.3 (25 Mar 2012 19:51:59 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 25 Mar 2012 19:51:59 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M29930@lists.math.uh.edu Sun Mar 25 21:51:57 2012 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SBtTn-00045G-M8 for ding-account@gmane.org; Sun, 25 Mar 2012 21:51:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1SBtSm-0000ak-HB; Sun, 25 Mar 2012 14:50:52 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1SBtRN-0000Zz-Oh for ding@lists.math.uh.edu; Sun, 25 Mar 2012 14:49:25 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1SBtRL-0006Jf-T2 for ding@lists.math.uh.edu; Sun, 25 Mar 2012 14:49:25 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1SBtRJ-0005bM-SS for ding@gnus.org; Sun, 25 Mar 2012 21:49:21 +0200 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SBtRH-0002uh-J3 for ding@gnus.org; Sun, 25 Mar 2012 21:49:19 +0200 Original-Received: from xdsl-89-0-168-34.netcologne.de ([89.0.168.34]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 25 Mar 2012 21:49:19 +0200 Original-Received: from eo by xdsl-89-0-168-34.netcologne.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 25 Mar 2012 21:49:19 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 42 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: xdsl-89-0-168-34.netcologne.de User-Agent: Gnus/5.13 (Gnus v5.13) Cancel-Lock: sha1:VsP/XwIl1DZVxaUok1QchXgqNZg= X-Spam-Score: -1.9 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:81650 Archived-At: Hi there, unfortunately, Gnus can get a bit to eager for its own (or anyone's) good when asked to hide cited text. Specifically, when there is a block of cited text interspersed with one-line comments (no leading or trailing blank lines), it will all be neatly folded away since Gnus currently assumes a one-line interruption of cited text to be a blank line. Please find below a small patch to gnus-dissect-cited-text to fix this issue. Also, since this bug may have rather unpleasant consequences, I'm wondering whether this change could also be applied to the stable branches that get pulled into point releases of emacs 22 / 23. It is not obvious to me which branch in the gnus.git repository is propagated to emacs 23, for example. Regards, Elias --- commit cb823aae2f919b2f94b0eb13157d35acfd134a43 Author: Elias Oltmanns Date: Sun Mar 25 17:53:01 2012 +0200 Don't be overzealous when hiding cited text A single line without citation prefix within a block of cited text should be considered part of that block *only* if it is a blank line. diff --git a/lisp/gnus-cite.el b/lisp/gnus-cite.el index c744344..6bcba71 100644 --- a/lisp/gnus-cite.el +++ b/lisp/gnus-cite.el @@ -509,6 +509,7 @@ Lines matching `gnus-cite-attribution-suffix' and perhaps (if (and (equal (cdadr m) "") (equal (cdar m) (cdaddr m)) (goto-char (caadr m)) + (looking-at "[ \t]*$") (forward-line 1) (= (point) (caaddr m))) (setcdr m (cdddr m))