commit email subject lines

commit email subject lines

[Adam Sjøgren]

Somewhere before Tue, 22 Feb 2011 00:23:38 +0100 the subject lines of
the commit emails in gmane.emacs.gnus.cvs stopped including the first
line of the commit-log in the Subject.

I really liked those, they gave me a good overview when entering the
group - was it an intentional change, and if so, why?


  Just curious,

    Adam

-- 
  Woodhead's Law: "The further you are from your              Adam Sjøgren
  server, the more likely it is to crash."               asjo@koldfront.dk

Re: commit email subject lines

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

On Wed, Feb 23 2011, Adam Sjøgren wrote:

> Somewhere before Tue, 22 Feb 2011 00:23:38 +0100 the subject lines of
> the commit emails in gmane.emacs.gnus.cvs stopped including the first
> line of the commit-log in the Subject.
>
> I really liked those, they gave me a good overview when entering the
> group - was it an intentional change, and if so, why?

I don't know, but I would also like to ask if it's possible to have one
email per commit rather than by push. I find this more easy to
read/review.

-- 
Julien Danjou
❱ http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: commit email subject lines

[Ted Zlatanov]

On Wed, 23 Feb 2011 14:18:36 +0100 Julien Danjou <julien@danjou.info> wrote: 

JD> On Wed, Feb 23 2011, Adam Sjøgren wrote:
>> Somewhere before Tue, 22 Feb 2011 00:23:38 +0100 the subject lines of
>> the commit emails in gmane.emacs.gnus.cvs stopped including the first
>> line of the commit-log in the Subject.
>> 
>> I really liked those, they gave me a good overview when entering the
>> group - was it an intentional change, and if so, why?

JD> I don't know, but I would also like to ask if it's possible to have one
JD> email per commit rather than by push. I find this more easy to
JD> read/review.

It started with the tags.  Lars, did you change post-receive?  If not
I'll look at what's up.  btw it's in etc/post-receive if anyone wants to
check it.

Ted

Re: commit email subject lines

[Lars Ingebrigtsen]

Ted Zlatanov <tzz@lifelogs.com> writes:

> It started with the tags.  Lars, did you change post-receive? 

Nope.  Haven't changed anything.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: commit email subject lines

[David Engster]

Lars Ingebrigtsen writes:
> Ted Zlatanov <tzz@lifelogs.com> writes:
>
>> It started with the tags.  Lars, did you change post-receive? 
>
> Nope.  Haven't changed anything.

This happens because post-receive uses the output from git-describe by
default:

describe=$(git describe $rev 2>/dev/null)
if [ -z "$describe" ]; then
	describe=$( (git log --format="%s" $oldrev...$newrev | perl -e'@p = <>; chomp @p; print "=", scalar @p, "= ", join(" ; ", @p)') 2>/dev/null)
fi


I guess just using the git-log output should make things work again. I
don't understand the need for git-describe here anyway.

-David

Re: commit email subject lines

[Ted Zlatanov]

On Thu, 24 Feb 2011 09:46:14 +0100 David Engster <deng@randomsample.de> wrote: 

DE> Lars Ingebrigtsen writes:
>> Ted Zlatanov <tzz@lifelogs.com> writes:
>> 
>>> It started with the tags.  Lars, did you change post-receive? 
>> 
>> Nope.  Haven't changed anything.

DE> This happens because post-receive uses the output from git-describe by
DE> default:

DE> describe=$(git describe $rev 2>/dev/null)
DE> if [ -z "$describe" ]; then
DE> 	describe=$( (git log --format="%s" $oldrev...$newrev | perl -e'@p = <>; chomp @p; print "=", scalar @p, "= ", join(" ; ", @p)') 2>/dev/null)
DE> fi

DE> I guess just using the git-log output should make things work again. I
DE> don't understand the need for git-describe here anyway.

Me neither.  But it seems like it could be useful (according to the `git
describe' docs it tells you how to reach the nearest tag).  Maybe it
should be in the subject anyhow?

Ted

Re: commit email subject lines

[David Engster]

Ted Zlatanov writes:
> On Thu, 24 Feb 2011 09:46:14 +0100 David Engster <deng@randomsample.de> wrote: 
>
> DE> Lars Ingebrigtsen writes:
>>> Ted Zlatanov <tzz@lifelogs.com> writes:
>>> 
>>>> It started with the tags.  Lars, did you change post-receive? 
>>> 
>>> Nope.  Haven't changed anything.
>
> DE> This happens because post-receive uses the output from git-describe by
> DE> default:
>
> DE> describe=$(git describe $rev 2>/dev/null)
> DE> if [ -z "$describe" ]; then
> DE> 	describe=$( (git log --format="%s" $oldrev...$newrev | perl -e'@p = <>; chomp @p; print "=", scalar @p, "= ", join(" ; ", @p)') 2>/dev/null)
> DE> fi
>
> DE> I guess just using the git-log output should make things work again. I
> DE> don't understand the need for git-describe here anyway.
>
> Me neither.  But it seems like it could be useful (according to the `git
> describe' docs it tells you how to reach the nearest tag).  Maybe it
> should be in the subject anyhow?

Then append it, though I don't think that "n0-13-35-g4c0611b" is a
particular useful piece of information for a commit message ("this is
based on n0-13 but with 35 commits on top with the current being
4c0611b").

-David

Re: commit email subject lines

[Ted Zlatanov]

On Thu, 24 Feb 2011 18:10:36 +0100 David Engster <deng@randomsample.de> wrote: 

DE> Ted Zlatanov writes:
>> On Thu, 24 Feb 2011 09:46:14 +0100 David Engster <deng@randomsample.de> wrote: 
>> 
DE> Lars Ingebrigtsen writes:
>>>> Ted Zlatanov <tzz@lifelogs.com> writes:
>>>> 
>>>>> It started with the tags.  Lars, did you change post-receive? 
>>>> 
>>>> Nope.  Haven't changed anything.
>> 
DE> This happens because post-receive uses the output from git-describe by
DE> default:
>> 
DE> describe=$(git describe $rev 2>/dev/null)
DE> if [ -z "$describe" ]; then
DE> describe=$( (git log --format="%s" $oldrev...$newrev | perl -e'@p = <>; chomp @p; print "=", scalar @p, "= ", join(" ; ", @p)') 2>/dev/null)
DE> fi
>> 
DE> I guess just using the git-log output should make things work again. I
DE> don't understand the need for git-describe here anyway.
>> 
>> Me neither.  But it seems like it could be useful (according to the `git
>> describe' docs it tells you how to reach the nearest tag).  Maybe it
>> should be in the subject anyhow?

DE> Then append it, though I don't think that "n0-13-35-g4c0611b" is a
DE> particular useful piece of information for a commit message ("this is
DE> based on n0-13 but with 35 commits on top with the current being
DE> 4c0611b").

Eh, I don't feel strongly about it.  So I guess we can just comment that
line out, huh?  All right...  I'll try to do it tonight.

Ted

Re: commit email subject lines

[Ted Zlatanov]

On Thu, 24 Feb 2011 11:48:13 -0600 Ted Zlatanov <tzz@lifelogs.com> wrote: 

TZ> On Thu, 24 Feb 2011 18:10:36 +0100 David Engster <deng@randomsample.de> wrote: 
DE> Then append it, though I don't think that "n0-13-35-g4c0611b" is a
DE> particular useful piece of information for a commit message ("this is
DE> based on n0-13 but with 35 commits on top with the current being
DE> 4c0611b").

TZ> Eh, I don't feel strongly about it.  So I guess we can just comment that
TZ> line out, huh?  All right...  I'll try to do it tonight.

After testing, I liked it better with "git describe" so I always add
that now if it's not empty.

Ted

Re: commit email subject lines

[James Cloos]

If git describe's output is first in the subject, then the commit
messages will sort in order when sorted by subject.

That does have value.

But the first line of the commit log should also be there.

That has even more value.

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 1024D/ED7DAEA6

Re: commit email subject lines

[Lars Ingebrigtsen]

Julien Danjou <julien@danjou.info> writes:

> I don't know, but I would also like to ask if it's possible to have one
> email per commit rather than by push. I find this more easy to
> read/review.

`C-d' on the per-push email will give you one message per commit.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: commit email subject lines

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

On Thu, Feb 24 2011, Lars Ingebrigtsen wrote:

> `C-d' on the per-push email will give you one message per commit.

I know, but I do not want to press C-d on each email.

-- 
Julien Danjou
❱ http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: commit email subject lines

[Lars Ingebrigtsen]

Julien Danjou <julien@danjou.info> writes:

> I know, but I do not want to press C-d on each email.

Right.  I kinda like the multi-patch format -- it feels so noisy when
every checkin I do generates a message.  :-)  But I have no strong
feelings on the matter.  One message per commit would be easier to
follow, I guess.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen