Re: tzz-auth-source-rewrite branch

[Lars Ingebrigtsen <larsi@gnus.org>]

Ted Zlatanov <tzz@lifelogs.com> writes:

> In auth-source-search:
> auth-source.el:507:33:Warning: `error' called with 2 args to fill 0 format
>     field(s)
>
> In auth-source-netrc-search:
> auth-source.el:712:32:Warning: `error' called with 2 args to fill 0 format
>     field(s)
>
> but am not sure why.

The cl macros are virtually unreadable since they use such weird
old-stylee forms, but I think this is the gist of the assert macro:

(list 'progn
      (list 'or form
            (if string
                (list* 'error string (append sargs args)))))

Rewritten to modern macrology, that would be something like:
                
`(progn
   (or ,form
        (if ,string
            (error string ,sargs ,args))))

And we see that, indeed, `error' is called with two parameters.  I've
now just stuck to %s forms into the strings, and that seems to make the
warning go away, as you'd expect.

Aidan Kehoe has been rewriting cl*.el in XEmacs, and I think somebody
should import all that stuff into Emacs, so you'd actually be able to
read the code.
            
-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen