Gnus development mailing list
 help / color / mirror / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: ding@gnus.org
Cc: Kazuhiro Ito <kzhr@d1.dion.ne.jp>, 7596@debbugs.gnu.org
Subject: Re: bug#7596: 23.2.90; fill-flowed with DELETE-SPACE option does not work
Date: Sat, 22 Jan 2011 14:31:52 -0500	[thread overview]
Message-ID: <877hdwzqdz.fsf@stupidchicken.com> (raw)
In-Reply-To: <82bp4vn7wv.wl%kzhr@d1.dion.ne.jp> (Kazuhiro Ito's message of "Thu, 09 Dec 2010 08:48:00 +0900")

Kazuhiro Ito <kzhr@d1.dion.ne.jp> writes:

> (with-temp-buffer
>   (insert "ABC \nDEF")
>   (fill-flowed nil t)
>   (buffer-string))
> It returns
> "ABC
> DEF"
> But I expect
> "ABCDEF"
> I expect DELETE-SPACE option corresponds to "DelSp" parameter in
> RFC3676 and works so.  Plesse see attached patch.

Could a Gnus developer please review Kazuhiro Ito's patch?  Thanks.

--- lisp/gnus/flow-fill.el	2010-01-13 08:35:10 +0000
+++ lisp/gnus/flow-fill.el	2010-12-08 10:14:13 +0000
@@ -106,8 +106,6 @@
       (forward-line 1))
     (goto-char (point-min))
     (while (re-search-forward " $" nil t)
-      (when delete-space
-	(delete-char -1))
       (when (save-excursion
 	      (beginning-of-line)
 	      (looking-at "^\\(>*\\)\\( ?\\)"))
@@ -135,6 +133,8 @@
 	      (replace-match (if (string= (match-string 2) " ")
 				 "" "\\2")))
 	    (backward-delete-char -1)
+	    (when delete-space
+	      (delete-char -1))
 	    (end-of-line))
 	  (unless sig
 	    (condition-case nil




       reply	other threads:[~2011-01-22 19:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <82bp4vn7wv.wl%kzhr@d1.dion.ne.jp>
2011-01-22 19:31 ` Chong Yidong [this message]
2011-01-22 19:48   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877hdwzqdz.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=7596@debbugs.gnu.org \
    --cc=ding@gnus.org \
    --cc=kzhr@d1.dion.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).