Re: Accepting x-pkcs7-signature

[David Engster <deng@randomsample.de>]

Daiki Ueno writes:
> David Engster <deng@randomsample.de> writes:
>
>>>>  					   ctl 'protocol)
>>>>  					  "application/pkcs7-signature")
>>>
>>> ^^ this line should also be changed to accept "x-pkcs7-signature"?
>>
>> The full sexp is this:
>>
>>  (setq part (mm-find-raw-part-by-type
>> 				  ctl (or (mm-handle-multipart-ctl-parameter
>> 					   ctl 'protocol)
>> 					  "application/pkcs7-signature")
>> 				  t)))
>>
>> So I thought this would just be used as a fallback?
>
> Well, I looked at the following code and thought that PART was
> signed material:
>
> (setq plain (epg-verify-string context (mm-get-part signature) part)

To be honest, I really have problems understanding what all that
'mm'-code does. It seems to me the HANDLE structure already has all the
information that's needed, including pointers to the buffers containing
the text and the detached signature, but somehow it extracts them
again. I also don't understand the above fallback for
"application/pkcs7-signature", since multipart/signed must have a
'protocol' parameter in the Content-Type anyway, otherwise it's just
broken.

Regards,
David