Gnus development mailing list
 help / color / mirror / Atom feed
From: Reiner Steib <reinersteib+gmane@imap.cc>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Simon Josefsson <simon@josefsson.org>,
	Frank Schmitt <ich@frank-schmitt.net>,
	James Cloos <cloos@jhcloos.com>,
	ding@gnus.org, 1174@emacsbugs.donarmstrong.com,
	Clemens Schueller <cs.usenet.nospam@aon.at>
Subject: Re: bug#1174: 23.0.60; Some UTF-8 mails displaying wrongly in Emacs 23
Date: Sun, 30 Nov 2008 14:12:02 +0100	[thread overview]
Message-ID: <877i6lfjdp.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <jwvfxlaz0ov.fsf-monnier+emacsbugreports@gnu.org> (Stefan Monnier's message of "Sat, 29 Nov 2008 16:30:49 -0500")

On Sat, Nov 29 2008, Stefan Monnier wrote:

>> Stefan, what are the "accidental emacs-mule-valid byte sequences"
>> that trigger this problem?  It would be good if someone could send
>> me a problematic article. [2]
>
> In Emacs-22, the problem was more difficult to trigger: you had to
> receive an email whose undecoded text contained emacs-mule escape
> sequences, which is rather uncommon.  With Emacs-23, it's a lot more
> common since the internal encoding has changed to a variant of utf-8:
> an 8bit body using utf-8 will see its content unwillingly decoded during
> nnimap-demule which leads to the bugs we've seen recently.

Could you send me an article demonstrating the problem?

> I'm pretty sure that string-as-multibyte is wrong here in general.
> Maybe the problem is that nnimap-demule is used blindly in different
> contexts where some need string-to-multibyte and some need
> string-as-multibyte.  E.g. maybe Simon's problem was linked to imap
> groups with non-ASCII chars in their names, rather than in the
> message bodies.

I'm not familiar with the IMAP code, but AFAICS, `nnimap-demule' is
only used when getting headers or body:

| nnimap.el:611:	      headers (nnimap-demule

(defun nnimap-retrieve-headers-progress ()
  "Hook to insert NOV line for current article into `nntp-server-buffer'."

| nnimap.el:951:	 (nnimap-demule

(defun nnimap-callback (article gnus-callback buffer)
  (when (eq article (imap-current-message))
    (remove-hook 'imap-fetch-data-hook
		 (nnimap-make-callback article gnus-callback buffer))
    (with-current-buffer buffer
      (insert
       (with-current-buffer nnimap-server-buffer
	 (nnimap-demule
	  (if (imap-capability 'IMAP4rev1)
	      ;; xxx don't just use car? alist doesn't contain
	      ;; anything else now, but it might...
	      (nth 2 (car (imap-message-get article 'BODYDETAIL)))
	    (imap-message-get article 'RFC822)))))
      (nnheader-ms-strip-cr)
      (funcall gnus-callback t))))

| nnimap.el:977:		(insert (nnimap-demule (if detail

(defun nnimap-request-article-part (article part prop &optional
					    group server to-buffer detail)

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/



  reply	other threads:[~2008-11-30 13:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m37i89boe6.fsf@mid.gehheimdienst.de>
     [not found] ` <jeabd5vvug.fsf@sykes.suse.de>
     [not found]   ` <m363ntey23.fsf@mid.gehheimdienst.de>
     [not found]     ` <u63nso2wk.fsf@gnu.org>
     [not found]       ` <jebpxjvd53.fsf@sykes.suse.de>
     [not found]         ` <m3ej2fd2o0.fsf@mid.gehheimdienst.de>
     [not found]           ` <umyh3mttj.fsf@gnu.org>
     [not found]             ` <m33aivfsa8.fsf@mid.gehheimdienst.de>
     [not found]               ` <jwv8wsnjknd.fsf-monnier+emacsbugreports@gnu.org>
2008-10-17 18:19                 ` Reiner Steib
2008-10-17 18:36                   ` Frank Schmitt
2008-11-29 12:08                     ` Reiner Steib
2008-11-29 12:18                       ` Simon Josefsson
2008-11-29 15:30                         ` Reiner Steib
2008-11-29 21:30                           ` Stefan Monnier
2008-11-30 13:12                             ` Reiner Steib [this message]
2008-11-29 22:14                           ` James Cloos
2008-11-30 13:11                             ` View articles with different charset (was: bug#1174: 23.0.60; Some UTF-8 mails displaying wrongly in Emacs 23) Reiner Steib
2008-11-30 21:23                               ` View articles with different charset James Cloos
2009-01-12 10:54                         ` bug#1174: 23.0.60; Some UTF-8 mails displaying wrongly in Emacs 23 Simon Josefsson
2009-01-12 11:03                           ` Frank Schmitt
2009-01-12 11:10                             ` Simon Josefsson
2009-01-14 11:20                               ` Gabor Z. Papp
2009-01-14 20:12                                 ` Reiner Steib
2009-01-14 22:08                                   ` Stefan Monnier
2008-12-01 21:04                       ` Stefan Monnier
2008-12-01 22:48                         ` Reiner Steib
2008-12-02  7:36                           ` Stefan Monnier
2008-12-04 19:43                             ` Reiner Steib
2008-12-04 21:43                               ` Frank Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877i6lfjdp.fsf@marauder.physik.uni-ulm.de \
    --to=reinersteib+gmane@imap.cc \
    --cc=1174@emacsbugs.donarmstrong.com \
    --cc=Reiner.Steib@gmx.de \
    --cc=cloos@jhcloos.com \
    --cc=cs.usenet.nospam@aon.at \
    --cc=ding@gnus.org \
    --cc=ich@frank-schmitt.net \
    --cc=monnier@iro.umontreal.ca \
    --cc=simon@josefsson.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).