Gnus development mailing list
 help / color / mirror / Atom feed
From: TSUCHIYA Masatoshi <tsuchiya@pine.kuee.kyoto-u.ac.jp>
Subject: Re: split banners of free mail servers
Date: Tue, 24 Sep 2002 18:40:04 +0900	[thread overview]
Message-ID: <877khbzpxn.fsf@pine.kuee.kyoto-u.ac.jp> (raw)
In-Reply-To: <almk4k$vka$1@quimby.gnus.org>

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

Hello, Gnus developers.

>> On Wed, 11 Sep 2002 13:47:45 +0900
>> tsuchiya@namazu.org said as follows:

>Some mail servers, which provide free mail accounts, insert their
>advertisements into their relaying messages.  In order to split them,
>I propose the following change.

I have noticed that this change causes a wrong-type-argument error
when a message including no from header is displayed.  In order to
avoid this error, I propose the following change.

2002-09-24  TSUCHIYA Masatoshi  <tsuchiya@namazu.org>

        * gnus-art.el (article-strip-banner): Check the existence of
        from header.


[-- Attachment #2: Type: text/plain, Size: 604 bytes --]

--- gnus-art.el	2002/09/23 20:38:23	6.239
+++ gnus-art.el	2002/09/24 10:22:47
@@ -2281,10 +2281,11 @@
 			      (article-narrow-to-head)
 			      (caar (mail-header-parse-addresses
 				     (mail-fetch-field "from"))))))
-		  (catch 'found
-		    (dolist (pair gnus-article-address-banner-alist)
-		      (when (string-match (car pair) from)
-			(throw 'found (cdr pair))))))))
+		  (when from
+		    (catch 'found
+		      (dolist (pair gnus-article-address-banner-alist)
+			(when (string-match (car pair) from)
+			  (throw 'found (cdr pair)))))))))
 	(when banner
 	  (article-goto-body)
 	  (cond

[-- Attachment #3: Type: text/plain, Size: 23 bytes --]

-- 
TSUCHIYA Masatoshi

  parent reply	other threads:[~2002-09-24  9:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-11  4:47 tsuchiya
2002-09-11  5:18 ` Katsumi Yamaoka
2002-09-11  5:30   ` tsuchiya
2002-09-11  5:48     ` Katsumi Yamaoka
2002-09-24  9:40 ` TSUCHIYA Masatoshi [this message]
2002-09-24  9:59   ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877khbzpxn.fsf@pine.kuee.kyoto-u.ac.jp \
    --to=tsuchiya@pine.kuee.kyoto-u.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).