Gnus development mailing list
 help / color / mirror / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: "Peter Münster" <pm@a16n.net>
Cc: ding@gnus.org
Subject: Re: problem with non-ascii group-names
Date: Mon, 20 Sep 2021 11:53:47 -0700	[thread overview]
Message-ID: <878rzrrsck.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87czp3ru5n.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 20 Sep 2021 11:14:44 -0700")

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Peter Münster <pm@a16n.net> writes:
>>
>>> And here a related problem:
>>>
>>> When using "S D r" (gnus-summary-resend-message), a local copy of the
>>> message is written to the group.
>>
>> I'm guessing that there's something particular to archive group writing,
>> since this doesn't happen with regular nnml groups with non-ascii names.
>> Are you using "Céline" as your archive group, or your Gcc header for
>> this particular set of messages? And you're in this group when you hit
>> "S D r" as above, right?
>
> Okay, I was able to reproduce this problem when archiving messages to a
> group with a non-ascii name. Give me a few days and I ought have this
> fixed.

That was much easier than I thought, I'd simply missed a group-name
encoding call when I was yanking all this stuff out a year or so ago.

If you'd like, please test the attached diff to make sure it works,
though I'm fairly sure this is it.

Eric


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dont-encode-gcc-group-name.diff --]
[-- Type: text/x-patch, Size: 649 bytes --]

diff --git a/lisp/gnus/gnus-msg.el b/lisp/gnus/gnus-msg.el
index 66501ef7d5..0e1ba70d1e 100644
--- a/lisp/gnus/gnus-msg.el
+++ b/lisp/gnus/gnus-msg.el
@@ -1584,10 +1584,7 @@ gnus-inews-do-gcc
 			(message-tokenize-header gcc " ,\n\t")))
 	  ;; Copy the article over to some group(s).
 	  (while (setq group (pop groups))
-	    (setq method (gnus-inews-group-method group)
-		  group (encode-coding-string
-			 group
-			 (gnus-group-name-charset method group)))
+	    (setq method (gnus-inews-group-method group))
 	    (unless (gnus-check-server method)
 	      (error "Can't open server %s" (if (stringp method) method
 					      (car method))))

  reply	other threads:[~2021-09-20 18:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 10:29 Peter Münster
2021-06-03 16:00 ` Eric Abrahamsen
2021-06-03 17:21   ` Peter Münster
2021-06-03 18:31     ` Eric Abrahamsen
2021-06-03 18:56       ` Peter Münster
2021-06-03 19:55         ` Eric Abrahamsen
2021-06-03 20:36           ` Peter Münster
2021-06-03 21:02             ` Eric Abrahamsen
2021-09-14 20:12       ` Peter Münster
2021-09-14 20:20         ` Peter Münster
2021-09-20 18:09           ` Eric Abrahamsen
2021-09-20 18:14             ` Eric Abrahamsen
2021-09-20 18:53               ` Eric Abrahamsen [this message]
2021-09-20 21:13                 ` Peter Münster
2021-09-20 22:34                   ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rzrrsck.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=ding@gnus.org \
    --cc=pm@a16n.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).