From: Andrew Cohen <acohen@ust.hk>
To: ding@gnus.org
Subject: Re: Posting a draft to a newsgroup stopped(?) working?
Date: Sat, 02 Jan 2021 11:52:36 +0800 [thread overview]
Message-ID: <878s9c9erf.fsf@ust.hk> (raw)
In-Reply-To: <877dowm27t.fsf@tullinup.koldfront.dk>
>>>>> "AS" == Adam Sjøgren <asjo@koldfront.dk> writes:
AS> Adam writes:
>>> So I guess group used to be filled in regardless, but now it
>>> isn't?!
>> + (,group (when gnus-article-reply + (or (nnselect-article-group
>> + (or (car-safe gnus-article-reply) + gnus-article-reply)) +
>> gnus-newsgroup-name)))
AS> If I change it to this:
AS> (,group (if gnus-article-reply (or
AS> (nnselect-article-group (or (car-safe gnus-article-reply)
AS> gnus-article-reply)) gnus-newsgroup-name) gnus-newsgroup-name))
I made this change probably 4 years ago, so I don't remember the
details. The trick is to make sure that the right group is used when
coming from an nnselect group, but I recall there were several
subtleties involved and some corner cases that the previous code got
wrong. I think that the logic of your correction is right (should have
been an if rather than a when), but the easiest way to tell is to make
the change and see if anything else stops working.
--
next prev parent reply other threads:[~2021-01-02 3:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-01 19:42 Adam Sjøgren
2021-01-01 20:38 ` Eric Abrahamsen
2021-01-01 20:48 ` Mock Turtle
2021-01-01 20:53 ` Eric Abrahamsen
2021-01-01 21:02 ` Adam Sjøgren
2021-01-01 21:17 ` Mock Turtle
2021-01-01 21:23 ` Eric Abrahamsen
2021-01-01 21:44 ` Adam Sjøgren
2021-01-02 0:18 ` Adam Sjøgren
2021-01-02 0:58 ` Eric Abrahamsen
2021-01-02 1:02 ` Adam Sjøgren
2021-01-02 2:03 ` Adam Sjøgren
2021-01-02 2:14 ` Andrew Cohen
2021-01-02 2:25 ` Adam Sjøgren
2021-01-02 2:37 ` Adam Sjøgren
2021-01-02 3:33 ` Adam Sjøgren
2021-01-02 3:40 ` Adam Sjøgren
2021-01-02 3:45 ` Adam Sjøgren
2021-01-02 3:52 ` Andrew Cohen [this message]
2021-01-02 4:01 ` Adam Sjøgren
2021-01-02 4:02 ` Andrew Cohen
2021-01-02 4:10 ` Adam Sjøgren
2021-01-02 4:32 ` Andrew Cohen
2021-01-02 4:42 ` Adam Sjøgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s9c9erf.fsf@ust.hk \
--to=acohen@ust.hk \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).