From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/88159 Path: news.gmane.org!.POSTED!not-for-mail From: "Garreau\, Alexandre" Newsgroups: gmane.emacs.gnus.general Subject: Re: inline Date: Mon, 08 Oct 2018 19:22:15 +0200 Message-ID: <878t382w1k.fsf@portable.galex-713.eu> References: <86lg78plq7.fsf@zoho.com> <8736tg2wsl.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1539019231 3867 195.159.176.226 (8 Oct 2018 17:20:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 8 Oct 2018 17:20:31 +0000 (UTC) User-Agent: Gnus (5.13), GNU Emacs 25.1.1 (i686-pc-linux-gnu) Cc: ding@gnus.org To: Eric Abrahamsen Original-X-From: ding-owner+M36373@lists.math.uh.edu Mon Oct 08 19:20:27 2018 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from lists1.math.uh.edu ([129.7.128.208]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9ZCl-0000uE-7I for ding-account@gmane.org; Mon, 08 Oct 2018 19:20:27 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.90_1) (envelope-from ) id 1g9ZEk-0007ET-Jk; Mon, 08 Oct 2018 12:22:30 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by lists1.math.uh.edu with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1g9ZEb-0007Bk-OZ for ding@lists.math.uh.edu; Mon, 08 Oct 2018 12:22:21 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) (envelope-from ) id 1g9ZEZ-0000I6-Pv for ding@lists.math.uh.edu; Mon, 08 Oct 2018 12:22:21 -0500 Original-Received: from portable.galex-713.eu ([89.234.186.82]) by quimby.gnus.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9ZEY-0004TW-II for ding@gnus.org; Mon, 08 Oct 2018 19:22:18 +0200 Original-Received: from localhost ([::1] helo=portable.galex-713.eu) by portable.galex-713.eu with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1g9ZEV-0006KZ-Io; Mon, 08 Oct 2018 19:22:15 +0200 X-GPG-FINGERPRINT: E109 9988 4197 D7CB B0BC 5C23 8DEB 24BA 867D 3F7F X-Accept-Language: fr, en, it, eo In-Reply-To: <8736tg2wsl.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 08 Oct 2018 10:06:02 -0700") X-Spam-Score: -1.9 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:88159 Archived-At: Le 08/10/2018 =C3=A0 10h06, Eric Abrahamsen a =C3=A9crit=C2=A0: > Emanuel Berg writes: >> On gnu.emacs.help, there has been a long >> discussion on inlining functions. >> >> Just now, I wrote >> >> If you have studied the Gnus source code, you find that the >> defuns are insanely long. They go on all but forever. This is >> because Gnus is already slow, and perhaps Elisp is as well, so >> they don't want to brake it up into modules (smaller defuns) >> because then it would require the funcall overhead. Perhaps Gnus >> would benefit from inlining stuff? >> >> But be sure to check out the entire thread. There has been lots of >> changes to the subject line so there are several threads all dealing >> with the inline stuff. > > FWIW, I think Gnus would gain the most not by inlining more code, but > by adjusting its data structures, and introducing more caching at > higher levels. So much of the code is simply boilerplate for finding > things, or gathering data together, and doing it repeatedly. I think > that's where most of the win would be. So, in the aforementioned discussion, in the end I was right: I/O plays a bigger role there than function call overhead, right? So maybe =E2=80=9Cbreaking the defuns into [parts]=E2=80=9D, if done correc= tly, wouldn=E2=80=99t =E2=80=9Cmake it even slower=E2=80=9D? PS: I subscribed just in time to see a first answer to that thread! \o/