Gnus development mailing list
 help / color / mirror / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: ding@gnus.org
Subject: Re: registry and the gnus-summary-line-format
Date: Tue, 21 Feb 2017 08:28:13 -0800	[thread overview]
Message-ID: <878toztso2.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87y3wzhhwi.fsf@mat.ucm.es>

Uwe Brauer <oub@mat.ucm.es> writes:

>    > Uwe Brauer <oub@mat.ucm.es> writes:
>
>    > I'm not entirely sure what you're asking, but you have two options here:
>    > set a global gnus-summary-line-format variable, that applies to all
>    > groups, and also set a per-group (ie "group local") summary line that
>    > only applies to that one group, and overrides the global value.
>
>    > In the customization "screenshots" above, the top entry is specific to
>    > one group. The second is the value that applies to all groups.
>
>    > If that doesn't clear things up, you might need to rephrase your
>    > question!
>
> Ok, I was mistaken. I want  gnus-summary-line-format to be different for
> my mail and the newsgroup.

[...]

> However the registry does not work that is I set
> Variables:
>             Set variables local to the group you are entering. More
> INS DEL Variable: gnus-summary-line-format
>             Value: 
> "[%uM]%U%R%z%I%N %(%[ %-10,10uB%]%) %-10,10~(form (rfc2047-decode-string (gnus-extra-header 'To)))@  [%-25,25s%] %D %k %L   \n"
> INS
>
> Note the []
>
> then the messages after restart are displayed such as
> []O  36485 [  Uwe Braue] Uwe Brauer  [courier                  ] Mon, 20 Feb 2017 23:04:28 +0000 9k 21   
>
>
> But when I want to add a registry label I obtain that error:
>
> Debugger entered--Lisp error: (wrong-type-argument sequencep 116)
>   mapconcat(#[(mark) "\302\303\b	\"\243\304\"\207" [mark gnus-registry-marks plist-get assoc :char] 4] (To-Do) "")

The error is in:

#+BEGIN_SRC elisp
(defun gnus-registry-article-marks-to-chars (headers)
  "Show the marks for an article by the :char property."
  (let* ((id (mail-header-message-id headers))
         (marks (when id (gnus-registry-get-id-key id 'mark))))
    (mapconcat (lambda (mark)
                 (plist-get
                  (cdr-safe
                   (assoc mark gnus-registry-marks))
                  :char))
               marks "")))
#+END_SRC

It's trying to mapconcat a bare character (116 or ?t), but mapconcat
requires a string or a list of characters.

I don't see how this ever would have worked, to be honest. Git blame
says the code's been like this since 2011, but supposedly mapconcat
started barfing on integer arguments in Emacs 21.1, in 2001. Anyhow,
wrapping the `plist-get' in a `char-to-string' (or just `list') will fix
it.

I can open a bug report in a bit, if no one leaps in and fixes it.

Eric




  reply	other threads:[~2017-02-21 16:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-19 21:45 Uwe Brauer
2017-02-20  1:06 ` Eric Abrahamsen
2017-02-21 12:01   ` Uwe Brauer
2017-02-21 16:28     ` Eric Abrahamsen [this message]
2017-02-21 18:18       ` Uwe Brauer
2017-02-21 18:23       ` Uwe Brauer
2017-02-21 18:32         ` Eric Abrahamsen
2017-02-21 20:08           ` Uwe Brauer
2017-02-22  0:34             ` Eric Abrahamsen
2017-02-22  9:25               ` Uwe Brauer
2017-02-22 16:59                 ` Eric Abrahamsen
2017-02-22 17:38                   ` Uwe Brauer
2017-02-21 21:49           ` Uwe Brauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878toztso2.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).