Gnus development mailing list
 help / color / mirror / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: ding@gnus.org
Cc: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Subject: commit 1d2c4fbb9bdc1078d1727b27139e4df5ba7cb2cb
Date: Mon, 06 May 2013 09:40:57 +0200	[thread overview]
Message-ID: <878v3so8s6.fsf@thinkpad.tsdh.de> (raw)

Hi Thierry,

it seems your latest commit broke burying the message buffer after
sending a message for me.  I use

  (setq message-kill-buffer-on-exit t)

and now I get this error after sending messages:

--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  message-bury()
  message-send-and-exit(nil)
  call-interactively(message-send-and-exit nil nil)
  command-execute(message-send-and-exit)
--8<---------------cut here---------------end--------------->8---

The problem is that `with-current-buffer' doesn't work if the given
buffer is nil?

This simplified definition of `message-bury' works for me:

--8<---------------cut here---------------start------------->8---
(defun message-bury (&optional buffer)
  "Bury this mail BUFFER."
  (when message-return-action
    (apply (car message-return-action) (cdr message-return-action)))
  (bury-buffer buffer))
--8<---------------cut here---------------end--------------->8---

However, I don't use `message-return-action', so I can't tell if
reversing the order (first `message-return-action', then bury the
buffer, instead of the other way round) has any negative effects.

Bye,
Tassilo



             reply	other threads:[~2013-05-06  7:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06  7:40 Tassilo Horn [this message]
2013-05-06  9:56 ` Andreas Schwab
2013-05-06 12:57   ` Tassilo Horn
2013-05-06 13:52     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878v3so8s6.fsf@thinkpad.tsdh.de \
    --to=tsdh@gnu.org \
    --cc=ding@gnus.org \
    --cc=thierry.volpiatto@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).