emacs23 broken on master (gnus-compat problems)

emacs23 broken on master (gnus-compat problems)

[Steinar Bang]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

Platform: Ubuntu 10.0
          GNU Emacs 23.1.1


Offending commit (found with git bisect):

sb@aa1steinar:~/git/gnus$ git bisect good
15ceddb656d3650b6626205b58629b68f67a86c3 is the first bad commit
commit 15ceddb656d3650b6626205b58629b68f67a86c3
Author: Lars Ingebrigtsen <larsi@gnus.org>
Date:   Wed Feb 1 20:35:34 2012 +0100

    Redefine `delete-directory' on Emacs 22 and XEmacs
    
    * gnus-compat.el: Redefine `delete-directory' to provide recursive
    deletion unless already defined.

:040000 040000 18a8200b49ff2ab3b61147f7cb13e8e61eff47c9 c3d857de599cade1098d29888c55e4b0c9cdf93a M	lisp


Stack trace:


[-- Attachment #2: Stack trace from starting gnus --]
[-- Type: text/plain, Size: 1394 bytes --]

Debugger entered--Lisp error: (wrong-type-argument sequencep t)
  byte-code("ÂψÅ!„\0Æ!ƒ\0Å\"ˆÉ!GUƒ4Ë\bBÌ!„/ÍÉK\"ˆÉ\"ˆÐ!‡" [current-load-list nil (byte-code "Á!‡" [require help-fns] 2) ((error)) fboundp help-function-arglist function-arglist defalias #[(def &optional preserve-names) "Â\b!—!@A‡" [def read-from-string function-arglist] 3 "Return a formal argument list for the function DEF.\nPRESERVE-NAMES is ignored."] delete-directory 1 gnus-compat-original-delete-directory default-boundp set-default #[(directory &optional recursive trash) "\b„\b	\n!‡\n\"^[‰ƒ7\f@È\v!ɝ„0Ê\v!ƒ,Ë\v\"ˆ‚0Ì\v!ˆ\fA‰„\0*\n!‡" [recursive gnus-compat-original-delete-directory directory file --cl-dolist-temp-- directory-files t nil file-name-nondirectory ... file-directory-p delete-directory delete-file] 4 "Delete the directory named DIRECTORY.  Does not follow symlinks.\nIf RECURSIVE is non-nil, all files in DIRECTORY are deleted as well.\nTRASH is ignored." "DDirectory: "] provide gnus-compat] 3)
  require(gnus-compat)
  eval-buffer(#<buffer  *load*> nil "/home/sb/git/gnus/lisp/gnus.el" nil t)  ; Reading at buffer position 1237
  load-with-code-conversion("/home/sb/git/gnus/lisp/gnus.el" "/home/sb/git/gnus/lisp/gnus.el" nil nil)
  load("gnus.el")
  load-library("gnus.el")
  call-interactively(load-library t nil)
  execute-extended-command(nil)
  call-interactively(execute-extended-command nil nil)

Re: emacs23 broken on master (gnus-compat problems)

[Lars Ingebrigtsen]

Steinar Bang <sb@dod.no> writes:

> Debugger entered--Lisp error: (wrong-type-argument sequencep t)

[...]

>   require(gnus-compat)

I don't have Emacs 23.1 available here, only Emacs 23.3, and it doesn't
display any errors.

Are you sure you're loading the .elc file compiled with the same version
of Emacs that you've compiled it with?

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome

Re: emacs23 broken on master (gnus-compat problems)

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I don't have Emacs 23.1 available here, only Emacs 23.3, and it doesn't
> display any errors.

I downloaded the source, but it doesn't build at all.  

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome

Re: emacs23 broken on master (gnus-compat problems)

[Steinar Bang]

>>>>> Lars Ingebrigtsen <larsi@gnus.org>:
> Lars Ingebrigtsen <larsi@gnus.org> writes:

>> I don't have Emacs 23.1 available here, only Emacs 23.3, and it doesn't
>> display any errors.

> I downloaded the source, but it doesn't build at all.  

Debian stable has 23.2:
 http://packages.debian.org/squeeze/emacs23

lenny-backports has 23.1 (possibly the same package Ubuntu 10.10 is using...?):
 http://packages.debian.org/lenny-backports/emacs23

Dunno if you have any machines available that can install either.  I
have two debian stable machines.  I can try on them later today.

Re: emacs23 broken on master (gnus-compat problems)

[Steinar Bang]

>>>>> Steinar Bang <sb@dod.no>:

> Debian stable has 23.2:
>  http://packages.debian.org/squeeze/emacs23

> lenny-backports has 23.1 (possibly the same package Ubuntu 10.10 is
> using...?):
>  http://packages.debian.org/lenny-backports/emacs23

> Dunno if you have any machines available that can install either.  I
> have two debian stable machines.  I can try on them later today.

Tried emacs 23.2 on debian stable.  It did not have the problem.

Re: emacs23 broken on master (gnus-compat problems)

[Lars Ingebrigtsen]

Steinar Bang <sb@dod.no> writes:

> Dunno if you have any machines available that can install either.  I
> have two debian stable machines.  I can try on them later today.

My older test machines at home are switched off, unfortunately.  None of
the machines that I can easily test this stuff on have Emacs 23.1
available on them, and since Emacs 23.1 doesn't compile at all for me on
modern machines, it's difficult to debug.

Could someone who has Emacs 23.1 handy try to figure out why these two
seemingly innocent functions in gnus-compat.el fail under Emacs 23.1?

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome

Re: emacs23 broken on master (gnus-compat problems)

[Steinar Bang]

>>>>> Lars Ingebrigtsen <larsi@gnus.org>:

> Could someone who has Emacs 23.1 handy try to figure out why these two
> seemingly innocent functions in gnus-compat.el fail under Emacs 23.1?

Could you give me more detail about what to look for?  Ie. what
functions are these?  Also tips for debugging would be handy.

In the meantime I'll look at the diff for the offending commit.

Re: emacs23 broken on master (gnus-compat problems)

[Steinar Bang]

>>>>> Steinar Bang <sb@dod.no>:
>>>>> Lars Ingebrigtsen <larsi@gnus.org>:

>> Could someone who has Emacs 23.1 handy try to figure out why these two
>> seemingly innocent functions in gnus-compat.el fail under Emacs 23.1?

> Could you give me more detail about what to look for?  Ie. what
> functions are these?  Also tips for debugging would be handy.

> In the meantime I'll look at the diff for the offending commit.

Here it is:
 http://git.gnus.org/cgit/gnus.git/commit/?id=15ceddb656d3650b6626205b58629b68f67a86c3

Re: emacs23 broken on master (gnus-compat problems)

[Steinar Bang]

>>>>> Steinar Bang <sb@dod.no>:

> Here it is:
>  http://git.gnus.org/cgit/gnus.git/commit/?id=15ceddb656d3650b6626205b58629b68f67a86c3

I tried evaluating the when in the scratch buffer of emacs 23.1, ie.

(when (= (length (help-function-arglist 'delete-directory)) 1)
  (defvar gnus-compat-original-delete-directory 
    (symbol-function 'delete-directory))
  (defun delete-directory (directory &optional recursive)
    (if (not recursive)
	(funcall gnus-compat-original-delete-directory directory)
      (dolist (file (directory-files directory t))
	(unless (member (file-name-nondirectory file) '("." ".."))
	  (if (file-directory-p file)
	      (delete-directory file t)
	    (delete-file file))))
      (delete-directory directory))))

The result of a Ctrl-j at the end, was:
Debugger entered--Lisp error: (wrong-type-argument sequencep t)
  length(t)
  (= (length (help-function-arglist ...)) 1)
  (if (= (length ...) 1) (progn (defvar gnus-compat-original-delete-directory ...) (defun delete-directory ... ...)))
  (when (= (length ...) 1) (defvar gnus-compat-original-delete-directory (symbol-function ...)) (defun delete-directory (directory &optional recursive) (if ... ... ... ...)))
  eval((when (= (length ...) 1) (defvar gnus-compat-original-delete-directory (symbol-function ...)) (defun delete-directory (directory &optional recursive) (if ... ... ... ...))))
  eval-last-sexp-1(t)
  eval-last-sexp(t)
  eval-print-last-sexp()
  call-interactively(eval-print-last-sexp nil nil)

Re: emacs23 broken on master (gnus-compat problems)

[Steinar Bang]

>>>>> Steinar Bang <sb@dod.no>:

>>>>> Steinar Bang <sb@dod.no>:
>> Here it is:
>> http://git.gnus.org/cgit/gnus.git/commit/?id=15ceddb656d3650b6626205b58629b68f67a86c3

> I tried evaluating the when in the scratch buffer of emacs 23.1, ie.
[snip!]
> The result of a Ctrl-j at the end, was:
> Debugger entered--Lisp error: (wrong-type-argument sequencep t)
>   length(t)

In Emacs 23.3.1 
 (help-function-arglist 'delete-directory)
evaluates to
 (directory &optional recursive)

In Emacs 23.1.1
 (help-function-arglist 'delete-directory)
evaluates to 
 t

Re: emacs23 broken on master (gnus-compat problems)

[Andreas Schwab]

Steinar Bang <sb@dod.no> writes:

> In Emacs 23.1.1
>  (help-function-arglist 'delete-directory)
> evaluates to 
>  t

Because delete-directory is undefined.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: emacs23 broken on master (gnus-compat problems)

[Lars Ingebrigtsen]

Andreas Schwab <schwab@linux-m68k.org> writes:

>> In Emacs 23.1.1
>>  (help-function-arglist 'delete-directory)
>> evaluates to 
>>  t
>
> Because delete-directory is undefined.

No, in Emacs 23.1 all subrs return t, apparently.  And
`delete-directory' was defined as a C function back then.

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome

Re: emacs23 broken on master (gnus-compat problems)

[Lars Ingebrigtsen]

Steinar Bang <sb@dod.no> writes:

> In Emacs 23.3.1 
>  (help-function-arglist 'delete-directory)

Try with Ma Gnus now.

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome

Re: emacs23 broken on master (gnus-compat problems)

[Steinar Bang]

>>>>> Lars Ingebrigtsen <larsi@gnus.org>:


> Try with Ma Gnus now.

Pulled and rebuilt, and I can confirm gnus now starts and runs on emacs
23.1 (in fact, this response is written in emacs 23.1).

Re: emacs23 broken on master (gnus-compat problems)

[Andreas Schwab]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Steinar Bang <sb@dod.no> writes:
>
>> Dunno if you have any machines available that can install either.  I
>> have two debian stable machines.  I can try on them later today.
>
> My older test machines at home are switched off, unfortunately.  None of
> the machines that I can easily test this stuff on have Emacs 23.1
> available on them, and since Emacs 23.1 doesn't compile at all for me on
> modern machines, it's difficult to debug.

Try cherry-picking this:

commit 16abbbf51d9ae4cefd41abdcc0940e94a188a028
Author: Chong Yidong <cyd@stupidchicken.com>
Date:   Fri Oct 23 16:19:37 2009 +0000

    * configure.in: Invoke $CPP with -P when creating Makefile and
    src/Makefile.  Without this, gcc 4.4.2 converts each
    backslash-newline pair in the input to a bare newline, yielding
    invalid Makefiles.
    
    * configure: Regenerate.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: emacs23 broken on master (gnus-compat problems)

[Lars Ingebrigtsen]

Andreas Schwab <schwab@linux-m68k.org> writes:

>     * configure.in: Invoke $CPP with -P when creating Makefile and
>     src/Makefile.  Without this, gcc 4.4.2 converts each
>     backslash-newline pair in the input to a bare newline, yielding
>     invalid Make files.

Thanks.  The patch didn't apply, but I just added the -P and fixed up
some crt1 issues in the Makefiles, and now it compiles.

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome

Re: emacs23 broken on master (gnus-compat problems)

[Carson Chittom]

Steinar Bang <sb@dod.no> writes:

>>>>>> Lars Ingebrigtsen <larsi@gnus.org>:
>> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>>> I don't have Emacs 23.1 available here, only Emacs 23.3, and it doesn't
>>> display any errors.
>
>> I downloaded the source, but it doesn't build at all.  
>
> Debian stable has 23.2:
>  http://packages.debian.org/squeeze/emacs23
>
> lenny-backports has 23.1 (possibly the same package Ubuntu 10.10 is
> using...?)

I don't know which is 10.10, but

http://packages.ubuntu.com/search?keywords=emacs 

has the Emacs versions in Ubuntu.

Re: emacs23 broken on master (gnus-compat problems)

[Steinar Bang]

>>>>> Lars Ingebrigtsen <larsi@gnus.org>:

> I don't have Emacs 23.1 available here, only Emacs 23.3, and it doesn't
> display any errors.

> Are you sure you're loading the .elc file compiled with the same
> version of Emacs that you've compiled it with?

Yes.  It's the only emacs installed on this netbook (Ubuntu 10.10).

As you can see it previously had emacs22 installed on Ubuntu 10.04, and
have for a short time had an emacs24 snapshot installed:

ii  emacs                                     23.1+1-4ubuntu7.2+maverick1                       The GNU Emacs editor (metapackage)
rc  emacs-snapshot                            1:20111104-1~ppa1~maverick1                       The GNU Emacs editor (development snapshot)
rc  emacs-snapshot-common                     1:20111104-1~ppa1~maverick1                       The GNU Emacs editor's common infrastructure
rc  emacs22                                   22.2-0ubuntu9                                     The GNU Emacs editor (Emacs 22)
ii  emacs23                                   23.1+1-4ubuntu7.2+maverick1                       The GNU Emacs editor (with GTK+ user interface)
ii  emacs23-bin-common                        23.1+1-4ubuntu7.2+maverick1                       The GNU Emacs editor's shared, architecture dependent files
ii  emacs23-common                            23.1+1-4ubuntu7.2+maverick1                       The GNU Emacs editor's shared, architecture independent infrastructure
ii  emacs23-el                                23.1+1-4ubuntu7.2+maverick1                       GNU Emacs LISP (.el) files
ii  emacsen-common                            1.4.19ubuntu1                                     Common facilities for all emacsen