Re: message-yank-original issue

[Antoine Levitt <antoine.levitt@gmail.com>]

14/03/11 20:13, Ted Zlatanov
> On Mon, 14 Mar 2011 11:11:47 +0100 David Kastrup <dak@gnu.org> wrote: 
>
> DK> It has now been about two weeks that message-yank-original has stopped
> DK> being functional for installations that don't have cl loaded permanently
> DK> (namely standard Emacs installations).
>
> I posted a fix on the bug list, can you reply there if it worked?
>
> (In case it gets dropped, the patch is below.)
>
> Ted
>
>
> diff --git a/lisp/message.el b/lisp/message.el
> index 4fa55ef..c939303 100644
> --- a/lisp/message.el
> +++ b/lisp/message.el
> @@ -3792,13 +3792,13 @@ prefix, and don't delete any headers."
>  		(goto-char (mark t))
>  		(insert-before-markers ?\n)
>  		(goto-char pt))))
> -	  (case message-cite-reply-position
> -	    ('above
> +	  (cond
> +	    ((eq 'above message-cite-reply-position)
>  	     (message-goto-body)
>  	     (insert body-text)
>  	     (insert (if (bolp) "\n" "\n\n"))
>  	     (message-goto-body))
> -	    ('below
> +	    ((eq 'below message-cite-reply-position)
>  	     (message-goto-signature)))
>  	  ;; Add a `message-setup-very-last-hook' here?
>  	  ;; Add `gnus-article-highlight-citation' here?

Woops, this one is my fault. Sorry, I didn't think about that.

Any reason why cl isn't loaded by default, by the way? And is it
considered bad practice for packages to require cl?

Antoine