From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/77694 Path: news.gmane.org!not-for-mail From: Antoine Levitt Newsgroups: gmane.emacs.gnus.general Subject: Re: message-yank-original issue Date: Mon, 14 Mar 2011 20:38:06 +0100 Message-ID: <878vwhijc1.fsf@gmail.com> References: <871v2ako4c.fsf@fencepost.gnu.org> <87lj0ha52s.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1300131556 26137 80.91.229.12 (14 Mar 2011 19:39:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 14 Mar 2011 19:39:16 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M26018@lists.math.uh.edu Mon Mar 14 20:39:12 2011 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PzDbh-0001T5-6q for ding-account@gmane.org; Mon, 14 Mar 2011 20:39:09 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1PzDaw-0005sy-Uc; Mon, 14 Mar 2011 14:38:23 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1PzDau-0005sZ-Kf for ding@lists.math.uh.edu; Mon, 14 Mar 2011 14:38:20 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1PzDat-0003fk-R9 for ding@lists.math.uh.edu; Mon, 14 Mar 2011 14:38:20 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1PzDat-0007BN-42 for ding@gnus.org; Mon, 14 Mar 2011 20:38:19 +0100 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PzDas-00018f-GZ for ding@gnus.org; Mon, 14 Mar 2011 20:38:18 +0100 Original-Received: from ney92-7-78-233-218-202.fbx.proxad.net ([78.233.218.202]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 14 Mar 2011 20:38:18 +0100 Original-Received: from antoine.levitt by ney92-7-78-233-218-202.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 14 Mar 2011 20:38:18 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 42 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: ney92-7-78-233-218-202.fbx.proxad.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Spam-Score: -1.0 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:77694 Archived-At: 14/03/11 20:13, Ted Zlatanov > On Mon, 14 Mar 2011 11:11:47 +0100 David Kastrup wrote: > > DK> It has now been about two weeks that message-yank-original has stopped > DK> being functional for installations that don't have cl loaded permanently > DK> (namely standard Emacs installations). > > I posted a fix on the bug list, can you reply there if it worked? > > (In case it gets dropped, the patch is below.) > > Ted > > > diff --git a/lisp/message.el b/lisp/message.el > index 4fa55ef..c939303 100644 > --- a/lisp/message.el > +++ b/lisp/message.el > @@ -3792,13 +3792,13 @@ prefix, and don't delete any headers." > (goto-char (mark t)) > (insert-before-markers ?\n) > (goto-char pt)))) > - (case message-cite-reply-position > - ('above > + (cond > + ((eq 'above message-cite-reply-position) > (message-goto-body) > (insert body-text) > (insert (if (bolp) "\n" "\n\n")) > (message-goto-body)) > - ('below > + ((eq 'below message-cite-reply-position) > (message-goto-signature))) > ;; Add a `message-setup-very-last-hook' here? > ;; Add `gnus-article-highlight-citation' here? Woops, this one is my fault. Sorry, I didn't think about that. Any reason why cl isn't loaded by default, by the way? And is it considered bad practice for packages to require cl? Antoine