From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/72317 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] Introduce gnus-completing-read Date: Thu, 30 Sep 2010 12:13:15 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <878w2j6tp0.fsf@lifelogs.com> References: <1285688153-19680-1-git-send-email-julien@danjou.info> <87wrq5ammm.fsf@tardis.home.perldition.org> <87eicdacn6.fsf@tardis.home.perldition.org> <87hbh9tx2x.fsf@keller.adm.naquadah.org> <87y6aj7mp2.fsf@marauder.physik.uni-ulm.de> <87y6aj4jjk.fsf@tardis.home.perldition.org> <87hbh74gb5.fsf@tardis.home.perldition.org> <87d3rv4fvz.fsf@tardis.home.perldition.org> <87sk0r2xzc.fsf@tardis.home.perldition.org> <87pqvv6utx.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1285866821 5082 80.91.229.12 (30 Sep 2010 17:13:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 30 Sep 2010 17:13:41 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M20690@lists.math.uh.edu Thu Sep 30 19:13:40 2010 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P1MhP-0003Hd-6W for ding-account@gmane.org; Thu, 30 Sep 2010 19:13:39 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1P1MhL-0004xT-Fo; Thu, 30 Sep 2010 12:13:35 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1P1MhJ-0004x8-Eb for ding@lists.math.uh.edu; Thu, 30 Sep 2010 12:13:33 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1P1MhF-0003PW-AP for ding@lists.math.uh.edu; Thu, 30 Sep 2010 12:13:33 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1P1MhE-0001dV-00 for ; Thu, 30 Sep 2010 19:13:28 +0200 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1P1MhC-0003CY-C3 for ding@gnus.org; Thu, 30 Sep 2010 19:13:26 +0200 Original-Received: from 38.98.147.130 ([38.98.147.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 30 Sep 2010 19:13:26 +0200 Original-Received: from tzz by 38.98.147.130 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 30 Sep 2010 19:13:26 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 39 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 38.98.147.130 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:JcozXqSdkmZ2+YGPvMXCGR+1h2g= X-Spam-Score: -0.7 (/) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:72317 Archived-At: On Thu, 30 Sep 2010 18:55:49 +0200 Lars Magne Ingebrigtsen wrote: LMI> Ted Zlatanov writes: >> This did make me wish for a "collect unique x" option for the CL loop :) LMI> Yeah, that's be nice, but then you'd have to have a :key and :test LMI> argument, too. :-) LMI> collect unique :key #'cadr :test #'equalp x Heh, yeah. Oh well. On Thu, 30 Sep 2010 19:06:08 +0200 Florian Ragwitz wrote: FR> This appears to be as correct as my initial version of it. However, FR> Julien made some follow-up changes to it, fixing a bug regarding FR> handling of history. Your version makes the same mistake I initially FR> did. Julien's fix needs to be adapted for the new code. I just looked at the rev ID you mentioned. Argh. Anyhow, the point was that it's just a small rewrite to make your patch trivial. Julien may be the best person to do it to ensure it's not accidentally broken, but I'll do it if he doesn't have the time. I *think* that's within the spirit of the GNU project, especially since you (Florian) are OK with the rewrite. >> This did make me wish for a "collect unique x" option for the CL loop >> :) FR> That'd be nice, but with cl, there's also `remove-duplicates'. Without FR> cl, the following is probably much more elegant than the original patch: FR> (delq nil (delete-dups ...)) Yeah, that is nicer, but I somehow always find the CL constructs neater. Ted