From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/68131 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general,gmane.emacs.xemacs.patches Subject: Re: [PATCH] Fix a bug with XEmacs and bignum support. Date: Sun, 11 Jan 2009 18:16:07 +0100 Message-ID: <878wphpxuw.fsf@marauder.physik.uni-ulm.de> References: <18793.58572.280122.113699@parhasard.net> <87sknpq37c.fsf@marauder.physik.uni-ulm.de> <18794.5761.657812.233052@parhasard.net> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1231709490 17477 80.91.229.12 (11 Jan 2009 21:31:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 11 Jan 2009 21:31:30 +0000 (UTC) Cc: xemacs-patches@xemacs.org, ding@gnus.org To: Aidan Kehoe Original-X-From: ding-owner+M16575@lists.math.uh.edu Sun Jan 11 22:32:41 2009 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1LM7vD-00054c-89 for ding-account@gmane.org; Sun, 11 Jan 2009 22:32:39 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1LM7st-0001oW-Fv; Sun, 11 Jan 2009 15:30:15 -0600 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1LM7sr-0001o7-CC for ding@lists.math.uh.edu; Sun, 11 Jan 2009 15:30:13 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1LM7so-0001Q0-OF for ding@lists.math.uh.edu; Sun, 11 Jan 2009 15:30:13 -0600 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1LM7t5-0004Rs-00 for ; Sun, 11 Jan 2009 22:30:27 +0100 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.175]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id n0BLU8OO029549; Sun, 11 Jan 2009 22:30:08 +0100 (MET) Original-Received: from localhost (localhost [127.0.0.1]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 19F221C998; Sun, 11 Jan 2009 22:30:08 +0100 (CET) X-Face: 'bg&jY[8V'W&:=~6w"|>}#4/T;w~36ei4NNMyKRR.a$n=$|sWFPF1y]a\>6kc\*#GN]UDM| Ywv,vbL^XF1nIp\:F=$Ei2o&mEe:%N~,:3]vtQ~s9u$9izmX$IF@VgGl7/,^dbuM<3|AO2}.%|%?kZ 2Y=@\U!~cll^=8Z9ihKq%wmUe1Ky(#kl3T'>Qk0Ia3mCBsTk?E(,X Mail-Followup-To: Aidan Kehoe , xemacs-patches@xemacs.org, ding@gnus.org In-Reply-To: <18794.5761.657812.233052@parhasard.net> (Aidan Kehoe's message of "Sun, 11 Jan 2009 15:55:45 +0000") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.1 (gnu/linux) X-DCC-CTc-dcc2-Metrics: poseidon 1031; Body=3 Fuz1=3 Fuz2=3 X-Virus-Scanned: by amavisd-new X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:68131 gmane.emacs.xemacs.patches:9828 Archived-At: On Sun, Jan 11 2009, Aidan Kehoe wrote: > Ar an t-aon=C3=BA l=C3=A1 d=C3=A9ag de m=C3=AD Eanair, scr=C3=ADobh Rein= er Steib:=20 > > most-positive-fixnum is only available in Emacs 21 when requiring CL. > > Oops, you=E2=80=99re right, it was included it in C just after the releas= e. Thanks > for checking. > > > But as CL is required (for ignore-errors), I think this change is > > fine, so I have installed it. > > It=E2=80=99s not, though, it needs to be something like the following in = that case, > since CL is available at compile time and not necessarily at runtime:=20 > > --- /tmp/aidan/nnfolder.el.orig 2009-01-11 15:50:39.000000000 +0000 > +++ /tmp/aidan/nnfolder.el 2009-01-11 15:50:16.000000000 +0000 > @@ -899,7 +899,9 @@ > (active (or (cadr (assoc group nnfolder-group-alist)) > (cons 1 0))) > (scantime (assoc group nnfolder-scantime-alist)) > - (minid (lsh -1 -1)) > + (minid (or (and (boundp 'most-positive-fixnum) > + most-positive-fixnum) > + 134217727)) > An (eval-when-compile most-positive-fixnum) isn=E2=80=99t appropriate, be= cause the > compile-time constant could be from a 64-bit machine, which would silently > overflow in the Lisp reader under GNU=20 s/GNU/Emacs/, please. :-) > on a 32-bit machine, and break the algorithm. If you need to make sure that the correct runtime value is used, I don't understand why you hard-code 134217727? I would have expected... (minid (or (and (boundp 'most-positive-fixnum) most-positive-fixnum) (lsh -1 -1))) What am I missing? On a 64-bit machine, I get: ,----[ M-x ielm RET ] | ELISP> (lsh -1 -1) | 576460752303423487 | ELISP> (emacs-version) | "GNU Emacs 21.3.1 (x86_64-suse-linux, X toolkit, Xaw3d scroll bars)\n of = 2004-1\ | 0-05 on prokofjieff" | ELISP> (when (require 'cl) most-positive-fixnum) | 576460752303423487 `---- When I used this machine(s) some years ago, I always compiled Gnus, AUCTeX, BBDB, emacs-w3m, etc on a 64-bit machine and ran the compiled Lisp code on both, 64-bit and 32-bit machines (/usr/local/share/emacs/site-lisp shared via NFS). Bye, Reiner. --=20 ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/