Re: patch - nnimap - case handling in STATUS command and response

[Simon Josefsson <simon@josefsson.org>]

nathanw@MIT.EDU (Nathan J. Williams) writes:

> The function imap-mailbox-status is careful to send tokens in
> uppercase. imap-mailbox-status-async should be similarly careful. On
> the receiving end, imap-parse-status needs to upcase the tokens before
> applying string= to them, since the server might send them as
> lowercase.
>
> Noticed against MS Exchange 2007, which sends back STATUS tokens as
> lowercase if you sent them to it as lowercase.

Thanks, applied.  Note that the server is broken here, the RFC is clear
that the status-att are upper case.

/Simon

> 	- Nathan
>
> Index: imap.el
> ===================================================================
> RCS file: /usr/local/cvsroot/gnus/lisp/imap.el,v
> retrieving revision 7.34
> diff -u -r7.34 imap.el
> --- imap.el	25 Oct 2007 08:17:54 -0000	7.34
> +++ imap.el	3 Dec 2007 17:12:25 -0000
> @@ -1526,10 +1526,11 @@
>      (imap-send-command (list "STATUS \""
>  			     (imap-utf7-encode mailbox)
>  			     "\" "
> -			     (format "%s"
> -				     (if (listp items)
> -					 items
> -				       (list items)))))))
> +			     (upcase
> +			      (format "%s"
> +				      (if (listp items)
> +					  items
> +					(list items))))))))
>  
>  (defun imap-mailbox-acl-get (&optional mailbox buffer)
>    "Get ACL on mailbox from server in BUFFER."
> @@ -2517,7 +2518,7 @@
>        (while (and (not (eq (char-after) ?\)))
>  		  (or (forward-char) t)
>  		  (looking-at "\\([A-Za-z]+\\) "))
> -	(let ((token (match-string 1)))
> +	(let ((token (upcase (match-string 1))))
>  	  (goto-char (match-end 0))
>  	  (cond ((string= token "MESSAGES")
>  		 (imap-mailbox-put 'messages (read (current-buffer)) mailbox))