* Re: gnus-article-hide-headers beeps: Buffer is read-only
[not found] <87d4y3mf3z.fsf@gmx.de>
@ 2007-08-04 20:33 ` Reiner Steib
2007-08-04 21:17 ` Sven Joachim
2007-08-06 1:46 ` Katsumi Yamaoka
0 siblings, 2 replies; 3+ messages in thread
From: Reiner Steib @ 2007-08-04 20:33 UTC (permalink / raw)
To: Sven Joachim; +Cc: ding, Katsumi Yamaoka, bugs
On Sat, Aug 04 2007, Sven Joachim wrote:
> Gnus v5.11
> GNU Emacs 22.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.10.13)
> of 2007-07-31 on debian, modified by Debian
> 200 news.gmane.org InterNetNews NNRP server INN 2.4.1 ready (posting ok).
>
> When typing "W W h" in a *Summary* buffer, Emacs beeps and displays
> the error message: "Buffer is read-only: #<buffer *Article*>" (in
> *Messages* this shows up as
> "article-hide-headers: Buffer is read-only: #<buffer *Article*>").
>
> Enabling debug-on-error does not enter the debugger in this case.
Thanks for your report. Does the following patch fix it?
--8<---------------cut here---------------start------------->8---
--- gnus-art.el 04 Aug 2007 20:35:29 +0200 1.125.2.5
+++ gnus-art.el 04 Aug 2007 22:14:56 +0200
@@ -1743,7 +1743,7 @@
(interactive)
;; This function might be inhibited.
(unless gnus-inhibit-hiding
- (let ((inhibit-read-only nil)
+ (let ((inhibit-read-only t)
(case-fold-search t)
(max (1+ (length gnus-sorted-header-list)))
(inhibit-point-motion-hooks t)
--8<---------------cut here---------------end--------------->8---
Katsumi, the problem was introduced by this change ...
--8<---------------cut here---------------start------------->8---
revision 6.381.2.6
date: 2004/08/26 09:59:42; author: yamaoka; state: Exp; lines: +55 -47
[...]
* gnus-art.el (article-hide-headers): Refer to the values for
gnus-ignored-headers and gnus-visible-headers in the summary
buffer since a user may have set them as group parameters.
(gnus-article-read-summary-keys): Restore new window-start and
hscroll to summary window.
(gnus-prev-page-map): Remove duplicated one.
--8<---------------cut here---------------end--------------->8---
... and fixed in the trunk by Lars:
--8<---------------cut here---------------start------------->8---
revision 7.185
date: 2006/06/21 18:14:23; author: larsi; state: Exp; lines: +1 -1
* gnus-art.el (article-hide-headers): Inhibit read-only stuff.
--8<---------------cut here---------------end--------------->8---
I think the wrong value of inhibit-read-only was just a mistake
(replacing "buffer-read-only" with "inhibit-read-only"?). But the
ChangeLog doesn't say anything about removing (save-excursion
(save-restriction ...)).
I doubt the other occurrence of "(inhibit-read-only nil)" in
`gnus-x-splash' is correct. Is it?
--8<---------------cut here---------------start------------->8---
revision 7.17
date: 2007/06/07 11:59:35; author: yamaoka; state: Exp; lines: +79 -34
* gnus-ems.el (gnus-x-splash): Make it work.
--8<---------------cut here---------------end--------------->8---
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: gnus-article-hide-headers beeps: Buffer is read-only
2007-08-04 20:33 ` gnus-article-hide-headers beeps: Buffer is read-only Reiner Steib
@ 2007-08-04 21:17 ` Sven Joachim
2007-08-06 1:46 ` Katsumi Yamaoka
1 sibling, 0 replies; 3+ messages in thread
From: Sven Joachim @ 2007-08-04 21:17 UTC (permalink / raw)
To: Reiner Steib; +Cc: ding, Katsumi Yamaoka, bugs
Reiner Steib <reinersteib+from-uce@imap.cc> writes:
> Thanks for your report. Does the following patch fix it?
>
> --8<---------------cut here---------------start------------->8---
> --- gnus-art.el 04 Aug 2007 20:35:29 +0200 1.125.2.5
> +++ gnus-art.el 04 Aug 2007 22:14:56 +0200
> @@ -1743,7 +1743,7 @@
> (interactive)
> ;; This function might be inhibited.
> (unless gnus-inhibit-hiding
> - (let ((inhibit-read-only nil)
> + (let ((inhibit-read-only t)
> (case-fold-search t)
> (max (1+ (length gnus-sorted-header-list)))
> (inhibit-point-motion-hooks t)
> --8<---------------cut here---------------end--------------->8---
Yes it does. :-)
Thanks,
Sven
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: gnus-article-hide-headers beeps: Buffer is read-only
2007-08-04 20:33 ` gnus-article-hide-headers beeps: Buffer is read-only Reiner Steib
2007-08-04 21:17 ` Sven Joachim
@ 2007-08-06 1:46 ` Katsumi Yamaoka
1 sibling, 0 replies; 3+ messages in thread
From: Katsumi Yamaoka @ 2007-08-06 1:46 UTC (permalink / raw)
To: Reiner Steib; +Cc: Sven Joachim, ding, bugs
>>>>> Reiner Steib wrote:
> Katsumi, the problem was introduced by this change ...
[...]
> I think the wrong value of inhibit-read-only was just a mistake
> (replacing "buffer-read-only" with "inhibit-read-only"?).
Oops. I must have been half asleep.
> But the ChangeLog doesn't say anything about removing (save-excursion
> (save-restriction ...)).
Not `removing' but I did `moving' them to the places just in
front of what need to perform them (for two `set-buffer's, and
for `article-narrow-to-head'). That change makes no difference
in the actual behavior but I might have thought it clarifies the
meaning of the source code.
> I doubt the other occurrence of "(inhibit-read-only nil)" in
> `gnus-x-splash' is correct. Is it?
> --8<---------------cut here---------------start------------->8---
> revision 7.17
> date: 2007/06/07 11:59:35; author: yamaoka; state: Exp; lines: +79 -34
> * gnus-ems.el (gnus-x-splash): Make it work.
> --8<---------------cut here---------------end--------------->8---
That must be a mistake, too. I've fixed it in the v5-10 branch
(it will be merged into Emacs and the Gnus trunk together with
your fix). Thank you very much for investigating these.
Regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-06 1:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <87d4y3mf3z.fsf@gmx.de>
2007-08-04 20:33 ` gnus-article-hide-headers beeps: Buffer is read-only Reiner Steib
2007-08-04 21:17 ` Sven Joachim
2007-08-06 1:46 ` Katsumi Yamaoka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).