Gnus (real) bookmarks

Gnus (real) bookmarks

[Bastien]

Hello,

here is an attempt to implement real bookmarks within Gnus:
<http://www.cognition.ens.fr/~guerry/emacs/code/gnus-bmk.el.gz>

Most of the code comes from bookmark.el.

Use `gnus-bmk-set' to set a bookmark from the summary buffer.
Use `gnus-bmk-jump' to jump to a bookmark.
Use `gnus-bmk-bmenu-list' to list bookmarks.

You can also use *annotations* by turning on
`gnus-bmk-use-annotations'.  

See M-x customize-group RET gnus-bmk for more details.

Any feedback welcome!

regards,

-- 
Bastien

Re: Gnus (real) bookmarks

[Christoph Conrad]

Hello Bastien,

> Any feedback welcome!

M-x load-library <RET> gnus-bmk <RET>

=>

"byte-code: Key sequence C-c r m uses invalid prefix characters"

This is because "C-c r" is already bound by me. I think Emacs does not
produce an understandable message, especially not understandable for end
users.

Best wishes,
Christoph

Re: Gnus (real) bookmarks

[Bastien]

Bastien <bzg@altern.org> writes:

> here is an attempt to implement real bookmarks within Gnus:
> <http://www.cognition.ens.fr/~guerry/emacs/code/gnus-bmk.el.gz>

I just unbounded the keys (there were local to me).

Any left key to bound `gnus-bmk-set' in gnus-summary-mode-map?

`gnus-bmk-jump' and `gnus-bmk-bmenu-list' can be bound to global keys,
so they should be set up by the user.

-- 
Bastien

Re: Gnus (real) bookmarks

[Lars Magne Ingebrigtsen]

Bastien <bzg@altern.org> writes:

>> here is an attempt to implement real bookmarks within Gnus:
>> <http://www.cognition.ens.fr/~guerry/emacs/code/gnus-bmk.el.gz>

I just had a quick look over the code.  Looks nice.  :-)

Do you have copyright assignment papers on file with the FSF?

> Any left key to bound `gnus-bmk-set' in gnus-summary-mode-map?

Hm...  Perhaps under `M' somewhere?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gnus (real) bookmarks

[Bastien]

Hi Lars,

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

>>> here is an attempt to implement real bookmarks within Gnus:
>>> <http://www.cognition.ens.fr/~guerry/emacs/code/gnus-bmk.el.gz>
>
> I just had a quick look over the code.  Looks nice.  :-)

I guess 72% of it comes from bookmark.el, with minor modifications.
So yes, it looks nice!

> Do you have copyright assignment papers on file with the FSF?

I have one for muse-mode.  I guess i signed it for every GNU Emacs
contribution but can't find a copy of the letter at the moment.

>> Any left key to bound `gnus-bmk-set' in gnus-summary-mode-map?
>
> Hm...  Perhaps under `M' somewhere?

M R m ?

-- 
Bastien

Re: Gnus (real) bookmarks

[Romain Francoise]

Bastien <bzg@altern.org> writes:

>> Do you have copyright assignment papers on file with the FSF?

> I have one for muse-mode.  I guess i signed it for every GNU Emacs
> contribution but can't find a copy of the letter at the moment.

Nope, your papers only cover Muse, I checked.

By the way, your name is misspelled as ``Guerrty'' in the copyright
assignment list, you might want to ask the copyright clerk to fix that
(mail assign@gnu.org).

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

Re: Gnus (real) bookmarks

[Bastien]

Romain Francoise <romain@orebokech.com> writes:

>> I have one for muse-mode.  I guess i signed it for every GNU Emacs
>> contribution but can't find a copy of the letter at the moment.
>
> Nope, your papers only cover Muse, I checked.

Ok.  Should i ask another assignment or can i extend the first one?

> By the way, your name is misspelled as ``Guerrty'' in the copyright
> assignment list, you might want to ask the copyright clerk to fix that
> (mail assign@gnu.org).

"Guerrty"! Sounds like a new keyboard layout.  Anyway, i'll handle
that with the clerk.  Thanks!

-- 
Bastien

Re: Gnus (real) bookmarks

[Romain Francoise]

Bastien <bzg@altern.org> writes:

> Ok.  Should i ask another assignment or can i extend the first one?

You need a new assignment, I'm afraid.

(If you sign one for Emacs it'll cover Gnus as well, so I suggest you do
that.)

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

Re: Gnus (real) bookmarks

[Bastien]

Romain Francoise <romain@orebokech.com> writes:

> (If you sign one for Emacs it'll cover Gnus as well, so I suggest
> you do that.)

All right - let's go for it!

-- 
Bastien

Re: Gnus (real) bookmarks

[Reiner Steib]

On Sun, Apr 30 2006, Bastien wrote:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
>>>> here is an attempt to implement real bookmarks within Gnus:
>>>> <http://www.cognition.ens.fr/~guerry/emacs/code/gnus-bmk.el.gz>

I get only 404s on this URL.  Please send the file to the list.

>> I just had a quick look over the code.  Looks nice.  :-)
>
> I guess 72% of it comes from bookmark.el, with minor modifications.

Please make sure to mention this in your file.

>> Do you have copyright assignment papers on file with the FSF?
>
> I have one for muse-mode.

Please clarify the misspelled name "Guerrty" for the Emacs muse
assignment with the Copyright Administrator.

> I guess i signed it for every GNU Emacs contribution but can't find
> a copy of the letter at the moment.

RMS notified me that you papers for Emacs have arrived so we could
install `gnus-bmk.el'.  Maybe it should be renamed to
`gnus-bookmark.el'?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Gnus (real) bookmarks

[Bastien]

Hi Reiner,

Reiner Steib <reinersteib+gmane@imap.cc> writes:

>>>>> here is an attempt to implement real bookmarks within Gnus:
>>>>> <http://www.cognition.ens.fr/~guerry/emacs/code/gnus-bmk.el.gz>
>
> I get only 404s on this URL.  Please send the file to the list.

Here is gnus-bmk.el, renamed as gnus-bookmark.el:
<http://www.cognition.ens.fr/~guerry/u/gnus-bookmark.el>

(I moved all my .el files to this new location - sorry i didn't warn
the list.)

>> I guess 72% of it comes from bookmark.el, with minor modifications.
>
> Please make sure to mention this in your file.

This is already mentionned like this : "Most of the code comes from
bookmark.el."  Just tell me if it needs to be more accurate.

> Please clarify the misspelled name "Guerrty" for the Emacs muse
> assignment with the Copyright Administrator.

Done.  I received my copyright assignment For GNU Emacs last week (see
attached PDF assignment).

> RMS notified me that you papers for Emacs have arrived so we could
> install `gnus-bmk.el'.  Maybe it should be renamed to
> `gnus-bookmark.el'?

Done. 

Regards,

-- 
Bastien

Re: Gnus (real) bookmarks

[Reiner Steib]

On Sun, Apr 30 2006, Bastien wrote:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>>> Any left key to bound `gnus-bmk-set' in gnus-summary-mode-map?
>>
>> Hm...  Perhaps under `M' somewhere?
>
> M R m ?

Did you suggest "R" because of the existing bindings for `bookmark-*'
or is there some other rationale?

It would be nice to integrate the current `gnus-summary-*-bookmark'
functions into your code (i.e. jump to a specific place within an
article).

,----[ (info "(gnus)Setting Marks") ]
| `M b'
|      Set a bookmark in the current article
|      (`gnus-summary-set-bookmark').
| 
| `M B'
|      Remove the bookmark from the current article
|      (`gnus-summary-remove-bookmark').
`----

As for the key bindings, we might steal `M B' (or even `M b'?) and use
it as prefix for all `gnus-bookmark-*' and `gnus-summary-*-bookmark'
commands.  What do people think?  `gnus-bookmark-jump' and
`gnus-bookmark-bmenu-list' should probably be available also from the
Group buffer.


On Mon, Jun 19 2006, Bastien wrote:

[ <news:87ejxl5s1l.fsf@tallis.ilo.ucl.ac.uk> didn't make it to the
  list (yet). ]

> Here is gnus-bmk.el, renamed as gnus-bookmark.el:
> <http://www.cognition.ens.fr/~guerry/u/gnus-bookmark.el>
>
> (I moved all my .el files to this new location - sorry i didn't warn
> the list.)

I've installed this version with some modifications:

	* gnus-bookmark.el: Fix Copyright, keywords, whitespace, etc.
	(gnus-bookmark-default-file): Use gnus-directory.
	(gnus-bookmark-bmenu-file-column, gnus-bookmark-use-annotations):
	Remove "*" in doc string.
	(gnus-bookmark-write-file): Simplify.
	(gnus-bookmark-maybe-sort-alist): Use `when'.
	(gnus-bookmark-get-bookmark): Fix typo in doc string.
	(gnus-bookmark-set-bookmark-name, gnus-bookmark-get-bookmark): Add
	FIXME about Emacs 21 and XEmacs compatibility.
	(gnus-bookmark-set-bookmark-name): Use `gnus-replace-in-string' for
	compatibility.
	(gnus-bookmark-bmenu-mode): Use `gnus-run-mode-hooks' for
	compatibility.

Currently it doesn't work on Emacs 21 and XEmacs 21.4 because of
incompatible use of `split-string' and `assoc-string'.  This should be
fixed.

Further remarks:

- Maybe we should initialize the defcustoms from the corresponding
  `bookmark.el' variables?

- WIBNI there was a command `gnus-bookmark-delete' (without using
  `gnus-bookmark-bmenu-list')?

- `gnus-bookmark-bmenu-delete' should error out when not called from
  the right buffer (*Gnus Bookmark List*).

>> Please clarify the misspelled name "Guerrty" for the Emacs muse
>> assignment with the Copyright Administrator.
>
> Done.  I received my copyright assignment For GNU Emacs last week.

But in the entry for "EMACS MUSE" there is still the wrong name.  The
Copyright Administrator should fix this.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Gnus (real) bookmarks

[Bastien]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

>> M R m ?
>
> Did you suggest "R" because of the existing bindings for
> `bookmark-*' or is there some other rationale?

Yes.

> It would be nice to integrate the current `gnus-summary-*-bookmark'
> functions into your code (i.e. jump to a specific place within an
> article).

I'll work on that, good idea.

> As for the key bindings, we might steal `M B' (or even `M b'?) and
> use it as prefix for all `gnus-bookmark-*' and
> `gnus-summary-*-bookmark' commands.  What do people think?

I would suggest these bindings:

M b		gnus-summary-set-bookmark
M B		gnus-summary-remove-bookmark
C-u M b         gnus-bookmark-set
C-u M B         gnus-bookmark-delete (see below)
M j             gnus-bookmark-jump
M l             gnus-bookmark-bmenu list

> `gnus-bookmark-jump' and `gnus-bookmark-bmenu-list' should probably
> be available also from the Group buffer.

Surprisingly enough, `M l' `M j' are still free, both in the Summary
and the Group buffers.

But maybe you prefer not to mix gnus-summary-*-bookmark and
gnus-bookmark-*.

> I've installed this version with some modifications:

Thanks.

> Currently it doesn't work on Emacs 21 and XEmacs 21.4 because of
> incompatible use of `split-string' and `assoc-string'.  This should
> be fixed.

Right, i'll do that.

> - Maybe we should initialize the defcustoms from the corresponding
>   `bookmark.el' variables?

Okay.

> - WIBNI there was a command `gnus-bookmark-delete' (without using
>   `gnus-bookmark-bmenu-list')?

Was on my todo list.  I guess `gnus-bookmark-delete' will delete the
*real* bookmark, not the position set with `M b' if any.

> - `gnus-bookmark-bmenu-delete' should error out when not called from
>   the right buffer (*Gnus Bookmark List*).

Right.  I'll fix it.

> But in the entry for "EMACS MUSE" there is still the wrong name.
> The Copyright Administrator should fix this.

I will send another e-mail to double-check this issue.

-- 
Bastien

Re: Gnus (real) bookmarks

[Reiner Steib]

On Tue, Jun 20 2006, Bastien wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> It would be nice to integrate the current `gnus-summary-*-bookmark'
>> functions into your code (i.e. jump to a specific place within an
>> article).
>
> I'll work on that, good idea.
>
>> As for the key bindings, we might steal `M B' (or even `M b'?) and
>> use it as prefix for all `gnus-bookmark-*' and
>> `gnus-summary-*-bookmark' commands.  What do people think?
>
> I would suggest these bindings:
>
> M b		gnus-summary-set-bookmark
> M B		gnus-summary-remove-bookmark
> C-u M b         gnus-bookmark-set
> C-u M B         gnus-bookmark-delete (see below)
> M j             gnus-bookmark-jump
> M l             gnus-bookmark-bmenu list
>
>> `gnus-bookmark-jump' and `gnus-bookmark-bmenu-list' should probably
>> be available also from the Group buffer.
>
> Surprisingly enough, `M l' `M j' are still free, both in the Summary
> and the Group buffers.

I'd rather have a common prefix for all bookmark commands instead of
occupying two `M ...' bindings.

The rationale to put `gnus-summary-{set,remove}-bookmark' into under
the `M' prefix might have been that they are similar to marks on
articles.  But AFAICS (I started to use your functions only yesterday) 

Brainstorming...  How about using `G J' as a prefix?  IMHO both in
Summmary and Group mode, the bookmark commands fit quite good in (info
"(gnus)Choosing Commands") and (info "(gnus)Foreign Groups")
(e.g. `gnus-group-read-ephemeral-group', `gnus-group-make-web-group',
...).

> But maybe you prefer not to mix gnus-summary-*-bookmark and
> gnus-bookmark-*.

As for the key bindings and menus, I'd like to have all Gnus bookmark
commands gathered.

I have installed a fix so that `gnus-bookmark-jump' doesn't mark
unrelated articles a read.  Please test if it breaks something.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Gnus (real) bookmarks

[Bastien]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> I'd rather have a common prefix for all bookmark commands instead of
> occupying two `M ...' bindings.

Okay.

> Brainstorming...  How about using `G J' as a prefix?  IMHO both in
> Summmary and Group mode, the bookmark commands fit quite good in (info
> "(gnus)Choosing Commands") and (info "(gnus)Foreign Groups")
> (e.g. `gnus-group-read-ephemeral-group', `gnus-group-make-web-group',
> ...).

It just gave me an idea: what about `gnus-group-make-bookmark-group',
(G b)?  Another way to list all bookmarked article, closer to the Gnus
way.

> I have installed a fix so that `gnus-bookmark-jump' doesn't mark
> unrelated articles a read.  Please test if it breaks something.

I'm a bit short in time this week, but i'll thoroughly test it and
work on it next week.

Thanks for the work you've done!

-- 
Bastien

Re: Gnus (real) bookmarks

[Katsumi Yamaoka]

>>>>> In <v9ejxl3zo0.fsf@marauder.physik.uni-ulm.de>
>>>>>	Reiner Steib wrote:

> Currently it doesn't work on Emacs 21 and XEmacs 21.4 because of
> incompatible use of `split-string' and `assoc-string'.  This should be
> fixed.

Fixed.  Furthermore, I've made some changes in gnus-bookmark.el
so as to work with XEmacs as well, to be able to use any
non-ASCII text in the bookmark file, to make the mouse selection
work properly, etc.

Re: Gnus (real) bookmarks

[Reiner Steib]

On Fri, Aug 18 2006, Katsumi Yamaoka wrote:

> Fixed.  Furthermore, I've made some changes in gnus-bookmark.el
> so as to work with XEmacs as well, to be able to use any
> non-ASCII text in the bookmark file, to make the mouse selection
> work properly, etc.

Thanks.

A remark to this hunk...

-  (define-key gnus-bookmark-bmenu-mode-map "q" 'quit-window)
+  (define-key gnus-bookmark-bmenu-mode-map "q" (if (featurep 'xemacs)
+						   'bury-buffer
+						 'quit-window))

XEmacs 21.5 has both, `bury-buffer' and `quit-window'.  Shouldn't we
use (if (fboundp 'quit-window) 'quit-window 'bury-buffer)?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Gnus (real) bookmarks

[Katsumi Yamaoka]

>>>>> In <v9k656uzjm.fsf@marauder.physik.uni-ulm.de>
>>>>>	Reiner Steib wrote:

> A remark to this hunk...

> -  (define-key gnus-bookmark-bmenu-mode-map "q" 'quit-window)
> +  (define-key gnus-bookmark-bmenu-mode-map "q" (if (featurep 'xemacs)
> +						   'bury-buffer
> +						 'quit-window))

> XEmacs 21.5 has both, `bury-buffer' and `quit-window'.  Shouldn't we
> use (if (fboundp 'quit-window) 'quit-window 'bury-buffer)?

Oh, I checked it only with XEmacs 21.4.19.  Thanks.  Done.