Gnus development mailing list
 help / color / mirror / Atom feed
From: Kevin Ryde <user42@zip.com.au>
Subject: gnus-mime-copy-part and filename
Date: Mon, 18 Nov 2002 07:41:37 +1000	[thread overview]
Message-ID: <878yzrc1ri.fsf@zip.com.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

I notice gnus-mime-copy-part (`c' on the button) looks for a filename
parameter from mm-handle-type, but I wonder if that ought to be
mm-handle-disposition.

Certainly gnus itself seems to give the filename under
Content-Disposition rather than Content-Type, following rfc2183 if I
read it right.

Fixing this lets normal-mode do the right thing in the new buffer.

	* gnus-art.el (gnus-mime-copy-part): Look for filename
	parameter under content-disposition, not content-type.


[-- Attachment #2: gnus-art.el.copy-part.diff --]
[-- Type: text/plain, Size: 458 bytes --]

--- gnus-art.el.~6.253.~	2002-11-18 06:06:02.000000000 +1000
+++ gnus-art.el	2002-11-18 07:34:34.000000000 +1000
@@ -3878,7 +3878,7 @@
 		    (file-name-nondirectory
 		     (or
 		      (mail-content-type-get (mm-handle-type handle) 'name)
-		      (mail-content-type-get (mm-handle-type handle)
+		      (mail-content-type-get (mm-handle-disposition handle)
 					     'filename)
 		      "*decoded*"))))
 	 (buffer (and base (generate-new-buffer base))))

             reply	other threads:[~2002-11-17 21:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-17 21:41 Kevin Ryde [this message]
2002-11-27  1:52 ` ShengHuo ZHU

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878yzrc1ri.fsf@zip.com.au \
    --to=user42@zip.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).