gnus-mime-copy-part and filename

gnus-mime-copy-part and filename

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

I notice gnus-mime-copy-part (`c' on the button) looks for a filename
parameter from mm-handle-type, but I wonder if that ought to be
mm-handle-disposition.

Certainly gnus itself seems to give the filename under
Content-Disposition rather than Content-Type, following rfc2183 if I
read it right.

Fixing this lets normal-mode do the right thing in the new buffer.

	* gnus-art.el (gnus-mime-copy-part): Look for filename
	parameter under content-disposition, not content-type.


[-- Attachment #2: gnus-art.el.copy-part.diff --]
[-- Type: text/plain, Size: 458 bytes --]

--- gnus-art.el.~6.253.~	2002-11-18 06:06:02.000000000 +1000
+++ gnus-art.el	2002-11-18 07:34:34.000000000 +1000
@@ -3878,7 +3878,7 @@
 		    (file-name-nondirectory
 		     (or
 		      (mail-content-type-get (mm-handle-type handle) 'name)
-		      (mail-content-type-get (mm-handle-type handle)
+		      (mail-content-type-get (mm-handle-disposition handle)
 					     'filename)
 		      "*decoded*"))))
 	 (buffer (and base (generate-new-buffer base))))

Re: gnus-mime-copy-part and filename

[ShengHuo ZHU]

Kevin Ryde <user42@zip.com.au> writes:

> I notice gnus-mime-copy-part (`c' on the button) looks for a filename
> parameter from mm-handle-type, but I wonder if that ought to be
> mm-handle-disposition.
>
> Certainly gnus itself seems to give the filename under
> Content-Disposition rather than Content-Type, following rfc2183 if I
> read it right.
>
> Fixing this lets normal-mode do the right thing in the new buffer.
>
> 	* gnus-art.el (gnus-mime-copy-part): Look for filename
> 	parameter under content-disposition, not content-type.

Installed.

ShengHuo