From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/62285 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: gnus / message-send-mail-with-mailclient [patch] Date: Fri, 17 Mar 2006 07:39:27 +0000 Message-ID: <87CD65F5-250E-4F3E-9987-E61A08905F53@gmail.com> References: <059BF802-B4EB-433E-AF78-024107CD7E16@gmail.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (Apple Message framework v746.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1142581200 23427 80.91.229.2 (17 Mar 2006 07:40:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 17 Mar 2006 07:40:00 +0000 (UTC) Cc: ding@gnus.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 17 08:40:00 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FK9Yq-0001Pu-0g for ged-emacs-devel@m.gmane.org; Fri, 17 Mar 2006 08:39:48 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FK9Yp-0003gf-7G for ged-emacs-devel@m.gmane.org; Fri, 17 Mar 2006 02:39:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FK9YY-0003gA-TK for emacs-devel@gnu.org; Fri, 17 Mar 2006 02:39:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FK9YW-0003fi-SK for emacs-devel@gnu.org; Fri, 17 Mar 2006 02:39:30 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FK9YW-0003fa-NL for emacs-devel@gnu.org; Fri, 17 Mar 2006 02:39:28 -0500 Original-Received: from [66.249.92.204] (helo=uproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FK9dL-00074k-P7 for emacs-devel@gnu.org; Fri, 17 Mar 2006 02:44:28 -0500 Original-Received: by uproxy.gmail.com with SMTP id u2so305894uge for ; Thu, 16 Mar 2006 23:39:27 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer; b=NRsx8jTrXLZiR1RvpMsvcGWF39HJAbqwjDZdu55eltbvHP6siALKLwnCSwZLSj3H5Eo0nGZvCZryBBqwq3vqc33g53hcQlHkvX61fjZYkkWpEBK5NngzCt8XH9rF0KYXZge/MCPxctrZ9FBF9KhK8YjUtQrPtdjlBKtaquMoiPE= Original-Received: by 10.67.19.6 with SMTP id w6mr1782274ugi; Thu, 16 Mar 2006 23:39:26 -0800 (PST) Original-Received: from ?10.0.0.100? ( [82.41.74.89]) by mx.gmail.com with ESMTP id c1sm1415332ugf.2006.03.16.23.39.25; Thu, 16 Mar 2006 23:39:26 -0800 (PST) In-Reply-To: Original-To: Reiner Steib X-Mailer: Apple Mail (2.746.3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:51749 gmane.emacs.gnus.general:62285 Archived-At: On 16 Mar 2006, at 21:27, Reiner Steib wrote: > `message.el' is supposed to work with Emacs 21 as well. Do you know > whether `mailclient.el' works with Emacs 21? I just tried it and it worked fine. (I don't know about the custom- reevaluate-settings business - but that's only needed when autoloaded, i.e. when it comes with the distribution.) >> The patch below fixes the problem analogous to what has been done in >> the `sendmail' package. > > Your patch contains several unrelated changes (make-frame-visible), > wrapped lines and mixed context/unified hunks which makes is hard to > read and to apply. Sorry, the other changes slipped in. > How about the attached patch. It includes some additional checks > (partly taken from `message.el' in the development version of Gnus). Looks good to me, except... > I'm not sure (and I can't test) if > (custom-reevaluate-setting 'message-send-mail-function) > in `startup.el' is necessary. Yes, that is needed because `window-system' is only meaningful at runtime.