Gnus development mailing list
 help / color / mirror / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Sam Steingold <sds@gnu.org>
Cc: ding@gnus.org
Subject: Re: hackernews & gnus-summary-browse-url
Date: Wed, 09 Mar 2022 13:04:29 +0100	[thread overview]
Message-ID: <87a6dz72nm.fsf@gnus.org> (raw)
In-Reply-To: <lzmti0np7i.fsf@3c22fb11fdab.ant.amazon.com> (Sam Steingold's message of "Tue, 08 Mar 2022 15:50:41 -0500")

Sam Steingold <sds@gnu.org> writes:

> If you use it yourself, would you mind if I apply this patch?

[...]

> +  "v" #'gnus-summary-browse-all-urls

I'm not sure that's generally useful enough to have as its own
command -- people will want to open different subsets of URLs in these
cases, and you kinda have to write some code for that.

[...]

> -(defun gnus-summary-browse-url (&optional external)
> +(defun gnus-summary-browse-url (&optional _external)
>    "Scan the current article body for links, and offer to browse them.
>
>  Links are opened using `browse-url' unless a prefix argument is
> -given: Then `browse-url-secondary-browser-function' is used instead.
> +given: then `browse-url-secondary-browser-function' is used instead.

And why are you removing the EXTERNAL logic?



  reply	other threads:[~2022-03-09 12:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07 21:44 Sam Steingold
2022-03-07 23:40 ` Eric Abrahamsen
2022-03-08 15:05   ` Sam Steingold
2022-03-08 15:23     ` Lars Ingebrigtsen
2022-03-08 15:56       ` Eric Abrahamsen
2022-03-08 15:58         ` Lars Ingebrigtsen
2022-03-08 20:50       ` Sam Steingold
2022-03-09 12:04         ` Lars Ingebrigtsen [this message]
2022-03-09 19:41           ` Sam Steingold
2022-03-09 19:50             ` Eric Abrahamsen
2022-03-09 21:20               ` Sam Steingold
2022-03-12 17:38             ` Lars Ingebrigtsen
2022-03-08 16:35     ` dick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6dz72nm.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=ding@gnus.org \
    --cc=sds@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).