From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 2120 invoked from network); 9 Mar 2022 12:04:47 -0000 Received: from mx1.math.uh.edu (129.7.128.32) by inbox.vuxu.org with ESMTPUTF8; 9 Mar 2022 12:04:47 -0000 Received: from lists1.math.uh.edu ([129.7.128.208]) by mx1.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nRv3d-00DZ3J-7A for ml@inbox.vuxu.org; Wed, 09 Mar 2022 06:04:45 -0600 Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.94.2) (envelope-from ) id 1nRv3c-005Nk7-SD for ml@inbox.vuxu.org; Wed, 09 Mar 2022 06:04:44 -0600 Received: from mx2.math.uh.edu ([129.7.128.33]) by lists1.math.uh.edu with esmtp (Exim 4.94.2) (envelope-from ) id 1nRv3a-005Njy-G7 for ding@lists.math.uh.edu; Wed, 09 Mar 2022 06:04:42 -0600 Received: from quimby.gnus.org ([95.216.78.240]) by mx2.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nRv3W-0029Mm-DZ for ding@lists.math.uh.edu; Wed, 09 Mar 2022 06:04:42 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PUcx0VEZ5dZ9M3rIH/Bl/Q8cSTKFp6NeZthrrBNG8bQ=; b=MfNcApaSmONsZgCue1Half/lfo FhTQlxBSstXAv+D8saxktcHZdG6kHusJFSNc+MZpTVqP7MPw8Zf7mMxeNpA8ZVd5cBkvgtWXxM8ye fACf3ytZMRFgd0dQ0+PFZaIvvQ4+o4v0Y8INKBoWwfigaiAbJAbba1w/0ZSKzt9uuSRw=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nRv3P-000762-6u; Wed, 09 Mar 2022 13:04:33 +0100 From: Lars Ingebrigtsen To: Sam Steingold Cc: ding@gnus.org Subject: Re: hackernews & gnus-summary-browse-url References: <87k0d5xrf4.fsf@ericabrahamsen.net> <87zgm079ip.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEWTakWLkExqi2Nc hoJbZWF2mDx0XjacVDa+OS7SWzfaaEvllUL////FmuvDAAAAAWJLR0QMgbNRYwAAAAd0SU1FB+YD CQwDDvPu4MUAAAGQSURBVDjLlZFBboNADEXdRYPUHZE4QAknCD1BwgUaafZZVGTLqg65QOgJynCC zhyhXK72eIABkUW/hAT/je3vAcDpKd6mrH1aeIkPcZywv8v3aT4Hio4eikOaZkFFTOcV6V2psVNB 3Uclp3QdKAJpdhxajSShQSyZDuVZpjidHNm9OVCWAM++RkpcMgYk6aeUlHAGD9wk5QscAe4E9MSv 3spzWn+fsQcSbTuB4ljAOQgcD41oOmAV7ug8hyCCUJTjw+2XAQ6CqIo+JSOzCZAqQLL9XV3YaUgD 9L3cgjiTX7n0oskRuRv52kxgLtoOca0RdfDfjW6bthlF6S+SSXvx+x1Ra7i6F+T39ssTrFHDme+E QlCmq5zGWmtr5Z+PogXJZPHw0X6xk6Bix9iFjF6cG3wCCHZVoLsHwNj/VjwAejG6k6ykOdC685fZ robluwRraqq/LTekCoO6/kaCWprLKDejH+oDddCLfgV2tjNW0/+0c+AH4P02gr4PSW0DMNTIHzTL VjTWoZ8QGMnDvun+AJ1S4H6FTqoDAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTAzLTA5VDEyOjAz OjE0KzAwOjAwcmDstgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wMy0wOVQxMjowMzoxNCswMDow MAM9VAoAAAAASUVORK5CYII= X-Now-Playing: A Certain Ratio's _Sextet_: "Skipscada" Date: Wed, 09 Mar 2022 13:04:29 +0100 In-Reply-To: (Sam Steingold's message of "Tue, 08 Mar 2022 15:50:41 -0500") Message-ID: <87a6dz72nm.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain List-ID: Precedence: bulk Sam Steingold writes: > If you use it yourself, would you mind if I apply this patch? [...] > + "v" #'gnus-summary-browse-all-urls I'm not sure that's generally useful enough to have as its own command -- people will want to open different subsets of URLs in these cases, and you kinda have to write some code for that. [...] > -(defun gnus-summary-browse-url (&optional external) > +(defun gnus-summary-browse-url (&optional _external) > "Scan the current article body for links, and offer to browse them. > > Links are opened using `browse-url' unless a prefix argument is > -given: Then `browse-url-secondary-browser-function' is used instead. > +given: then `browse-url-secondary-browser-function' is used instead. And why are you removing the EXTERNAL logic?