From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 32240 invoked from network); 6 Jun 2020 09:22:43 -0000 Received: from lists1.math.uh.edu (129.7.128.208) by inbox.vuxu.org with ESMTPUTF8; 6 Jun 2020 09:22:43 -0000 Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.92.3) (envelope-from ) id 1jhV1e-00067R-TN; Sat, 06 Jun 2020 04:22:02 -0500 Received: from mx1.math.uh.edu ([129.7.128.32]) by lists1.math.uh.edu with esmtps (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1jhV1b-00064g-99 for ding@lists.math.uh.edu; Sat, 06 Jun 2020 04:21:59 -0500 Received: from quimby.gnus.org ([95.216.78.240]) by mx1.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jhV1K-005rgF-Q8 for ding@lists.math.uh.edu; Sat, 06 Jun 2020 04:21:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZpXwQ/l4U4aB0Ohols9B17STbooBagEWOYNZacbxYQ8=; b=QAahjvfdn+GoaZhV+m/ZP+y8Gq y+6Yf7JEtHGNj6Vx9dQKPept1llokX19i16ae6oV5Betv8VR4uj4B6A8AtJmbhgMPekOPedD3vVPk OWocuy2JPtgZ0TpKO1A2tRQB94YlUv3jnT52cd8MYhTMP0ku5yF8etarPuDxwLDoUPw0=; Received: from eggs.gnu.org ([2001:470:142:3::10]) by quimby.gnus.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhV1D-0006DF-Ok for ding@gnus.org; Sat, 06 Jun 2020 11:21:38 +0200 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58339) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhV19-00028G-Mx for ding@gnus.org; Sat, 06 Jun 2020 05:21:31 -0400 Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:50529) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1jhV19-0002EI-GQ for ding@gnus.org; Sat, 06 Jun 2020 05:21:31 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 1C83127C0054 for ; Sat, 6 Jun 2020 05:21:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sat, 06 Jun 2020 05:21:31 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeghedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkfgggtgesthdtredttd ertdenucfhrhhomhepvfgrshhsihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhg qeenucggtffrrghtthgvrhhnpeetvdfgfedvhfeiffeuledvvdffuddvtefhjeekheelhf ehudetheelteejtedtheenucfkphepleefrddvfeeirddufeefrdduudenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnodhmvghsmh htphgruhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedvleekqdht shguhheppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Received: from thinkpad-t440p (p5dec850b.dip0.t-ipconnect.de [93.236.133.11]) by mail.messagingengine.com (Postfix) with ESMTPA id 7975B328005A for ; Sat, 6 Jun 2020 05:21:30 -0400 (EDT) From: Tassilo Horn To: ding@gnus.org Subject: nnir-summary-line-format doesn't work Date: Sat, 06 Jun 2020 11:21:29 +0200 Message-ID: <87a71gsg6e.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain List-ID: Precedence: bulk Hi all, it seems like `nnir-summary-line-format' doesn't work in the current Emacs master (and probably hasn't worked for ages). It gets set as `gnus-summary-line-format' in `nnir-mode' which is called in `gnus-summary-prepared-hook'. However, at that point, the summary buffer is already built using the original `gnus-summary-line-format' value. The patch below fixes this problem. Could someone with a bit more Gnus knowledge have a look at it and tell me if IDRT? --8<---------------cut here---------------start------------->8--- 1 file changed, 7 insertions(+), 2 deletions(-) lisp/gnus/nnir.el | 9 +++++++-- modified lisp/gnus/nnir.el @@ -663,6 +663,7 @@ nnir-open-server (let ((backend (car (gnus-server-to-method server)))) (if backend (nnoo-change-server backend server definitions) + (add-hook 'gnus-summary-generate-hook 'nnir-summary-generate-setup) (add-hook 'gnus-summary-prepared-hook 'nnir-mode) (nnoo-change-server 'nnir server definitions)))) @@ -1848,10 +1849,14 @@ nnir-registry-action to method)) +(defun nnir-summary-generate-setup () + (when (and (eq (car (gnus-find-method-for-group gnus-newsgroup-name)) 'nnir) + nnir-summary-line-format) + (setq gnus-summary-line-format nnir-summary-line-format) + (gnus-update-format-specifications nil 'summary))) + (defun nnir-mode () (when (eq (car (gnus-find-method-for-group gnus-newsgroup-name)) 'nnir) - (setq gnus-summary-line-format - (or nnir-summary-line-format gnus-summary-line-format)) (when (bound-and-true-p gnus-registry-enabled) (remove-hook 'gnus-summary-article-delete-hook 'gnus-registry-action t) (remove-hook 'gnus-summary-article-move-hook 'gnus-registry-action t) --8<---------------cut here---------------end--------------->8--- Bye, Tassilo