Re: Indicate partial articles (nnimap-fetch-partial-articles)

[Tassilo Horn <tassilo@member.fsf.org>]

Julien Danjou <julien@danjou.info> writes:

Hi Julien,

>> Looking at `nnimap-request-article', it shouldn't be to hard to
>> detect when a part was skipped, so one could simply append a line
>>
>>     [This is a partial article.]
>>
>> at the end of it, or am I wrong?
>
> Possibly, did not check that. It seems quite useless to me to know
> it's a partial article if there's no way to have its missing parts
> downloaded. :-)

That would be true, but you can fetch the complete article with `A C'.

I've just experimented a bit.  When I change nnimap.el a bit like
that...

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/nnimap.el b/lisp/nnimap.el
index acbb091..011a51a 100644
--- a/lisp/nnimap.el
+++ b/lisp/nnimap.el
@@ -458,6 +458,11 @@ textual parts.")
 (deffoo nnimap-status-message (&optional server)
   nnimap-status-string)
 
+(defun nnimap-part-count (structure)
+  (if (atom (car structure))
+      0
+    (1+ (nnimap-part-count (cdr structure)))))
+
 (deffoo nnimap-request-article (article &optional group server to-buffer)
   (with-current-buffer nntp-server-buffer
     (let ((result (nnimap-possibly-change-group group server))
@@ -487,6 +492,10 @@ textual parts.")
              (with-current-buffer (or to-buffer nntp-server-buffer)
                (erase-buffer)
                (insert-buffer-substring buffer)
+               (message "%d / %d" (nnimap-part-count structure) (length parts))
+               (when (> (nnimap-part-count structure) (length parts))
+                 (message "INCOMPLETE!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!")
+                 (insert "[This is a partial article.]"))
                (nnheader-ms-strip-cr)
                (cons group article)))))))))
--8<---------------cut here---------------end--------------->8---

...then the INCOMPLETE! message is sometimes shown without the [partial
article] visible in the message...  And even though I have
nnimap-fetch-partial-articles set to "text/", also application/pdf parts
and other parts are included in several messages.

Is it possible that the imap server I used for testing doesn't support
partial article downloads?

Bye,
Tassilo