Re: Garbled display of UTF-8 encoded mails

[Sven Joachim <svenjoac@gmx.de>]

Seems I found a solution. :-)

On 2010-11-23 22:03 +0100, Sven Joachim wrote:

> I bisected the problem and found out that commit bda3e8962a is the
> culprit:
>
> commit bda3e8962af0aee90144c3ae8c5360aa4c106d94
> Author: Katsumi Yamaoka <yamaoka@jpl.org>
> Date:   Fri May 7 06:34:41 2010 +0000
> [...]
>     * mm-util.el (mm-enable-multibyte, mm-disable-multibyte): Use (featurep
>     'xemacs) instead of mm-emacs-mule to switch function definitions.

The diff hunk that corresponds to this sentence is the following:

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/mm-util.el b/lisp/mm-util.el
index c1dc4f5..a288b8b 100644
--- a/lisp/mm-util.el
+++ b/lisp/mm-util.el
@@ -908,20 +908,20 @@ mail with multiple parts is preferred to sending a Unicode one.")
 			     (fboundp 'set-buffer-multibyte))
     "True in Emacs with Mule.")
 
-  (if mm-emacs-mule
-      (defun mm-enable-multibyte ()
-	"Set the multibyte flag of the current buffer.
+  (if (featurep 'xemacs)
+      (defalias 'mm-enable-multibyte 'ignore)
+    (defun mm-enable-multibyte ()
+      "Set the multibyte flag of the current buffer.
 Only do this if the default value of `enable-multibyte-characters' is
 non-nil.  This is a no-op in XEmacs."
-	(set-buffer-multibyte 'to))
-    (defalias 'mm-enable-multibyte 'ignore))
+      (set-buffer-multibyte t)))
 
-  (if mm-emacs-mule
-      (defun mm-disable-multibyte ()
-	"Unset the multibyte flag of in the current buffer.
+  (if (featurep 'xemacs)
+      (defalias 'mm-disable-multibyte 'ignore)
+    (defun mm-disable-multibyte ()
+      "Unset the multibyte flag of in the current buffer.
 This is a no-op in XEmacs."
-	(set-buffer-multibyte nil))
-    (defalias 'mm-disable-multibyte 'ignore)))
+      (set-buffer-multibyte nil))))
 
 (defun mm-preferred-coding-system (charset)
   ;; A typo in some Emacs versions.
--8<---------------cut here---------------end--------------->8---

However, this contains a change in semantics that is not mentioned and
might have been unintended.  The old version of mm-enable-multibyte for
Emacs was (set-buffer-multibyte 'to), whereas the new one is
(set-buffer-multibyte t), and this seems to be what causes all my
problems.  Reverting the change in master:

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/mm-util.el b/lisp/mm-util.el
index 67b41e0..700c1a6 100644
--- a/lisp/mm-util.el
+++ b/lisp/mm-util.el
@@ -903,7 +903,7 @@ mail with multiple parts is preferred to sending a Unicode one.")
       "Set the multibyte flag of the current buffer.
 Only do this if the default value of `enable-multibyte-characters' is
 non-nil.  This is a no-op in XEmacs."
-      (set-buffer-multibyte t)))
+      (set-buffer-multibyte 'to)))
 
   (if (featurep 'xemacs)
       (defalias 'mm-disable-multibyte 'ignore)
--8<---------------cut here---------------end--------------->8---

solves the issue for me.

Cheers,
       Sven