* Re: fix for time-date.el [not found] <87abam99gx.fsf@liv.ac.uk> @ 2008-12-23 16:41 ` Reiner Steib 2008-12-29 21:07 ` Dave Love 0 siblings, 1 reply; 7+ messages in thread From: Reiner Steib @ 2008-12-23 16:41 UTC (permalink / raw) To: Dave Love, ding; +Cc: bugs On Tue, Dec 23 2008, Dave Love wrote: > CL is needed for `declare'. Also note the undefined function -- what is > that? Did you test with Emacs 21? In Emacs 22 and up, declare is a Lisp macro in `subr.el', assoc-string is a built-in function in `src/minibuf.c'. `format-seconds' (where `assoc-string' is used) is not used anywhere in Gnus so it's not a real problem, AFAICS. (time-date.el is use in other parts of Emacs.) > 2008-12-23 Dave Love <fx@gnu.org> > > * time-date.el (cl): Require when compiling. > > Index: time-date.el > =================================================================== > RCS file: /usr/local/cvsroot/gnus/lisp/time-date.el,v > retrieving revision 7.16 > diff -u -F^( -r7.16 time-date.el > --- time-date.el 19 May 2008 08:47:42 -0000 7.16 > +++ time-date.el 23 Dec 2008 15:45:55 -0000 > @@ -39,6 +39,8 @@ > > ;;; Code: > > +(eval-when-compile (require 'cl)) > + > (defmacro with-decoded-time-value (varlist &rest body) > "Decode a time value and bind it according to VARLIST, then eval BODY. > > @@ -290,6 +292,7 @@ (defun format-seconds (string seconds) > (setq start (match-end 0) > spec (match-string 1 string)) > (unless (string-equal spec "%") > + ;; Fixme: assoc-string not defined. > (or (setq match (assoc-string spec units t)) > (error "Bad format specifier: `%s'" spec)) > (if (assoc-string spec usedunits t) Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: fix for time-date.el 2008-12-23 16:41 ` fix for time-date.el Reiner Steib @ 2008-12-29 21:07 ` Dave Love 2009-01-05 16:09 ` Emacsen supported (was: fix for time-date.el) Dave Love 2009-01-05 20:41 ` fix for time-date.el Reiner Steib 0 siblings, 2 replies; 7+ messages in thread From: Dave Love @ 2008-12-29 21:07 UTC (permalink / raw) To: ding Reiner Steib <reinersteib+gmane@imap.cc> writes: > Did you test with Emacs 21? Yes. I thought it was supposed still to be supported -- that's what the gnus-coding Info file says. > In Emacs 22 and up, declare is a Lisp > macro in `subr.el', assoc-string is a built-in function in > `src/minibuf.c'. *Sigh*. It's been in CL for a very long time... There's a distressing amount of that sort of thing in 22. > `format-seconds' (where `assoc-string' is used) is not used anywhere > in Gnus so it's not a real problem, AFAICS. Fortunately the function where it's used seems to be new; otherwise it would be a problem. It seems to me to merit a comment at least. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Emacsen supported (was: fix for time-date.el) 2008-12-29 21:07 ` Dave Love @ 2009-01-05 16:09 ` Dave Love 2009-01-05 19:17 ` Emacsen supported Steinar Bang 2009-01-05 20:48 ` Reiner Steib 2009-01-05 20:41 ` fix for time-date.el Reiner Steib 1 sibling, 2 replies; 7+ messages in thread From: Dave Love @ 2009-01-05 16:09 UTC (permalink / raw) To: ding I wrote: > Reiner Steib <reinersteib+gmane@imap.cc> writes: > >> Did you test with Emacs 21? > > Yes. I thought it was supposed still to be supported -- that's what the > gnus-coding Info file says. Could someone tell me whether it is still supposed to be supported to avoid me wasting time on Emacs 21 support, like a different fix for this inconsistent `declare' if requiring cl isn't acceptable? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Emacsen supported 2009-01-05 16:09 ` Emacsen supported (was: fix for time-date.el) Dave Love @ 2009-01-05 19:17 ` Steinar Bang 2009-01-05 20:48 ` Reiner Steib 1 sibling, 0 replies; 7+ messages in thread From: Steinar Bang @ 2009-01-05 19:17 UTC (permalink / raw) To: ding >>>>> Dave Love <d.love@liverpool.ac.uk>: > I wrote: >> Reiner Steib <reinersteib+gmane@imap.cc> writes: >>> Did you test with Emacs 21? >> Yes. I thought it was supposed still to be supported -- that's what >> the gnus-coding Info file says. > Could someone tell me whether it is still supposed to be supported to > avoid me wasting time on Emacs 21 support, like a different fix for > this inconsistent `declare' if requiring cl isn't acceptable? FWIW one of my Gnusen runs on a debian stable machine. Stable is currently etch, and emacs21 is the newest GNU emacs on it. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Emacsen supported 2009-01-05 16:09 ` Emacsen supported (was: fix for time-date.el) Dave Love 2009-01-05 19:17 ` Emacsen supported Steinar Bang @ 2009-01-05 20:48 ` Reiner Steib 2009-01-05 23:27 ` Dave Love 1 sibling, 1 reply; 7+ messages in thread From: Reiner Steib @ 2009-01-05 20:48 UTC (permalink / raw) To: Dave Love; +Cc: ding On Mon, Jan 05 2009, Dave Love wrote: > I wrote: >> Reiner Steib <reinersteib+gmane@imap.cc> writes: >>> Did you test with Emacs 21? >> Yes. I thought it was supposed still to be supported -- that's what the >> gnus-coding Info file says. > > Could someone tell me I though I already responded, but the message was still in my drafts folder. Sorry. > whether it is still supposed to be supported to avoid me wasting > time on Emacs 21 support, Yes, it is supposed to be supported. I don't test with Emacs 21 (nor XEmacs) though. The major reason not to drop support for Emacs 21 is that we won't gain much because often the same code is necessary for XEmacs 21.4 (and 21.5). > like a different fix for this inconsistent `declare' if requiring cl > isn't acceptable? I've committed this: ;; Only necessary for `declare' when compiling Gnus with Emacs 21. (eval-when-compile (require 'cl)) Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Emacsen supported 2009-01-05 20:48 ` Reiner Steib @ 2009-01-05 23:27 ` Dave Love 0 siblings, 0 replies; 7+ messages in thread From: Dave Love @ 2009-01-05 23:27 UTC (permalink / raw) To: ding Reiner Steib <reinersteib+gmane@imap.cc> writes: > Yes, it is supposed to be supported. I don't test with Emacs 21 (nor > XEmacs) though. The major reason not to drop support for Emacs 21 is > that we won't gain much because often the same code is necessary for > XEmacs 21.4 (and 21.5). I'm rather surprised. Emacs 22 has sadly broken a lot of stuff, but I doubt it's as far from Emacs 21 as XEmacs is. The most important difference is that XEmacs doesn't have the m17n facilities to cope with MIME properly, or certainly didn't when I maintained Gnus, and not a lot appears to have changed. A better reason to support Emacs 21 seems to be that it's in currently supported OSes, especially versions of GNU/Linux. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: fix for time-date.el 2008-12-29 21:07 ` Dave Love 2009-01-05 16:09 ` Emacsen supported (was: fix for time-date.el) Dave Love @ 2009-01-05 20:41 ` Reiner Steib 1 sibling, 0 replies; 7+ messages in thread From: Reiner Steib @ 2009-01-05 20:41 UTC (permalink / raw) To: Dave Love; +Cc: ding On Mon, Dec 29 2008, Dave Love wrote: > Reiner Steib <reinersteib+gmane@imap.cc> writes: >> Did you test with Emacs 21? > > Yes. I thought it was supposed still to be supported -- that's what the > gnus-coding Info file says. Yes, it is supposed to be supported. I don't test with Emacs 21 (nor XEmacs) though. BTW, the major reason not to drop support for Emacs 21 is that we won't gain much because often the same code is necessary for XEmacs 21.4 (and 21.5). >> In Emacs 22 and up, declare is a Lisp macro in `subr.el', >> assoc-string is a built-in function in `src/minibuf.c'. > > *Sigh*. It's been in CL for a very long time... There's a distressing > amount of that sort of thing in 22. IIRC, several useful functions have been moved from CL to Emacs core. (Maybe after this discussion: <http://thread.gmane.org/gmane.emacs.devel/78898/focus=78981>) >> `format-seconds' (where `assoc-string' is used) is not used anywhere >> in Gnus so it's not a real problem, AFAICS. > > Fortunately the function where it's used seems to be new; otherwise it > would be a problem. It seems to me to merit a comment at least. I've added a comment in `format-seconds' and (eval-when-compile (require 'cl)) along with a comment. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-01-05 23:27 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <87abam99gx.fsf@liv.ac.uk> 2008-12-23 16:41 ` fix for time-date.el Reiner Steib 2008-12-29 21:07 ` Dave Love 2009-01-05 16:09 ` Emacsen supported (was: fix for time-date.el) Dave Love 2009-01-05 19:17 ` Emacsen supported Steinar Bang 2009-01-05 20:48 ` Reiner Steib 2009-01-05 23:27 ` Dave Love 2009-01-05 20:41 ` fix for time-date.el Reiner Steib
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).