Gnus development mailing list
 help / color / mirror / Atom feed
From: Nils Ackermann <nils@ackermath.info>
To: ding@gnus.org
Subject: Re: drafts and expiry-target problem and solution
Date: Tue, 18 Mar 2008 18:27:49 -0600	[thread overview]
Message-ID: <87abkv4kxm.fsf@aphrodite.localdomain> (raw)
In-Reply-To: <b4mhcf4jir6.fsf@jpl.org>

Katsumi Yamaoka <yamaoka@jpl.org> writes:

>>>>>> Nils Ackermann wrote:
>> I like to archive all incoming and all outgoing email in the same nnml
>> archive folder.  Therefore I set `total-expire' in the group
>> parameters globally (via topics), and I set `nnmail-expiry-target' and
>> `gnus-message-archive-group' to the same group, globally.
>
>> In the drafts group a problem appears: message mode uses the internal
>> expiry function `nnmh-request-expire-articles' from nnmh.el to delete
>> the message, immediately.  If `nnmail-expiry-target' is set to a
>> folder, the email is not deleted but moved to this folder instead.
>
>> Of course, since the values of `nnmail-expiry-target' and
>> `gnus-message-archive-group' coincide, gnus tries to save the message
>> in this folder twice, but gives an error, I don't know why.  I think
>> it should succeed without an error, and warn about it (with variable
>> to turn the warning off).  This is one bug.
>
> But doesn't your patch to message.el solve it?  Although I tried
> modifying the `nnml-open-nov' function as follows, before applying
> your patch, it is unnecessary, isn't it?

You're right, with respect to this bug it would probably be enough to
call `message-disassociate-draft' with the full group specification.
On second thought it appears to me that `message-disassociate-draft'
shouldn't rely on `nnmh-request-expire-articles' to delete the mail
from the drafts group.  It should just delete it.  Is there any deep
reason for this choice?

[snip]

>> The second bug is that setting the group parameter `expiry-target' for
>> the drafts group to 'delete doesn't change anything.  This clearly
>> contradicts the manual, where it is stated that group parameters
>> override global settings.  (By the way, in my real setup the parameter
>> is set via the groups buffer, and not via the variable, but the result
>> is the same.)  The reason is that `nnmh-request-expire-articles' does
>> not honor the group parameter `expiry-target' at all.

[snip]

>> A quick grep through source (by parameter names) showed that there are
>> many places where (general) group parameters aren't honored, even if
>> they should be.  Potentially this gives rise to a lot of bugs that
>> seem unrelated.  Probably there are also more places where the full
>> group specification is missing in using `gnus-group-find-parameter'.

This seems much more serious to me.  I am considering helping to
rectify this.  Please instruct me about signing the papers.

Regards,
Nils

-- 
Info: http://www.ackermath.info/




  parent reply	other threads:[~2008-03-19  0:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87r6eevweh.fsf@pascal.matem.unam.mx>
2008-03-18 12:53 ` Katsumi Yamaoka
2008-03-18 18:37   ` Reiner Steib
2008-03-18 22:59     ` Katsumi Yamaoka
2008-03-19  0:27   ` Nils Ackermann [this message]
2008-03-19  5:33     ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87abkv4kxm.fsf@aphrodite.localdomain \
    --to=nils@ackermath.info \
    --cc=ding@gnus.org \
    --cc=nils-dated-1213237429.39274f@ackermath.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).