Re: gnus-subscribe-topics doesn't seem to work (fixed, kind of)

[Dmitry Yaitskov <dimas@home.com>]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Groъjohann) wrote:

> Can you show us the exact expression you use to set
> gnus-subscribe-newsgroup-method?  And what does `G p' on an example
> topic show?  And which newsgroup do you expect to go into that topic?
> 
> Maybe there is something wrong in the details.

I digged into that a bit, and found out why my setup did not work -
there were 2 unrelated places broken really:

First, although I did have

(setq gnus-subscribe-newsgroup-method 'gnus-subscribe-topics)

in my .gnus.el, I saw that gnus-subscribe-topics never got called. It
turned out that gnus-group-find-new-groups (what is bound to F in the
group buffer) eventually invoked gnus-ask-server-for-new-groups - and
that method calls gnus-subscribe-options-newsgroup-method and not
gnus-subscribe-newsgroup-method, to subscribe to new groups. I do not
understand the logic behind this stuff, so cannot really say what
should be the correct fix - but the way it is seems broken to me.

After I replaced the call to gnus-subscribe-options-newsgroup-method
with the call to gnus-subscribe-newsgroup-method in
gnus-group-find-new-groups, finally the gnus-subscribe-topics was
called - and produced a lisp error. This was because it calls
string-match with a list containing the match string rather than with
the car of that list. The fix for this follows (but I'm not sure
whether car-safe is available in FSF Emacs - I'm using XEmacs):

--------------------------- cut here ---------------------------
Index: gnus-topic.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-topic.el,v
retrieving revision 6.9
diff -u -r6.9 gnus-topic.el
--- gnus-topic.el       2001/02/21 20:28:20     6.9
+++ gnus-topic.el       2001/03/15 23:22:09
@@ -1660,8 +1660,8 @@
   (catch 'end
     (let (match gnus-group-change-level-function)
       (dolist (topic (gnus-topic-list))
-       (when (and (setq match (cdr (assq 'subscribe
-                                         (gnus-topic-parameters topic))))
+       (when (and (setq match (car-safe (cdr (assq 'subscribe
+                                         (gnus-topic-parameters topic)))))
                   (string-match match newsgroup))
          ;; Just subscribe the group.
          (gnus-subscribe-alphabetically newsgroup)
--------------------------- cut here ---------------------------

With these two fixes, it all now seems to work.

> kai

-- 
Cheers,
-Dima.