From: "Łukasz Stelmach" <stlman@poczta.fm>
To: ding@gnus.org
Subject: Re: [BUG] mml2015-epg-find-usable-key finds unusable key
Date: Sat, 16 Feb 2013 19:35:40 +0100 [thread overview]
Message-ID: <87bobk85tv.fsf%stlman@poczta.fm> (raw)
In-Reply-To: <m3mwv6z0g8.fsf-ueno@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1893 bytes --]
Daiki Ueno <ueno@gnu.org> writes:
> Łukasz Stelmach <stlman@poczta.fm> writes:
>
>> It looks like there is a sort of bug in mml2015-epg-encrypt at line
>> 1117.
>>
>> http://git.gnus.org/cgit/gnus.git/tree/lisp/mml2015.el?id=6e422932976e94d6dbb7ad602c5be3eb481fe46c#n1117)
>>
>> The whole form that begins at line 1113 converts list of recipients
>> provided as email addresses, key IDs or anything gpg can digest into epg
>> "objects". Unfortunately there is one corner case that makes this code
>> fail. That is when a key is valid but a uid on it has been revoked.
>
> Thanks for the report.
>
>> epg.el is a part of emacs, mml2015.el belongs to gnus. IMHO it is
>> mml2015-epg-find-usable-key that should be fixed. The function should
>> accept and additional (optional?) parameter with a recipient uid as
>> passed to epg-list-keys and reject keys with all uids matching the
>> recipient parameter revoked.
>
> Sounds reasonable. I plan to apply the attached patch.
The patch needed a fix: there was a space before tab and my name for the
changelog has been messed up (maybe due to encoding issues?).
See the first attachment.
There are two more issues:
1. mml2015-find-usable-key is called from
mml2015-epg-find-usable-secret-key. Your patch hasn't changed the
invocation.
See the second attachment.
2. IMHO mml2015-epg-check-user-id should return true if a key id is
passed as a uid to check. I assume that if a caller passes id to
mml2015-find-usable-key find
See the third attachment.
All atachments has been generated with git-format-patch and are ready to
apply with git-am onto 98f5834.
I've got some more patches for mml2015-epg-* but let's concentrate on the
revoked uid handling.
PS. It looks like this massage originally hasn't made it to the group
(because of attachments?)
--
Miłego dnia,
Łukasz Stelmach
[-- Attachment #2: Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2013-02-16 18:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 19:55 Łukasz Stelmach
2013-02-14 19:28 ` Łukasz Stelmach
2013-02-15 4:05 ` Daiki Ueno
2013-02-15 7:59 ` Łukasz Stelmach
2013-02-15 9:14 ` Daiki Ueno
2013-02-16 18:35 ` Łukasz Stelmach [this message]
2013-02-16 21:11 ` Łukasz Stelmach
2013-02-17 3:12 ` Daiki Ueno
2013-02-17 7:47 ` Łukasz Stelmach
2013-02-17 9:02 ` Daiki Ueno
2013-02-17 10:20 ` Daiki Ueno
2013-02-17 21:29 ` Łukasz Stelmach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bobk85tv.fsf%stlman@poczta.fm \
--to=stlman@poczta.fm \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).