Gnus development mailing list
 help / color / mirror / Atom feed
* still asked later after gnus-summary-exit-no-update
@ 2011-11-21 18:32 jidanni
  2011-11-29  5:42 ` Dan Christensen
  2012-01-03 22:24 ` Lars Magne Ingebrigtsen
  0 siblings, 2 replies; 17+ messages in thread
From: jidanni @ 2011-11-21 18:32 UTC (permalink / raw)
  To: ding

Let's say we exit a group with
Q runs the command gnus-summary-exit-no-update
Well, later when we use
q runs the command gnus-group-exit
we are still asked
Update summary buffer *Summary ...*? (y, n, !, ., q, or C-h)

(By the way, I had to use emacs -nw in order to copy the last line
above into this message with the mouse... it is not in C-h e...)



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: still asked later after gnus-summary-exit-no-update
  2011-11-21 18:32 still asked later after gnus-summary-exit-no-update jidanni
@ 2011-11-29  5:42 ` Dan Christensen
  2012-01-03 22:24 ` Lars Magne Ingebrigtsen
  1 sibling, 0 replies; 17+ messages in thread
From: Dan Christensen @ 2011-11-29  5:42 UTC (permalink / raw)
  To: ding

jidanni@jidanni.org writes:

> Let's say we exit a group with
> Q runs the command gnus-summary-exit-no-update
> Well, later when we use
> q runs the command gnus-group-exit
> we are still asked
> Update summary buffer *Summary ...*? (y, n, !, ., q, or C-h)

This is probably related to something I've noticed.  If I use `Q' to
exit a group (which I do when I fear I've messed something up) and then
reenter the group, I find myself in the old *Summary* buffer with my
mistakes ready to be saved if I hit `q'.  I believe that not long ago,
if I hit `Q', the *Summary* buffer was destroyed, or at least marked
in some way to prevent it being reused.

Any chance we could have the old behaviour back?

Dan




^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: still asked later after gnus-summary-exit-no-update
  2011-11-21 18:32 still asked later after gnus-summary-exit-no-update jidanni
  2011-11-29  5:42 ` Dan Christensen
@ 2012-01-03 22:24 ` Lars Magne Ingebrigtsen
  2012-01-05 14:01   ` jidanni
  2012-01-05 16:03   ` Dan Christensen
  1 sibling, 2 replies; 17+ messages in thread
From: Lars Magne Ingebrigtsen @ 2012-01-03 22:24 UTC (permalink / raw)
  To: jidanni; +Cc: ding

jidanni@jidanni.org writes:

> Let's say we exit a group with
> Q runs the command gnus-summary-exit-no-update
> Well, later when we use
> q runs the command gnus-group-exit
> we are still asked
> Update summary buffer *Summary ...*? (y, n, !, ., q, or C-h)

Doesn't `Q' delete the summary buffer for you?  It does for me.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: still asked later after gnus-summary-exit-no-update
  2012-01-03 22:24 ` Lars Magne Ingebrigtsen
@ 2012-01-05 14:01   ` jidanni
  2012-01-06 20:47     ` Lars Magne Ingebrigtsen
  2012-01-05 16:03   ` Dan Christensen
  1 sibling, 1 reply; 17+ messages in thread
From: jidanni @ 2012-01-05 14:01 UTC (permalink / raw)
  To: larsi; +Cc: ding

>>>>> "LMI" == Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
LMI> jidanni@jidanni.org writes:

>> Let's say we exit a group with
>> Q runs the command gnus-summary-exit-no-update
>> Well, later when we use
>> q runs the command gnus-group-exit
>> we are still asked
>> Update summary buffer *Summary ...*? (y, n, !, ., q, or C-h)

LMI> Doesn't `Q' delete the summary buffer for you?  It does for me.

Here's the exact sequence typed while reading this message in
gmane.emacs.gnus.general:
Q y C-x s q y C-g C-h l

No files need to be saved when asked with C-x s.

However when we want to quit gnus altogether, we are asked!

(However I always use my http://jidanni.org/comp/configuration/ ...)



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: still asked later after gnus-summary-exit-no-update
  2012-01-03 22:24 ` Lars Magne Ingebrigtsen
  2012-01-05 14:01   ` jidanni
@ 2012-01-05 16:03   ` Dan Christensen
  2012-01-06 20:46     ` Lars Magne Ingebrigtsen
  1 sibling, 1 reply; 17+ messages in thread
From: Dan Christensen @ 2012-01-05 16:03 UTC (permalink / raw)
  To: ding

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Doesn't `Q' delete the summary buffer for you?  It does for me.

I just updated to latest git gnus (55c26cf1a993...) and when I hit
`Q y', the summary buffer is not killed.  I had hoped that this commit

commit 250de0bb9c335dca2bb226fa9572465273009425
Author: Andrew Cohen <cohen@andy.bu.edu>
Date:   Mon Sep 5 12:07:19 2011 -0400

    * gnus-sum.el (gnus-summary-exit): Ensure we kill the proper
        original-article-buffer.

would fix it, but it doesn't.

Dan




^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: still asked later after gnus-summary-exit-no-update
  2012-01-05 16:03   ` Dan Christensen
@ 2012-01-06 20:46     ` Lars Magne Ingebrigtsen
  2012-01-08 17:34       ` Dan Christensen
  0 siblings, 1 reply; 17+ messages in thread
From: Lars Magne Ingebrigtsen @ 2012-01-06 20:46 UTC (permalink / raw)
  To: ding

Dan Christensen <jdc@uwo.ca> writes:

> I just updated to latest git gnus (55c26cf1a993...) and when I hit
> `Q y', the summary buffer is not killed. 

Do you have `gnus-kill-summary-on-exit' unset?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: still asked later after gnus-summary-exit-no-update
  2012-01-05 14:01   ` jidanni
@ 2012-01-06 20:47     ` Lars Magne Ingebrigtsen
  2012-01-06 23:15       ` jidanni
  0 siblings, 1 reply; 17+ messages in thread
From: Lars Magne Ingebrigtsen @ 2012-01-06 20:47 UTC (permalink / raw)
  To: jidanni; +Cc: ding

jidanni@jidanni.org writes:

> LMI> Doesn't `Q' delete the summary buffer for you?  It does for me.
>
> Here's the exact sequence typed while reading this message in
> gmane.emacs.gnus.general:
> Q y C-x s q y C-g C-h l

But what's the answer to the question?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: still asked later after gnus-summary-exit-no-update
  2012-01-06 20:47     ` Lars Magne Ingebrigtsen
@ 2012-01-06 23:15       ` jidanni
  0 siblings, 0 replies; 17+ messages in thread
From: jidanni @ 2012-01-06 23:15 UTC (permalink / raw)
  To: larsi; +Cc: ding

>>>>> "LMI" == Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
LMI> jidanni@jidanni.org writes:

LMI> Doesn't `Q' delete the summary buffer for you?  It does for me.
>> 
>> Here's the exact sequence typed while reading this message in
>> gmane.emacs.gnus.general:
>> Q y C-x s q y C-g C-h l

LMI> But what's the answer to the question?

I'm trying to say one will not be able to exit emacs without being
warned about that leftover buffer. Of course it might be a side effect
of my http://jidanni.org/comp/configuration/



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: still asked later after gnus-summary-exit-no-update
  2012-01-06 20:46     ` Lars Magne Ingebrigtsen
@ 2012-01-08 17:34       ` Dan Christensen
  2012-01-27 17:12         ` Lars Ingebrigtsen
  0 siblings, 1 reply; 17+ messages in thread
From: Dan Christensen @ 2012-01-08 17:34 UTC (permalink / raw)
  To: ding

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Dan Christensen <jdc@uwo.ca> writes:
>
>> I just updated to latest git gnus (55c26cf1a993...) and when I hit
>> `Q y', the summary buffer is not killed. 
>
> Do you have `gnus-kill-summary-on-exit' unset?

Yes, it is nil.  This is handy when I exit with `q' but immediately
decide to jump back into the group.  Maybe exiting with `Q' should
ignore this variable?

By the way, I'm pretty sure that in the past (say, a year ago and
more), the summary buffer was killed when I used `Q' to exit, and
I haven't changed the setting of gnus-kill-summary-on-exit.

Dan




^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: still asked later after gnus-summary-exit-no-update
  2012-01-08 17:34       ` Dan Christensen
@ 2012-01-27 17:12         ` Lars Ingebrigtsen
  2012-01-28  0:57           ` Dan Christensen
  0 siblings, 1 reply; 17+ messages in thread
From: Lars Ingebrigtsen @ 2012-01-27 17:12 UTC (permalink / raw)
  To: ding

Dan Christensen <jdc@uwo.ca> writes:

>> Do you have `gnus-kill-summary-on-exit' unset?
>
> Yes, it is nil.  This is handy when I exit with `q' but immediately
> decide to jump back into the group.  Maybe exiting with `Q' should
> ignore this variable?

It should, and if I unset that variable, enter a group, exit the group,
and then press `Q', Gnus kills the buffer without querying me.

So I'm not able to reproduce this bug.

(setq debug-on-quit t) and `C-g' when it prompts you, and post the
backtrace.

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: still asked later after gnus-summary-exit-no-update
  2012-01-27 17:12         ` Lars Ingebrigtsen
@ 2012-01-28  0:57           ` Dan Christensen
  2012-01-30 16:59             ` Lars Ingebrigtsen
  0 siblings, 1 reply; 17+ messages in thread
From: Dan Christensen @ 2012-01-28  0:57 UTC (permalink / raw)
  To: ding

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Dan Christensen <jdc@uwo.ca> writes:
>
>>> Do you have `gnus-kill-summary-on-exit' unset?
>>
>> Yes, it is nil.  This is handy when I exit with `q' but immediately
>> decide to jump back into the group.  Maybe exiting with `Q' should
>> ignore this variable?
>
> It should, and if I unset that variable, enter a group, exit the group,
> and then press `Q', Gnus kills the buffer without querying me.
>
> So I'm not able to reproduce this bug.
>
> (setq debug-on-quit t) and `C-g' when it prompts you, and post the
> backtrace.

Gnus doesn't prompt me.  It just jumps me to the *Group* buffer and
leaves the *Summary* buffer hanging around.

Dan




^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: still asked later after gnus-summary-exit-no-update
  2012-01-28  0:57           ` Dan Christensen
@ 2012-01-30 16:59             ` Lars Ingebrigtsen
  2012-02-01  3:34               ` Dan Christensen
  0 siblings, 1 reply; 17+ messages in thread
From: Lars Ingebrigtsen @ 2012-01-30 16:59 UTC (permalink / raw)
  To: ding

Dan Christensen <jdc@uwo.ca> writes:

> Gnus doesn't prompt me.  It just jumps me to the *Group* buffer and
> leaves the *Summary* buffer hanging around.

When you type `Q' in the group buffer?

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: still asked later after gnus-summary-exit-no-update
  2012-01-30 16:59             ` Lars Ingebrigtsen
@ 2012-02-01  3:34               ` Dan Christensen
  2012-02-01 13:18                 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 17+ messages in thread
From: Dan Christensen @ 2012-02-01  3:34 UTC (permalink / raw)
  To: ding

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Dan Christensen <jdc@uwo.ca> writes:
>
>> Gnus doesn't prompt me.  It just jumps me to the *Group* buffer and
>> leaves the *Summary* buffer hanging around.
>
> When you type `Q' in the group buffer?

When I type `Q' in the summary buffer.

Dan




^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: still asked later after gnus-summary-exit-no-update
  2012-02-01  3:34               ` Dan Christensen
@ 2012-02-01 13:18                 ` Lars Ingebrigtsen
  2012-02-02 23:54                   ` Dan Christensen
  0 siblings, 1 reply; 17+ messages in thread
From: Lars Ingebrigtsen @ 2012-02-01 13:18 UTC (permalink / raw)
  To: ding

Dan Christensen <jdc@uwo.ca> writes:

>>> Gnus doesn't prompt me.  It just jumps me to the *Group* buffer and
>>> leaves the *Summary* buffer hanging around.
>>
>> When you type `Q' in the group buffer?
>
> When I type `Q' in the summary buffer.

Yes, that's what's supposed to happen if you don't have
`gnus-kill-summary-on-exit' set.  :-)

I think this bug report was about `Q' in the group buffer.

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: still asked later after gnus-summary-exit-no-update
  2012-02-01 13:18                 ` Lars Ingebrigtsen
@ 2012-02-02 23:54                   ` Dan Christensen
  2012-02-06 22:22                     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 17+ messages in thread
From: Dan Christensen @ 2012-02-02 23:54 UTC (permalink / raw)
  To: ding

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Dan Christensen <jdc@uwo.ca> writes:
>
>>>> Gnus doesn't prompt me.  It just jumps me to the *Group* buffer and
>>>> leaves the *Summary* buffer hanging around.
>>>
>>> When you type `Q' in the group buffer?
>>
>> When I type `Q' in the summary buffer.
>
> Yes, that's what's supposed to happen if you don't have
> `gnus-kill-summary-on-exit' set.  :-)

No.  With gnus-kill-summary-on-exit set to nil, the summary buffer
is supposed to be renamed when you exit.  If I hit `Q' in the summary
buffer, then I want any changes I made to that buffer to not be made.
But when I re-enter the group (after exiting with `Q' and with
gnus-kill-summary-on-exit set to nil) I just pop right back into the
*same* summary buffer, with the same changes still in place.  I don't
think that makes sense.  And it isn't consistent with what happens if I
exit with `q', and re-enter, which gives me a fresh summary buffer
(since the old one has been renamed).

Moreover, it looks like the intent of the code agrees with me.
In gnus-summary-exit-no-update I find:

      (if (not gnus-kill-summary-on-exit)
	  (gnus-deaden-summary)
	(gnus-close-group group)
	(gnus-kill-buffer gnus-summary-buffer))

So I'm not sure why this isn't working!

> I think this bug report was about `Q' in the group buffer.

No, it was about `Q' in the summary buffer:

> Lars wrote:
> 
> jidanni@jidanni.org writes:
> 
> > Let's say we exit a group with
> > Q runs the command gnus-summary-exit-no-update
> > Well, later when we use
> > q runs the command gnus-group-exit
> > we are still asked
> > Update summary buffer *Summary ...*? (y, n, !, ., q, or C-h)
> 
> Doesn't `Q' delete the summary buffer for you?  It does for me.

The message jidanni sees when exiting gnus with q is a side-effect of
the same problem that I'm noticing when you exit the Summary buffer
with `Q'.  And it's slightly dangerous, since my reaction is to hit
`y' when I see that question, which would save changes that I explicitly
asked gnus not to save.

Dan




^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: still asked later after gnus-summary-exit-no-update
  2012-02-02 23:54                   ` Dan Christensen
@ 2012-02-06 22:22                     ` Lars Ingebrigtsen
  2012-02-09  1:33                       ` Dan Christensen
  0 siblings, 1 reply; 17+ messages in thread
From: Lars Ingebrigtsen @ 2012-02-06 22:22 UTC (permalink / raw)
  To: ding

Dan Christensen <jdc@uwo.ca> writes:

> Moreover, it looks like the intent of the code agrees with me.
> In gnus-summary-exit-no-update I find:
>
>       (if (not gnus-kill-summary-on-exit)
> 	  (gnus-deaden-summary)
> 	(gnus-close-group group)
> 	(gnus-kill-buffer gnus-summary-buffer))
>
> So I'm not sure why this isn't working!

Ah, right.  Sorry for the confusion; this should now be fixed in No
Gnus.

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: still asked later after gnus-summary-exit-no-update
  2012-02-06 22:22                     ` Lars Ingebrigtsen
@ 2012-02-09  1:33                       ` Dan Christensen
  0 siblings, 0 replies; 17+ messages in thread
From: Dan Christensen @ 2012-02-09  1:33 UTC (permalink / raw)
  To: ding

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Ah, right.  Sorry for the confusion; this should now be fixed in No
> Gnus.

Thanks!  I tested it and it works.

Dan




^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2012-02-09  1:33 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-21 18:32 still asked later after gnus-summary-exit-no-update jidanni
2011-11-29  5:42 ` Dan Christensen
2012-01-03 22:24 ` Lars Magne Ingebrigtsen
2012-01-05 14:01   ` jidanni
2012-01-06 20:47     ` Lars Magne Ingebrigtsen
2012-01-06 23:15       ` jidanni
2012-01-05 16:03   ` Dan Christensen
2012-01-06 20:46     ` Lars Magne Ingebrigtsen
2012-01-08 17:34       ` Dan Christensen
2012-01-27 17:12         ` Lars Ingebrigtsen
2012-01-28  0:57           ` Dan Christensen
2012-01-30 16:59             ` Lars Ingebrigtsen
2012-02-01  3:34               ` Dan Christensen
2012-02-01 13:18                 ` Lars Ingebrigtsen
2012-02-02 23:54                   ` Dan Christensen
2012-02-06 22:22                     ` Lars Ingebrigtsen
2012-02-09  1:33                       ` Dan Christensen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).