Re: `S t' always returns nil

[Christopher Splinter <chris@splinter.inka.de>]

Ted Zlatanov <tzz@lifelogs.com> writes:

> On Sun, 26 Jan 2003, chris@splinter.inka.de wrote:
>> I think there is something wrong with `S t' as it always
>> returns a spamicity of 0, even if the concerned mail is clearly
>> spam and is recognized as such by bogofilter, too. 
>> 
>> | X-Bogosity: Spam, tests=bogofilter, spamicity=0.9056373309,
>> | version=0.10.1.1.cvs.20030125
>> 
>> The variables which are related to bogofilter are set properly.
>
> Hmm, the version I used for testing had lines like this:
>
> X-Bogosity: Yes, tests=bogofilter, spamicity=0.567040, version=0.9.1.2

You still get this output (at least by default) using the
Robinson or the Graham algorithm. The newer Robinson-Fisher
though, which has three possible return values, can return
'Spam', 'Ham' or 'Unsure'.

Currently Robinson is the default algorithm, but AFAIK it is
considered to change it to Robinson-Fisher.

> so I wrote spam-check-bogofilter-headers to look for "X-Bogosity: Yes"
> headers, see below.
>
> (defun spam-check-bogofilter-headers (&optional score)
>   (let ((header (message-fetch-field spam-bogofilter-header)))
>       (when (and header
> 	       (string-match "^Yes" header))

Gna. Should've seen this.

> Fixing this is trivial, but should I match on something else, or
> should I allow both ^Yes and ^Spam as valid spam indicators in the
> header?

Since the indicators are configurable, it might be advisable to
allow the user to tell Gnus what to match on.

There's one thing to be decided if Robinson-Fisher is integrated into
spam.el, though: What should be done with the 'unsure' messages?
Should they be moved to a separate group?