Re: show attachments on the top

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> Lars Ingebrigtsen wrote:
>> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>
>>> Maybe no one will add a MIME part in this way; people (or almost
>>> mail clients) add attachments at the bottom no matter how the body
>>> is big.  Because of this, I sometimes overlook them.
>>>
>>> The code in this attachment makes Gnus show attachments at the top.
>>> `g' toggles the appearance.
>
>> Making the attachments more visible is a good idea.  Would it make sense
>> to add a new "header" in the display that just lists them?
>
>> Attachments: [button] [button] [button]
>
>> They could also be included where they are in the message like now, but
>> listing them twice shouldn't be a problem...
>
> Thanks for the suggestion.  I've implemented this in the Gnus Git
> master.  Now the feature is turned on by default.  If you don't
> want it, set `gnus-mime-display-attachment-buttons-in-header' to
> nil.
>
> If you have the old code in your .gnus.el file, please remove it
> anyway.  Customize `gnus-header-face-alist' as follows if you
> want to change the appearance of buttons:
>
> (eval-after-load "gnus-art"
>   '(add-to-list
>     'gnus-header-face-alist
>     '("Attachments?:" Header-Name-Face Header-Content-Face)))
>
> When you customize it, note that the element that begins with
> "" should be the last item of `gnus-header-face-alist'.

I really like this change! One thing that seems a bit broken now,
though, is hitting "K o" from the summary buffer --
gnus-article-save-part. I tried it on a few different messages, and they
all gave me the same error, below. I haven't customized much in this
area, so I assume it's not a local issue, but let me know if you want
more information.

Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p "2")
  gnus-article-part-wrapper(nil mm-save-part)
  gnus-article-save-part(nil)
  call-interactively(gnus-article-save-part nil nil)

Thanks,
Eric