* Mass removal of unused Gnus functions
@ 2012-07-25 6:40 Tassilo Horn
2012-07-25 12:02 ` Julien Danjou
0 siblings, 1 reply; 4+ messages in thread
From: Tassilo Horn @ 2012-07-25 6:40 UTC (permalink / raw)
To: ding; +Cc: Julien Danjou
Hi Julien,
your commit 992509a3574f9add376cc480db9bb5656285bd5b removed lots of
dead code, but at least `gnus-kill-sticky-article-buffers' was not as
dead as you've suspected.
It is a user frontend function that's also documented in the manual.
It's never called internally, and it's not even bound to a key because
it's not really connected to any gnus mode.
Bye,
Tassilo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Mass removal of unused Gnus functions
2012-07-25 6:40 Mass removal of unused Gnus functions Tassilo Horn
@ 2012-07-25 12:02 ` Julien Danjou
2012-07-25 12:21 ` Tassilo Horn
0 siblings, 1 reply; 4+ messages in thread
From: Julien Danjou @ 2012-07-25 12:02 UTC (permalink / raw)
To: Tassilo Horn; +Cc: ding
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
On Wed, Jul 25 2012, Tassilo Horn wrote:
Hi Tassilo,
> your commit 992509a3574f9add376cc480db9bb5656285bd5b removed lots of
> dead code, but at least `gnus-kill-sticky-article-buffers' was not as
> dead as you've suspected.
>
> It is a user frontend function that's also documented in the manual.
> It's never called internally, and it's not even bound to a key because
> it's not really connected to any gnus mode.
Good catch. I was sure there would be one or two mistakes in the whole
patch, but I think it was worth it anyway, and was ready to respond to
my mistake! ;)
I restored the function, thank for notifying me, and sorry for
disturbing. :)
Cheers,
--
Julien Danjou
# Free Software hacker & freelance
# http://julien.danjou.info
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Mass removal of unused Gnus functions
2012-07-25 12:02 ` Julien Danjou
@ 2012-07-25 12:21 ` Tassilo Horn
2012-09-04 22:49 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Tassilo Horn @ 2012-07-25 12:21 UTC (permalink / raw)
To: ding
Julien Danjou <julien@danjou.info> writes:
>> your commit 992509a3574f9add376cc480db9bb5656285bd5b removed lots of
>> dead code, but at least `gnus-kill-sticky-article-buffers' was not as
>> dead as you've suspected.
>>
>> It is a user frontend function that's also documented in the manual.
>> It's never called internally, and it's not even bound to a key
>> because it's not really connected to any gnus mode.
>
> Good catch. I was sure there would be one or two mistakes in the whole
> patch, but I think it was worth it anyway, and was ready to respond to
> my mistake! ;)
Yes, sure, removing cruft is almost always a good thing. And one false
positive in more than a dozen functions is not so bad.
> I restored the function, thank for notifying me, and sorry for
> disturbing. :)
No problem.
Bye,
Tassilo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Mass removal of unused Gnus functions
2012-07-25 12:21 ` Tassilo Horn
@ 2012-09-04 22:49 ` Lars Ingebrigtsen
0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2012-09-04 22:49 UTC (permalink / raw)
To: ding
Tassilo Horn <tassilo@member.fsf.org> writes:
> Yes, sure, removing cruft is almost always a good thing.
Yes, Julien, thanks for doing this.
--
(domestic pets only, the antidote for overdose, milk.)
http://lars.ingebrigtsen.no * Sent from my Emacs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-04 22:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-25 6:40 Mass removal of unused Gnus functions Tassilo Horn
2012-07-25 12:02 ` Julien Danjou
2012-07-25 12:21 ` Tassilo Horn
2012-09-04 22:49 ` Lars Ingebrigtsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).