Gnus development mailing list
 help / color / mirror / Atom feed
From: Simon Josefsson <simon@josefsson.org>
To: Jason Rumney <jasonr@gnu.org>
Cc: ding@gnus.org
Subject: Re: Sieve gets in infinite loop
Date: Fri, 08 Jan 2010 19:56:05 +0100	[thread overview]
Message-ID: <87d41kbf3u.fsf@mocca.josefsson.org> (raw)
In-Reply-To: <4B475FA6.4060308@gnu.org> (Jason Rumney's message of "Sat, 09 Jan 2010 00:39:02 +0800")

Jason Rumney <jasonr@gnu.org> writes:

> Simon Josefsson wrote:
>> According to http://tools.ietf.org/html/draft-ietf-sieve-managesieve-09
>> the response line can contain an optional string:
>>
>>     response-nobye        = ("NO" / "BYE") [SP "(" resp-code ")"]
>>                             [SP string] CRLF
>>                             ;; The string contains human readable text
>>                             ;; encoded as UTF-8.
>>
>>   
> I guess you meant to paste the response-ok definition there, but they
> are basically the same.

Ah, right.

>> So how about
>>
>> -  (when (re-search-forward (concat "^OK" sieve-manage-server-eol) nil t)
>> +  (when (re-search-forward (concat "^OK.*" sieve-manage-server-eol) nil t)
>>
>> instead?  Not perfect, but hopefully would solve your problem and still
>> match EOL stuff.
>>   
>
> So the gnus developers are OK about ignoring this statement in section
> 1.3 of the RFC?

It's not an RFC yet.

>   The contents of the string SHOULD be shown to the user and
>   implementations MUST NOT attempt to parse the message for meaning.
>
> Following it would mean parsing the response properly, but I'm not
> sure it is worth it for this case.

Better patches are welcome.

/Simon



      reply	other threads:[~2010-01-08 18:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87ws1msdgx.fsf@wanchan.jasonrumney.net>
2009-11-21 19:31 ` Reiner Steib
2010-01-08 15:48   ` Jason Rumney
2010-01-08 15:56     ` Simon Josefsson
2010-01-08 16:39       ` Jason Rumney
2010-01-08 18:56         ` Simon Josefsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d41kbf3u.fsf@mocca.josefsson.org \
    --to=simon@josefsson.org \
    --cc=ding@gnus.org \
    --cc=jasonr@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).