Gnus development mailing list
 help / color / mirror / Atom feed
From: Kevin Ryde <user42@zip.com.au>
Subject: /etc/mailcap test specs
Date: Wed, 25 Jan 2006 11:58:59 +1100	[thread overview]
Message-ID: <87d5ihw2b0.fsf@zip.com.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

I think the "test" specs parsed from /etc/mailcap are not being tried.
On a tty with DISPLAY unset I find gnus trying to run xpdf (or
acroread), despite having

	test=test -n "$DISPLAY"

I think the info alists in mailcap-mime-data are getting strings
"test" rather than symbols `test', which is making those tests invisible
to mailcap-viewer-passes-test and mailcap-mailcap-entry-passes-test
(those funcs call "(assq 'test info)").

2006-01-21  Kevin Ryde  <user42@zip.com.au>

        * mailcap.el (mailcap-parse-mailcap-extras): "test" key must go into
        alists as symbol not string, since that's what
        mailcap-viewer-passes-test and mailcap-mailcap-entry-passes-test look
        for.

I'd have thought symbols for all keys would be the way to go, but I
see "copiousoutput", "needsx11" and friends are getting tested/used as
strings at the moment.


[-- Attachment #2: mailcap.el.diff --]
[-- Type: text/plain, Size: 622 bytes --]

--- mailcap.el.~7.7.~	2005-10-27 09:38:45.000000000 +1000
+++ mailcap.el	2006-01-21 18:46:31.807002888 +1100
@@ -532,7 +532,12 @@
 		    (skip-chars-forward ";"))
 		(setq done t))))
 	  (setq	value (buffer-substring val-pos (point))))
-	(setq results (cons (cons name value) results))
+	;; `test' as symbol, others like "copiousoutput" and "needsx11" as
+	;; strings
+	(setq results (cons (cons (if (string-equal name "test")
+                                      'test
+                                    name)
+                                  value) results))
 	(skip-chars-forward " \";\n\t"))
       results)))
 

             reply	other threads:[~2006-01-25  0:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-25  0:58 Kevin Ryde [this message]
2006-01-25  4:57 ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d5ihw2b0.fsf@zip.com.au \
    --to=user42@zip.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).