* /etc/mailcap test specs
@ 2006-01-25 0:58 Kevin Ryde
2006-01-25 4:57 ` Katsumi Yamaoka
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Ryde @ 2006-01-25 0:58 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
I think the "test" specs parsed from /etc/mailcap are not being tried.
On a tty with DISPLAY unset I find gnus trying to run xpdf (or
acroread), despite having
test=test -n "$DISPLAY"
I think the info alists in mailcap-mime-data are getting strings
"test" rather than symbols `test', which is making those tests invisible
to mailcap-viewer-passes-test and mailcap-mailcap-entry-passes-test
(those funcs call "(assq 'test info)").
2006-01-21 Kevin Ryde <user42@zip.com.au>
* mailcap.el (mailcap-parse-mailcap-extras): "test" key must go into
alists as symbol not string, since that's what
mailcap-viewer-passes-test and mailcap-mailcap-entry-passes-test look
for.
I'd have thought symbols for all keys would be the way to go, but I
see "copiousoutput", "needsx11" and friends are getting tested/used as
strings at the moment.
[-- Attachment #2: mailcap.el.diff --]
[-- Type: text/plain, Size: 622 bytes --]
--- mailcap.el.~7.7.~ 2005-10-27 09:38:45.000000000 +1000
+++ mailcap.el 2006-01-21 18:46:31.807002888 +1100
@@ -532,7 +532,12 @@
(skip-chars-forward ";"))
(setq done t))))
(setq value (buffer-substring val-pos (point))))
- (setq results (cons (cons name value) results))
+ ;; `test' as symbol, others like "copiousoutput" and "needsx11" as
+ ;; strings
+ (setq results (cons (cons (if (string-equal name "test")
+ 'test
+ name)
+ value) results))
(skip-chars-forward " \";\n\t"))
results)))
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: /etc/mailcap test specs
2006-01-25 0:58 /etc/mailcap test specs Kevin Ryde
@ 2006-01-25 4:57 ` Katsumi Yamaoka
0 siblings, 0 replies; 2+ messages in thread
From: Katsumi Yamaoka @ 2006-01-25 4:57 UTC (permalink / raw)
Cc: ding
>>>>> In <87d5ihw2b0.fsf@zip.com.au> Kevin Ryde wrote:
> I think the "test" specs parsed from /etc/mailcap are not being tried.
> On a tty with DISPLAY unset I find gnus trying to run xpdf (or
> acroread), despite having
> test=test -n "$DISPLAY"
> I think the info alists in mailcap-mime-data are getting strings
> "test" rather than symbols `test', which is making those tests invisible
> to mailcap-viewer-passes-test and mailcap-mailcap-entry-passes-test
> (those funcs call "(assq 'test info)").
> 2006-01-21 Kevin Ryde <user42@zip.com.au>
> * mailcap.el (mailcap-parse-mailcap-extras): "test" key must go into
> alists as symbol not string, since that's what
> mailcap-viewer-passes-test and mailcap-mailcap-entry-passes-test look
> for.
> I'd have thought symbols for all keys would be the way to go, but I
> see "copiousoutput", "needsx11" and friends are getting tested/used as
> strings at the moment.
Thank you for the patch. I've applied it to the trunk and the
v5-10 branch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-25 4:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-25 0:58 /etc/mailcap test specs Kevin Ryde
2006-01-25 4:57 ` Katsumi Yamaoka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).